Activity OpenACS/

do not allow acs-subsite TmpDir parameter to define where the tmpfolder is located anymore. This MUST be the one configured in the server-wide configuration. Tmpfiles cannot be in a subfolder of the tmpfolder, they MUST be direct children instead. A tmpfile MUST exist beforehand and be owned, be readable and writable by the user running the nsd process. This complies with the definition of a tmpfile by AolServer/NaviServer when they are created to store content coming from a file upload.

- -5
- +5
/openacs-4/packages/acs-subsite/acs-subsite.info
- History
- Source
- Diff
/openacs-4/packages/.../acs-subsite.info
- -2
- +2
/openacs-4/packages/acs-tcl/acs-tcl.info
- History
- Source
- Diff
/openacs-4/packages/acs-tcl/acs-tcl.info
- -36
- +2
/openacs-4/packages/acs-tcl/tcl/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl
- -24
- +10
/openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
- History
- Source
- Diff
/openacs-4/.../tcl-documentation-procs.tcl
- -28
- +0
/openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl

6:01 pm

antoniop

Extend tmpfile filter to behave in the "old way" (default), or in strict mode e.g. tmpfile(strict), enforcing the behavior for tmpfile in Aolserver/Naviserver when a form is processed

- -12
- +30
/openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
- History
- Source
- Diff
/openacs-4/.../tcl-documentation-procs.tcl

5:37 pm

antoniop

Reimplement ad_page_contract_filter_proc_tmpfile using security::safe_tmpfile_p

Some of the features implemented by this filter have been ported into the api, namely the possibility to fetch the valid temp folders from the subsite TmpDir parameter and the possibility to relax the check and allow also files deeper in the tmpfolder hierachy.

Notably, the hardcoded tmpfolders "/var/tmp" and "/tmp" have NOT been ported. One should configure these values via the many available options. security::safe_tmpfile_p is also more restrictive when a file exists, because it checks for ownership and read and write permissions on the file.

- -3
- +42
/openacs-4/packages/acs-tcl/tcl/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl
- -17
- +8
/openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
- History
- Source
- Diff
/openacs-4/.../tcl-documentation-procs.tcl
- -1
- +30
/openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl

4:16 pm

antoniop

Comment WIP

- -6
- +6
/openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../parameter-procs.tcl

3:12 pm

antoniop

Declare proc coverage

- -0
- +2
/openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../http-client-procs.tcl
- -0
- +1
/openacs-4/packages/acs-templating/tcl/test/file-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test/file-procs.tcl

3:09 pm

antoniop

Factor the payload building behavior in util::http::post into its own proc, so that it can be reused elsewhere

- -69
- +170
/openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../http-client-procs.tcl

2:45 pm

antoniop

Make also sure the tmpfile from the widget exists beforehand, when validating: we don't want users to "explore" our tmpdir with bogus values that just look sane

- -3
- +3
/openacs-4/packages/acs-templating/acs-templating.info
- History
- Source
- Diff
/openacs-4/packages/.../acs-templating.info
- -1
- +1
/openacs-4/packages/acs-templating/tcl/file-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/file-procs.tcl
- -11
- +24
/openacs-4/packages/acs-templating/tcl/test/data-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test/data-procs.tcl

2:37 pm

antoniop

Add must_exist flag to enforce a safe tmpfile to already exist

- -2
- +2
/openacs-4/packages/acs-tcl/acs-tcl.info
- History
- Source
- Diff
/openacs-4/packages/acs-tcl/acs-tcl.info
- -4
- +9
/openacs-4/packages/acs-tcl/tcl/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl
- -1
- +6
/openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl

1:44 pm

gustafn

Fixed bug in util_convert_line_breaks_to_html

The code deleted spaces around certain tags, while - according to the

documentation, only line breaks should be removed from there.

Extended regression test.

- -4
- +5
/openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../text-html-procs.tcl
- -5
- +14
/openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl
- History
- Source
- Diff
/openacs-4/.../html-conversion-procs.tcl

1:37 pm

antoniop

Improve doc

- -3
- +3
/openacs-4/packages/acs-templating/tcl/file-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/file-procs.tcl

1:34 pm

antoniop

Revert to previous template::widget::file behavior of accepting input in a form of a list of 3 elements (e.g. without a .tmpfile in the request), but introduce validation so that we enforce all widget values to be in the proper format and the files to be "safe"