Activity OpenACS/

6:01 pm

antoniop

Extend tmpfile filter to behave in the "old way" (default), or in strict mode e.g. tmpfile(strict), enforcing the behavior for tmpfile in Aolserver/Naviserver when a form is processed

- -12
- +30
/openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
- History
- Source
- Diff
/openacs-4/.../tcl-documentation-procs.tcl

5:37 pm

antoniop

Reimplement ad_page_contract_filter_proc_tmpfile using security::safe_tmpfile_p

Some of the features implemented by this filter have been ported into the api, namely the possibility to fetch the valid temp folders from the subsite TmpDir parameter and the possibility to relax the check and allow also files deeper in the tmpfolder hierachy.

Notably, the hardcoded tmpfolders "/var/tmp" and "/tmp" have NOT been ported. One should configure these values via the many available options. security::safe_tmpfile_p is also more restrictive when a file exists, because it checks for ownership and read and write permissions on the file.

- -3
- +42
/openacs-4/packages/acs-tcl/tcl/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl
- -17
- +8
/openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
- History
- Source
- Diff
/openacs-4/.../tcl-documentation-procs.tcl
- -1
- +30
/openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl

4:16 pm

antoniop

Comment WIP

- -6
- +6
/openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../parameter-procs.tcl

3:12 pm

antoniop

Declare proc coverage

- -0
- +2
/openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../http-client-procs.tcl
- -0
- +1
/openacs-4/packages/acs-templating/tcl/test/file-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test/file-procs.tcl

3:09 pm

antoniop

Factor the payload building behavior in util::http::post into its own proc, so that it can be reused elsewhere

- -69
- +170
/openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../http-client-procs.tcl

2:45 pm

antoniop

Make also sure the tmpfile from the widget exists beforehand, when validating: we don't want users to "explore" our tmpdir with bogus values that just look sane

- -3
- +3
/openacs-4/packages/acs-templating/acs-templating.info
- History
- Source
- Diff
/openacs-4/packages/.../acs-templating.info
- -1
- +1
/openacs-4/packages/acs-templating/tcl/file-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/file-procs.tcl
- -11
- +24
/openacs-4/packages/acs-templating/tcl/test/data-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test/data-procs.tcl

2:37 pm

antoniop

Add must_exist flag to enforce a safe tmpfile to already exist

- -2
- +2
/openacs-4/packages/acs-tcl/acs-tcl.info
- History
- Source
- Diff
/openacs-4/packages/acs-tcl/acs-tcl.info
- -4
- +9
/openacs-4/packages/acs-tcl/tcl/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl
- -1
- +6
/openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl

1:44 pm

gustafn

Fixed bug in util_convert_line_breaks_to_html

The code deleted spaces around certain tags, while - according to the

documentation, only line breaks should be removed from there.

Extended regression test.

- -4
- +5
/openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../text-html-procs.tcl
- -5
- +14
/openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl
- History
- Source
- Diff
/openacs-4/.../html-conversion-procs.tcl

1:37 pm

antoniop

Improve doc

- -3
- +3
/openacs-4/packages/acs-templating/tcl/file-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/file-procs.tcl

1:34 pm

antoniop

Revert to previous template::widget::file behavior of accepting input in a form of a list of 3 elements (e.g. without a .tmpfile in the request), but introduce validation so that we enforce all widget values to be in the proper format and the files to be "safe"

- -3
- +3
/openacs-4/packages/acs-templating/acs-templating.info
- History
- Source
- Diff
/openacs-4/packages/.../acs-templating.info
- -0
- +1
/openacs-4/packages/acs-templating/catalog/acs-templating.en_US.ISO-8859-1.xml
- History
- Source
- Diff
/openacs-4/.../acs-templating.en_US.ISO-8859-1.xml
- -42
- +83
/openacs-4/packages/acs-templating/tcl/file-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/file-procs.tcl
- -7
- +14
/openacs-4/packages/acs-templating/tcl/test/data-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test/data-procs.tcl
- -0
- +244
/openacs-4/packages/acs-templating/tcl/test/file-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test/file-procs.tcl

1:34 pm

antoniop

More
MAIN:antoniop:20220825113450
deleted 1 file
MAIN

file file-procs.tcl was initially added on branch oacs-5-10.

- -0
- +0
/openacs-4/packages/acs-templating/tcl/test/file-procs.tcl
- History
- Source
/openacs-4/packages/.../test/file-procs.tcl

1:29 pm

antoniop

Bring test closer to reality

- -6
- +14
/openacs-4/packages/file-storage/tcl/test/webtest-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../webtest-procs.tcl

1:25 pm

antoniop

Introduce security::safe_tmpfile_p checking whether a file belongs to the configured tmpfolder and respects other constraints

The plan is to use it to improve input validations

- -2
- +2
/openacs-4/packages/acs-tcl/acs-tcl.info
- History
- Source
- Diff
/openacs-4/packages/acs-tcl/acs-tcl.info
- -1
- +54
/openacs-4/packages/acs-tcl/tcl/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl
- -0
- +45
/openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl

11:53 am

gustafn

Fixed serious bug killing at least short-text questions in inclass exam

The bug was introduced in [1], by testing for the existence of the

disabled attribute, and when it exists, it was omitting values

reading. The problem is that when form-fields are reset, the

"disabled" attribute is set to 0, leading the exists check to

succeed. In essence, This change sets now the default value of the

form-field to "0", such that it is safe to test it everywhere.

Originally, it was not set by default to save resources (memory and

processing power), but this requires a more careful analysis when

changes happen.

[1] https://fisheye.openacs.org/browse/OpenACS/openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl?r1=1.368.2.125&r2=1.368.2.126

- -2
- +2
/openacs-4/packages/xowiki/tcl/form-field-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../form-field-procs.tcl
- -12
- +11
/openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../xowiki-www-procs.tcl

7:45 pm

gustafn

Tighten test for is_wf_instance

Previously, the test was based on setting of state and FormPage.

In cases, where plain FormPages are used inside an xowf package

this test was leading to wrong results.

- -1
- +4
/openacs-4/packages/xowf/tcl/xowf-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/xowf-procs.tcl
- -0
- +1
/openacs-4/packages/xowf/tcl/test/test-item-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test-item-procs.tcl

6:50 pm

gustafn

base all timings on NavigationTiming plugin to get closer to previous behavior

- -5
- +13
/openacs-4/packages/boomerang/tcl/boomerang-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../boomerang-procs.tcl
- -0
- +456
/openacs-4/packages/boomerang/www/resources/plugins-1.737.0/navtiming.js
- History
- Source
- Diff
/openacs-4/packages/.../navtiming.js

6:50 pm

gustafn

More
MAIN:gustafn:20220824165031
deleted 1 file
MAIN

file navtiming.js was initially added on branch oacs-5-10.

- -0
- +0
/openacs-4/packages/boomerang/www/resources/plugins-1.737.0/navtiming.js
- History
- Source
/openacs-4/packages/.../navtiming.js

6:00 pm

gustafn

improved error message

make clear, what the name and what the item_id in the message are

- -2
- +2
/openacs-4/packages/xowiki/tcl/folder-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/folder-procs.tcl

5:59 pm

gustafn

use new path xowiki/lib/portlets/ instead of .../www/...

- -3
- +4
/openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/xowiki-procs.tcl

5:57 pm

gustafn

comment method

- -1
- +4
/openacs-4/packages/xowiki/tcl/xowiki-uploader-procs.tcl
- History
- Source
- Diff
/openacs-4/.../xowiki-uploader-procs.tcl

4:51 pm

gustafn

Deactivated script-dynamic again

activating "script-dynamic" for script-src prevents resources as the following from loading

- -2
- +2
/openacs-4/packages/acs-tcl/tcl/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl

4:30 pm

gustafn

improve test coverage of apm_* API

- -0
- +24
/openacs-4/packages/acs-tcl/tcl/test/apm-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test/apm-procs.tcl

4:28 pm

gustafn

reduce verbosity

- -1
- +1
/openacs-4/packages/openacs-bootstrap5-theme/resources/widgets/login.tcl
- History
- Source
- Diff
/openacs-4/packages/.../widgets/login.tcl

2:13 pm

gustafn

added test for checking documentation in regard of valid HTML markup

- -2
- +53
/openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../doc-check-procs.tcl

10:58 am

antoniop

Test the behavior of the file-storage when a malicious user would try to store a pre-existing file on the server as its own

The fix for the file-storage is a simple validation to make sure that the tmpfile exists, however, for the generic case of the file widget, we cannot trust the tmpfile value when this was not generated by the server. This will probably cause regression when one wants to show a "preview" of a form, to be continued.