OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 17 Jan 2021
10:02 pm

gustafn

make clear from the user-interface that admin is managing the notifications of someone else

Options
    • -1
    • +1
    /openacs-4/packages/notifications/www/manage.adp
    • -3
    • +19
    /openacs-4/packages/notifications/www/manage.tcl
9:59 pm

gustafn

Let admin manage notifications of a user

Otherwise, we have currently no user-interface to e.g. unsubscribe the notifications of a user

to avoid sending mails to a domain (which might be in user by some other organization).

Options
    • -0
    • +6
    /openacs-4/packages/acs-admin/www/users/one.adp
    • -1
    • +6
    /openacs-4/packages/acs-admin/www/users/one.tcl
Friday 15 Jan 2021
5:39 pm

gustafn

Improve handling of cases, where the exam was closed, but some exam-takers have not submitted their results.

Essentially this change avoids an error message and repeated messages, which might

come form autosaving or other ajax calls.

Options
    • -42
    • +63
    /openacs-4/packages/xowf/lib/inclass-exam-answer.wf
11:49 am

gustafn

provide compatibility for Tcl versions before tcl 8.6.2

Options
    • -1
    • +0
    /openacs-4/packages/acs-tcl/tcl/test/00-icanuse-procs.tcl
Thursday 14 Jan 2021
10:35 pm

gustafn

Revert to previous strategy of determining available subcommands.

Running the provided subcommand is dangerous, since the command might

have side effects, might require connections, etc.

The feature test for "ns_http run" was incorrect, since it was not

introduced with 4.99.15 (as the comment suggested), but already with

4.99.4 (2017)... but at this time, the command did not return a dict,

which is assumed in the http-client procs. One can use "ns_http stats"

as an indicator for this feature, which was introduced at the time

when "ns_http run" was starting to return dicts as results.

Provide a more precise name for the feature test of ns_http returning

dicts (naming the feature simply "ns_http" is not a good idea, since

the command could of course be used already before the feature change).

Options
    • -14
    • +19
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/00-icanuse-procs.tcl
7:20 pm

gustafn

use 'self' for "security::csp::require object-src" instead of 'none' since the latter is non-incremental

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
7:18 pm

gustafn

don't create a cache, which is not needed

Options
    • -5
    • +2
    /openacs-4/packages/acs-tcl/tcl/security-init.tcl
4:24 pm

hectorr

Fix proc name

Options
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
3:40 pm

antoniop

Do not improperly rely on apm_version_names_compare to check for NaviServer version number, use a more reliable capability check instead

Options
    • -0
    • +4
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
    • -9
    • +1
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
3:32 pm

antoniop

Change the regexp so that we catch multiple kinds of error pattern indicating the subcommand does not exist: NaviServer and Tcl return sligthly different error messages

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
3:30 pm

antoniop

Extend test to expose that we need a better idiom to detect also NaviServer commands

Options
    • -0
    • +14
    /openacs-4/packages/acs-tcl/tcl/test/00-icanuse-procs.tcl
3:17 pm

antoniop

Use a different idiom to detect if a command supports a subcommand, fixing acs-tcl.acs__command_has_subcommand automated test

Options
    • -2
    • +8
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
3:16 pm

antoniop

Fix wording

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/00-icanuse-procs.tcl
3:09 pm

antoniop

New test for acs::cmd_has_subcommand exposing how flags at the beginning and end of the error message are not properly recognized

Options
    • -0
    • +49
    /openacs-4/packages/acs-tcl/tcl/test/00-icanuse-procs.tcl
3:09 pm

antoniop

file 00-icanuse-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/test/00-icanuse-procs.tcl
Wednesday 13 Jan 2021
7:19 pm

gustafn

ensure, that the minimal set of controls is provided, also, when there are hidden form fields

Options
    • -6
    • +7
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
7:18 pm

gustafn

improve spelling

Options
    • -3
    • +4
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
7:00 pm

gustafn

since the form-field "file" supports the file multiple attribute, the internal representation is as well a list.

this change takes now as file-name for the local renderer as well the first file name list element.

Options
    • -5
    • +7
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
2:39 pm

trenner

add the original filename to the generated url, so that it is also delivered to the user

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
2:16 pm

antoniop

Keep supporting the previous proc signature, throwing a warning

Options
    • -0
    • +5
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
2:10 pm

antoniop

util::http should provide enough fallback via curl already without targeting specific Naviserver versions, use other fallbacks only when no implementation is available

Options
    • -23
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
    • -2
    • +1
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
1:39 pm

hectorr

Fix webserver version check using 'apm_version_names_compare' for rc versions.

Between 4.99.6 and 4.99.20rc1, for example, 'apm_version_names_compare' will consider the latter to be the lowest.

As this is not the expected behavior for webserver version check, this patch just removes the rc part of the version before comparing in the few cases where this is done, and should be removed if the behavior changes in the future.

Options
    • -2
    • +7
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
    • -1
    • +4
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
12:25 pm

antoniop

Fix version check

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
12:00 pm

antoniop

Tear down a lot of boilerplate used to support native HTTP api on Naviserver versions < 4.99.15, which will now fallback to curl

Options
    • -245
    • +40
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
    • -3
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
11:09 am

antoniop

Doc formatting changes

Options
    • -330
    • +406
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
10:44 am

antoniop

Avoid markup in documentation

Options
    • -72
    • +69
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
10:37 am

antoniop

Reduce people expectations

Options
    • -1
    • +2
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
Tuesday 12 Jan 2021
6:36 pm

antoniop

Fix acs-tcl.logout_from_everywhere test case and support again invalidating of all existing user logins, useful e.g. to make sure no device still holds a valid login when we change our password on a device

Options
    • -15
    • +24
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
6:32 pm

antoniop

Test the use case supposedly supported by sec_change_user_auth_token: invalidate all existing login cookies (e.g. when the users change their password) so that all devices need to log in again

the test exposes a long standing regression (~17 years) where this was broken in order to support persistent login. See e.g. https://openacs.org/forums/message-view?message_id=1691183#msg_1691183

Options
    • -0
    • +64
    /openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl
6:32 pm

antoniop

file security-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl