OpenACS / openacs-4 / packages / xowiki

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 28 Dec 24
Commits this week: 0
Total Lines of Code (LoC): 42,799
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 06 May 2024
4:47 pm

antoniop

Introduce for richtext editors the concept of "preset"

A preset is an abstract set configurations designed to address a specific use case.

An example could be a preset for a "minimal" richtext editor, used in those forms where we want to limit the features a user should have access to. Other presets could address specific usages or applications.

Downstream developers can provide a set of ::richtext::$editor::preset::$preset procs, returning an options dict. This set of options will be merged other local configurations.

The same approach works in ad_forms and xowiki forms.

This also enables the use-case of switching to a different editor maintaining the existing application-specific configurations consistent.

Options
    • -2
    • +34
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
Thursday 02 May 2024
4:06 pm

antoniop

TinyMCE XoWiki formfield integration

We introduce a new richtext mixin richtext::tinymce, requiring the richtext-tinymce package, currently integrating TinyMCE editor 7.0.1.

This implementation has been tested with regular, repeat, compound and repeatedcompound fields.

Downstream implementations based on this formfield can customize the editor configuration further, e.g. provide custom plugins via the api parameters.

Options
    • -1
    • +207
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
3:13 pm

antoniop

Add a richtext to the test formfields specifications

Options
    • -0
    • +2
    ./test/xowiki-test-procs.tcl
2:47 pm

antoniop

Move back richtext formfield implementations in form-field-procs

Moving to a different file may affect dependencies defined on form-field-procs that also expect the richtext editor to be loaded. As breaking changes are not desirable now, we revert this reform.

Options
    • -1
    • +527
    ./form-field-procs.tcl
    • -546
    • +0
    ./richtext-procs.tcl
Tuesday 30 Apr 2024
9:14 am

antoniop

Cleanup leftover code from successful reform in December 2016

Since then, we have been long using dynamic repeat fields on production

Options
    • -15
    • +5
    ./repeat-procs.tcl
  2. … 1 more file in changeset.
Monday 29 Apr 2024
6:05 pm

antoniop

Move the specific richtext-editor implementations into an own file

Options
    • -527
    • +1
    ./form-field-procs.tcl
    • -0
    • +546
    ./richtext-procs.tcl
6:05 pm

antoniop

file richtext-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./richtext-procs.tcl
Friday 05 Apr 2024
10:28 am

gustafn

Improved readability of configuration parameter "parameterSecret"

- Switched to camelCase for better readabilty and uniformity

- NaviServer configuration parameters are case insensitive, so no danger for backward compatibility

Options
    • -3
    • +3
    ./form-field-procs.tcl
  2. … 5 more files in changeset.
Friday 22 Mar 2024
4:06 pm

antoniop

Use a simpler approach to achieve the intended result, which does not rely on events

Options
    • -19
    • +8
    ./chat-procs.tcl
Wednesday 20 Mar 2024
12:25 pm

antoniop

Keep comments on the server side

Options
    • -7
    • +10
    ./chat-procs.tcl
11:25 am

gustafn

JS upstream updates

- Updated highcharts to 11.4.0 (when highcharts package is not installed)

- Updated jquery-3.6.3 to jquery-3.7.1.

- Bumped version number to 5.10.1b10

Options
    • -2
    • +2
    ./resource-init.tcl
  2. … 5 more files in changeset.
11:24 am

antoniop

Ensure chat javascript is executed only when the chat itself is actually a part of the DOM

This may not be the case at the time of rendering, e.g. because the chat is rendered inside of a <template> tag and appended to the document at a later moment.

Options
    • -2
    • +19
    ./chat-procs.tcl
Monday 04 Mar 2024
12:44 pm

antoniop

Fix variable name

Options
    • -2
    • +2
    ./xowiki-www-procs.tcl
Thursday 29 Feb 2024
1:58 pm

antoniop

Introduce server-side validation for HTML5 date and time formfields

A "formats" parameter can be specified on the formfields indicating one or more formats that we want to enforce. The syntax for any of such format is that of the Tcl clock command.

Default values have been set according to the expected behavior of each form field type.

Empty values are always considered valid. If a field is required, this will be enforced in its own validator.

Options
    • -11
    • +69
    ./form-field-procs.tcl
  2. … 3 more files in changeset.
1:53 pm

antoniop

Test behavior of HTML5 date and time formfields when invalid values are submitted

Options
    • -0
    • +186
    ./test/xowiki-test-procs.tcl
Monday 26 Feb 2024
10:58 am

gustafn

removed code, which was commented out since ages.

Options
    • -25
    • +0
    ./yui-init.tcl
Friday 16 Feb 2024
11:31 am

gustafn

Fixed unreviewed commit, which might lead to hard-to-spot errors

The last change assumed that "nls_language" can be hard-wired to

contain most 5 characters. While this not backed by the OpenACS data

model, the standard (RFC 5646) explicitly states that there is no

upper limit on the size of language tags. The tree letter language

codes have been standard since 2001 (RFC 4646).

The change accepts now all defined locales. When the specified locale

is not enabled, it provides a log notice, when the locale is not

defined at all, it provides a warning and falls back to "en_US".

Options
    • -2
    • +17
    ./xowiki-form-procs.tcl
  2. … 3 more files in changeset.
Wednesday 14 Feb 2024
1:54 pm

antoniop

Validate as a token also the default coming from _nls_language, ensure the resulting language key is at most 5 chars long (many thanks to Markus Moser for this)

Options
    • -3
    • +5
    ./xowiki-form-procs.tcl
Friday 09 Feb 2024
11:36 am

gustafn

improved bootstrap5 compatibility for personal notifications

This change improves the appearance of personal notifications

for bootstrap5. It still works with bootstrap3.

Many thanks to Sebastian Scheder for this contribution!

Options
    • -11
    • +24
    ./personal-notification-procs.tcl
Tuesday 06 Feb 2024
11:00 am

antoniop

Improve visualization of test info

Options
    • -2
    • +2
    ./test/xowiki-test-procs.tcl
10:32 am

antoniop

Relax test condition:

make sure potential injections are not rendered on the page response.

Options
    • -6
    • +13
    ./test/xowiki-test-procs.tcl
Friday 02 Feb 2024
1:35 pm

gustafn

Improved consistency of appearance, when multiple CSS toolkits are in use

- This change makes sure that consistently [::xowiki::CSS toolkit] is

used instead of accessing the package parameter

"PreferredCSSToolkit" directly. This change is necessary for

handling e.g. of the parameter setting "default"

consistently. Previously, a "default" value could result in loading

the obsolete YUI .js and .css files.

- When "menu_entries" have multiple "config" entries, use the last one.

Options
    • -5
    • +11
    ./folder-procs.tcl
    • -8
    • +5
    ./table-widget-procs.tcl
1:20 pm

gustafn

Extended "Page.copy_content_vars" with a "-except" parameter

This change makes it possible to use values from template pages

without changing the name of the target page. This change also

introduces a small modernization to use dicts instead of arrays.

Options
    • -7
    • +14
    ./xowiki-procs.tcl
1:14 pm

gustafn

added URL for version checking to see, if a newer version is available from the CDN

Options
    • -1
    • +2
    ./resource-info-procs.tcl
Wednesday 31 Jan 2024
1:48 pm

antoniop

Extend test suite

when testing FormPage validation, make sure two distinct behaviors are respected:

1) Rejected values that were part of the request are kept into their original form fields so the user can rework them and resubmit

2) Other parts of the page, such as the page title, are NOT influenced by data that faild to validate

Rationale: displaying unvalidated information as part of the response can be interpreted as a page injection.

In current codebase, that the title was changed indicates, that rejected information made its way into the :title object member of the FormPage.

The potential consequences of the FormPage setting unvalidated information into its members depends on a number of factors such as formfield logics, callbacks and proper page quoting (to name a few).

Options
    • -1
    • +17
    ./test/xowiki-test-procs.tcl
Tuesday 30 Jan 2024
6:18 pm

gustafn

Reduced attack vectors for query and form variables while keeping semantics

- improve form_parameter and query variable validation

- revert partly change: it is intentional that in case of validation errors, the

instances variables of the in-memory object contain invalid data in order

to be able to show the use the invalid data in the form.

- prefer "string first" idiom over regular expression

Options
    • -54
    • +49
    ./xowiki-www-procs.tcl
6:17 pm

gustafn

fix typo

Options
    • -2
    • +2
    ./xowiki-form-procs.tcl
5:35 pm

antoniop

Fix typo

Options
    • -2
    • +1
    ./xowiki-www-procs.tcl
11:28 am

gustafn

removed obsolete code

Options
    • -5
    • +1
    ./includelet-procs.tcl
11:28 am

gustafn

update CDN source

The previous CDN site stopped working

Options
    • -2
    • +2
    ./yui-init.tcl