OpenACS / openacs-4 / packages / xowiki

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 28 Dec 24
Commits this week: 0
Total Lines of Code (LoC): 42,799
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 13 Sep 2022
12:05 pm

antoniop

Add doc to public api

Options
    • -1
    • +7
    ./bootstrap-procs.tcl
    • -2
    • +12
    ./xowiki-utility-procs.tcl
11:56 am

antoniop

Fix typo in comment

Options
    • -2
    • +2
    ./xowiki-www-procs.tcl
Monday 05 Sep 2022
5:07 pm

antoniop

Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

Options
    • -2
    • +4
    ./xowiki-form-procs.tcl
  2. … 6 more files in changeset.
4:10 pm

antoniop

Fall back to en_US also when a value for nls_language is there, but empty

Options
    • -2
    • +5
    ./xowiki-form-procs.tcl
1:31 pm

antoniop

Use api to determine whether a field is disabled, as the "disabled" variable will always be set now

Options
    • -1
    • +1
    ./repeat-procs.tcl
Monday 29 Aug 2022
11:51 am

antoniop

Use existing api to tell whether a formfield is disabled or not and to set/unset disabled on a field, handle the case of checkboxes and select fields, where the attribute should not be set whe it is false (e.g. disabled=0 == disabled)

This fixes upstream automated tests on xowiki and xowf

Options
    • -21
    • +31
    ./form-field-procs.tcl
    • -9
    • +9
    ./xowiki-www-procs.tcl
Thursday 25 Aug 2022
11:53 am

gustafn

Fixed serious bug killing at least short-text questions in inclass exam

The bug was introduced in [1], by testing for the existence of the

disabled attribute, and when it exists, it was omitting values

reading. The problem is that when form-fields are reset, the

"disabled" attribute is set to 0, leading the exists check to

succeed. In essence, This change sets now the default value of the

form-field to "0", such that it is safe to test it everywhere.

Originally, it was not set by default to save resources (memory and

processing power), but this requires a more careful analysis when

changes happen.

[1] https://fisheye.openacs.org/browse/OpenACS/openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl?r1=1.368.2.125&r2=1.368.2.126

Options
    • -2
    • +2
    ./form-field-procs.tcl
    • -12
    • +11
    ./xowiki-www-procs.tcl
Wednesday 24 Aug 2022
6:00 pm

gustafn

improved error message

make clear, what the name and what the item_id in the message are

Options
    • -2
    • +2
    ./folder-procs.tcl
5:59 pm

gustafn

use new path xowiki/lib/portlets/ instead of .../www/...

Options
    • -3
    • +4
    ./xowiki-procs.tcl
5:57 pm

gustafn

comment method

Options
    • -1
    • +4
    ./xowiki-uploader-procs.tcl
Tuesday 23 Aug 2022
4:53 pm

antoniop

Port of downstream hotfix: questions defined with an empty scoring might later fail the score calculations

One might consider preventing empty scores altogether via validation

Options
    • -3
    • +3
    ./form-field-procs.tcl
Monday 22 Aug 2022
7:06 pm

gustafn

new proc "ad_log_deprecated": unified interface for logging deprecated usages

The existing code used a larger variety of different messages to

denote invocations of deprecated procs and other

artifacts. "ad_log_deprecated" provides a unified interface, and

provides a usage hint what to use instead based on the API-doc

definitions in the log-file.

Options
    • -1
    • +1
    ./menu-procs.tcl
    • -3
    • +2
    ./package-procs.tcl
    • -6
    • +9
    ./xowiki-procs.tcl
    • -4
    • +4
    ./xowiki-utility-procs.tcl
  5. … 8 more files in changeset.
Sunday 21 Aug 2022
6:46 pm

gustafn

rename "iconified file" to "thumbnail file"

Options
    • -4
    • +5
    ./bootstrap-procs.tcl
    • -1
    • +57
    ./package-procs.tcl
    • -2
    • +2
    ./xowiki-uploader-procs.tcl
    • -3
    • +3
    ./xowiki-www-procs.tcl
Saturday 20 Aug 2022
6:36 pm

gustafn

Improved styling: use boostrap card component for rendering includelets

Options
    • -13
    • +39
    ./includelet-procs.tcl
  2. … 1 more file in changeset.
5:43 pm

gustafn

Extended functionality of the DropZone widget

- added parameters "label", "disposition" and "file_name_prefix"

for better configurability

- added support for updating the current page with feedback of the

dropped files. This is used e.g. by the online exam in the exam

protocol to display incrementally thumbnails of feedback files.

- change property "uploader" to "disposition", since "uploader" is

somewhat ambiguous. "Disposition" defines, what happens after the

file was uploaded, e.g. whether the content has to be transformed,

etc.

- bumped version number to 5.10.1d35

Options
    • -24
    • +100
    ./bootstrap-procs.tcl
    • -4
    • +9
    ./menu-procs.tcl
    • -3
    • +18
    ./xowiki-uploader-procs.tcl
    • -14
    • +33
    ./xowiki-www-procs.tcl
  5. … 2 more files in changeset.
12:28 pm

gustafn

fix typo

Options
    • -2
    • +2
    ./includelet-procs.tcl
11:37 am

gustafn

use bootstrap table renderer inside includelets for bootstrap3 and bootstrap5

Options
    • -8
    • +14
    ./includelet-procs.tcl
Friday 19 Aug 2022
9:44 pm

gustafn

moved included stuff from xowiki/www to xowiki/lib

Options
    • -17
    • +17
    ./adp-generator-procs.tcl
Wednesday 17 Aug 2022
7:06 pm

gustafn

Generalized handling of local_return_url

I am not fully happy with the handlings of "return_url" in exam workflows.

Maybe this can be reworked in a way such that "local_return_url" is not

neccsessary in the future.

Options
    • -2
    • +8
    ./package-procs.tcl
    • -5
    • +4
    ./xowiki-www-procs.tcl
Tuesday 16 Aug 2022
4:33 pm

antoniop

Test behavior of the omit formfield spec

Options
    • -0
    • +2
    ./test/xowiki-test-procs.tcl
Sunday 14 Aug 2022
8:31 am

gustafn

Improved support for composite questions and bootstrap 5

This fixes a bug when composite questions were generated with

bootstrap3 and rendered later with bootstrap5.

Options
    • -2
    • +2
    ./package-procs.tcl
  2. … 1 more file in changeset.
Saturday 13 Aug 2022
7:01 pm

gustafn

improve bootstrap5 compatibility for inclass exam

Options
    • -1
    • +2
    ./package-procs.tcl
  2. … 1 more file in changeset.
Friday 12 Aug 2022
7:17 pm

antoniop

Preliminary cleanup

In this test we will loop through instances of ::xowiki::Page currently in memory to perform some checks. When multiple tests run in the same request, we cannot guarantee that other tests won't create ::xowiki::Page instances that won't comply with the conditions here. We cleanup any existing object in advance to start from a clean slate.

Options
    • -0
    • +9
    ./test/xowiki-admin-tests-procs.tcl
Thursday 11 Aug 2022
8:22 pm

antoniop

Skip processing for all formfields that are defined as disabled:

the browser should not send us these data in the first place.

Options
    • -21
    • +29
    ./xowiki-www-procs.tcl
8:16 pm

antoniop

Extend test: show that even when a field is defined as disabled, a request crafted to carry these fields will get through and the values will be stored

A fix will come shortly, similar to what was done for compound fields

Options
    • -3
    • +15
    ./test/xowiki-test-procs.tcl
Wednesday 13 Jul 2022
1:00 pm

gustafn

undo part of last change

unfortunatly, the 0.9.3 issue can't be fixed so simple as hoped. The "-html" flag is necessary for dealing with autoclosed entries.

Options
    • -5
    • +5
    ./xowiki-procs.tcl
    • -2
    • +2
    ./xowiki-www-procs.tcl
12:41 pm

gustafn

for orthogonaly, remove "-html" flag from dom parse to avoid a potential top-level <html> element

Options
    • -2
    • +2
    ./includelet-procs.tcl
    • -3
    • +3
    ./xowiki-form-procs.tcl
    • -1
    • +1
    ./xowiki-init.tcl
    • -7
    • +7
    ./xowiki-procs.tcl
    • -2
    • +2
    ./xowiki-www-procs.tcl
Wednesday 06 Jul 2022
6:14 pm

gustafn

fix compatibility with tdom 0.9.3

Options
    • -2
    • +2
    ./form-field-procs.tcl
Sunday 26 Jun 2022
9:29 pm

gustafn

fix warning (including some false positives) in regression test

Options
    • -1
    • +1
    ./personal-notification-procs.tcl
    • -4
    • +4
    ./test/api-test-procs.tcl
  3. … 4 more files in changeset.
Saturday 25 Jun 2022
10:52 am

gustafn

we need the upgrade script, since the automatic aler just kicks in, when the constraint does not exist. Antonio was right.

Nevertheless, it would be a nice feature, if the ORM would handle this.

Options
    • -1
    • +14
    ./upgrade/upgrade.tcl