• last updated 8 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Avoid rollback in web tests

Avoid rollback in 'fs_add_file_to_folder' test in particular

Rollback after tests

fix error message

Refactor query to go over the fs hierachy, rather than the permission one, add remarks

Recover logic went missing after refactoring (with some remarks)

break overlong lines

stick to content-repository API instead of duplicating code here.

    • -66
    • +0
    ./tcl/file-storage-procs-postgresql.xql
new function: ::content::revision::export_to_filesystem

This change moves functionality from file-storage to acs-content-repository.

all application packages should be free of internals, such as the storage

type. Storage_type should be handeled in the content-repository package.

We are not yet done, there is still more to do in this respect in

the file-storage package.

    • -16
    • +0
    ./tcl/file-storage-procs-oracle.xql
    • -16
    • +0
    ./tcl/file-storage-procs-postgresql.xql
  1. … 4 more files in changeset.
break overlong lines

improve spelling

whitespace changes

extend regression test, add covered procs to webtest

Mark 'fs::max_upload_size' as public, as it is used in 'attachments'

Remove bogus proc name. Fixes 'naming__proc_naming' test case

extend tests by porting obsolete test fs_add_file_to_folder to new web testing framework

Add 'fs_create_folder_using_api' test case, covering the 'fs::get_root_folder', 'fs::new_folder', 'fs::get_folder', 'fs::folder_p', 'fs::delete_folder', 'fs::rename_folder' and 'fs_get_folder_name' procs

Whitespace changes

Use the new 'url' input type

Whitespace changes

    • -23
    • +20
    ./www/admin/upload-size-limit.tcl
Refactoring of the upload-size-limit admin page of the file-storage. Sets a default value of 2GB when no maxinput is found in the config file, and uses the new 'number' ad_form widget. Bump version for the widget dependency

replace low-level cr_fs_path by higher level interface content::revision::get_cr_file_path

    • -1
    • +1
    ./tcl/file-storage-search-procs-postgresql.xql
  1. … 6 more files in changeset.
mark private functions as private

  1. … 9 more files in changeset.
improve listing of test coverage

  1. … 17 more files in changeset.
Fix typo

Do not allow backslashes in folders created via zipfile upload

As the folder name is used also for looking up for existing folders, the safest approach is to block the user: the risk with an automatic sanitization would be to overwrite existing folders without the user realizing

make listing of tested procs more complete

  1. … 11 more files in changeset.
make end of options explicit

  1. … 14 more files in changeset.
improve robustness in case parameter is not (yet) set

  1. … 3 more files in changeset.
Whitespace changes