• last updated 25 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
replace low-level cr_fs_path by higher level interface content::revision::get_cr_file_path

    • -1
    • +1
    ./tcl/file-storage-search-procs-postgresql.xql
  1. … 6 more files in changeset.
mark private functions as private

  1. … 9 more files in changeset.
improve listing of test coverage

  1. … 17 more files in changeset.
Fix typo

Do not allow backslashes in folders created via zipfile upload

As the folder name is used also for looking up for existing folders, the safest approach is to block the user: the risk with an automatic sanitization would be to overwrite existing folders without the user realizing

make listing of tested procs more complete

  1. … 11 more files in changeset.
make end of options explicit

  1. … 14 more files in changeset.
improve robustness in case parameter is not (yet) set

  1. … 3 more files in changeset.
Whitespace changes

Disable RSS offering in file-storage if the RSS generation service is disabled in rss-support. Bump version numbers and fix dependencies, as the RssGenActiveP parameter is only available in latest rss-support.

move xowiki::test::get_url_from_location to automated testing

handle updaed query-handling in ns_parseurl

remoe dependency from file-storage tests to xowiki

  1. … 4 more files in changeset.
use bind variables instead of tcl variable substition in xql fullqueries

    • -1
    • +1
    ./tcl/file-storage-procs-postgresql.xql
  1. … 15 more files in changeset.
Set procs in the 'file_storage::twt' namespace as private

Improve sql portability

  1. … 6 more files in changeset.
use "ad_file" as a means to avoid unexpected tilde substitution in file names

  1. … 4 more files in changeset.
improve SQL quoting

  1. … 4 more files in changeset.
added editor hints and white-space cleanup

  1. … 24 more files in changeset.
improve spelling

    • -2
    • +2
    ./catalog/file-storage.en_AU.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/file-storage.en_US.ISO-8859-1.xml
  1. … 1 more file in changeset.
Use ad_include_contract

Deprecate with_finally and with_catch, superseded by e.g. try idioms in tcl 8.6

They would also not comply with OpenACS naming convention

  1. … 4 more files in changeset.
Fix missing query due to naming convention reform by rewriting the entire proc based on a single portable recursive query

    • -21
    • +0
    ./tcl/file-storage-procs-oracle.xql
    • -20
    • +0
    ./tcl/file-storage-procs-postgresql.xql
move private function children_have_permission_p to fs_* nameing convention

improve spelling and comma settings

  1. … 24 more files in changeset.
Whitespace changes

Copy paste query from copy in the move, as they are the same

This query is also reported downstream as a frequently slow one

Reimplement sorting depth-first sorting criteria in a way that is portable, fix starting depth

Rewrite query often seen among those taking a long time on downstream system

Empirical tests on file storage instances with many folders show this is more efficient that previous version, other than being (supposedly) portable for Oracle and Postgres

improve spelling

  1. … 6 more files in changeset.
improve spelling

  1. … 11 more files in changeset.
Move 'util::content_size_pretty' into 'acs-lang' and rename it to 'lc_content_size_pretty', localicing 'bytes' and adapting automated tests. Bump 'acs-lang' version.

  1. … 38 more files in changeset.