• last updated 9 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Make service contract implementations private, test them

Document public api, add library header

Increase coverage

Increase coverage

Make category::page_url private: it is meant to be used via the service contracts and not directly

Increase proc coverage

Pass the name down to the db_multirow api, just setting the multirow name is not sufficient to "rename" a multirow

Test api to map an object to a category, which exposes a bug in category::get_mapped_categories_multirow

Increase test coverage

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

  1. … 32 more files in changeset.
Add page contract, update dependencies

Add include contract

Add include contract

  1. … 1 more file in changeset.
whitespace changes

reduce verbosity

fix release dates in .info files

  1. … 82 more files in changeset.
release work

  1. … 204 more files in changeset.
change_locale is actually a property of this master that is supplied by the slaves, not a part of the page contract

Add page contract

regenerated documentation

  1. … 464 more files in changeset.
bump version numbers of 5.9|5.10 packages to 5.10.0b1

adjust dependencies

  1. … 87 more files in changeset.
improve spelling

  1. … 42 more files in changeset.
Extend 'category_tree_procs' test case with 'category::relation::add_meta_category' and 'category::relation::get_meta_categories'

Extend 'category_tree_procs' test case with 'category::change_parent'

Extend 'category_tree_procs' test case with 'category::count_children'

Final phasing out of acs_named_objects

- remove table creation

- update documentation

- provide an optional upgrade script to delete the table and the object type (commented out by default, as people might have defined object subtypes downstream).

Context: this table and the related machinery were created at a time where acs_objects where not as mature as they are now and would not include the "title" information. To retrieve the object name, the only option was the stored procedure acs_object.name, which was not scalable.

From an excerpt of the Changelog file:


2004-03-31 jeffd


* packages/categories/tcl/category-trees-procs-oracle.xql:

* packages/categories/tcl/category-trees-procs-postgresql.xql:

acs_named_objects superflous now that title is in

acs_objects. need to fix the rest of the occurances though


This tells us that the phasing out has already been decided back in 2004, but delayed. One technical reason, could be that the acs_named_objects table would also materialize the translation, while the title column would store sometimes a message key, that would need to be translated manually. This is helpful when e.g. sorting by name in sql. However, only the faq and categories package would seem to make any use of the table and only the faq package would seem to maintain its values... This would make some UIs in the categories package practically useless since a long time.

    • -0
    • +12
    • -37
    • +0
file upgrade-1.1.5d3-1.1.5d4.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    • -0
    • +0
Cleanup var, break overlong line

Rework of category UI:

- phase out usage of acs_named_objects, use object title instead

- rework pagination using builtin template::list features

- reduce hardcoded styling and markup

- rework strange database idioms

- remove divergency between oracle and postgres codebase

    • -24
    • +0
Formatting change