• last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Accomodate the test for downstream, where the notification object depends on whether the calendar is private or not

Localize the notification mode as we do downstream, fix test so that the notification generated internally by calendar::item::new is detected, rather than a dummy one

  1. … 4 more files in changeset.
Detect when permission caching is enabled and flush the permission cache in this case

Formatting changes, use more appropriate operator

Fix typo, formatting changes

Increae proc coverage

Increase proc coverage

Deprecate calendar::make_datetime less useful than it used to be

Increase proc coverage

Deprecate calendar::from_sql_datetime, not used upstream and superseded by modern HTML5 features and clock idioms

Increase proc coverage

Increase proc coverage

Increase proc coverage

Increase proc coverage

Deprecate calendar::adjust_date, implementing a trivial default logic

  1. … 2 more files in changeset.
Fix typo

Modernize idiom

Improve doc

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

  1. … 33 more files in changeset.
Trap the case where invalid dates are supplied to the proc

Deprecate oacs_util::vars_to_ns_set: modern ns_set idioms make this proc obsolete

  1. … 7 more files in changeset.
make template::adp_puts private again. removed some of the weirdness in calendar attachments

  1. … 3 more files in changeset.
mark private functions as private

  1. … 9 more files in changeset.
reduce verbosity, add covered calls in test cases

Fix extra braces

Add 'calendar_basic_api' test case, covering 'calendar::new', 'calendar::delete', 'calendar::rename' and 'calendar::name'

Port of downstream feature: cleanup properly everything related with a calendar package instance before deleting (e.g. calendar item types)

This might be superseded by just plain referential integrity, taking care also of the oracle part, in a future moment

  1. … 1 more file in changeset.
Reform 'all_day_event' private interface:

now we consider all day events only those where the time component of both start and end date is set at midnight. This is more restrictive that the previous criteria, which would allow also events where start and end date were equals, or the date component was different, regardless of time, to be considered all day events.

In practice, the user interface would already make so that an event created as "all day event" would be set with midnight as the time for start and end date.

calendar::item::get would already return time_p in the array to indicate whether this was an event with time or not. No time would mean "all day event". For convenience, we now return also the straight all_day_event_p flag in the array.

Remove blind catch, this proc is actually robust to bogus values

added editor hints and white-space cleanup

    • -16
    • +17
    ./calendar-compatibility-procs.tcl
  1. … 23 more files in changeset.