• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
make template::adp_puts private again. removed some of the weirdness in calendar attachments

  1. … 3 more files in changeset.
mark private functions as private

  1. … 9 more files in changeset.
reduce verbosity, add covered calls in test cases

Fix extra braces

Add 'calendar_basic_api' test case, covering 'calendar::new', 'calendar::delete', 'calendar::rename' and 'calendar::name'

Port of downstream feature: cleanup properly everything related with a calendar package instance before deleting (e.g. calendar item types)

This might be superseded by just plain referential integrity, taking care also of the oracle part, in a future moment

  1. … 1 more file in changeset.
Reform 'all_day_event' private interface:

now we consider all day events only those where the time component of both start and end date is set at midnight. This is more restrictive that the previous criteria, which would allow also events where start and end date were equals, or the date component was different, regardless of time, to be considered all day events.

In practice, the user interface would already make so that an event created as "all day event" would be set with midnight as the time for start and end date.

calendar::item::get would already return time_p in the array to indicate whether this was an event with time or not. No time would mean "all day event". For convenience, we now return also the straight all_day_event_p flag in the array.

Remove blind catch, this proc is actually robust to bogus values

added editor hints and white-space cleanup

    • -16
    • +17
    ./calendar-compatibility-procs.tcl
  1. … 23 more files in changeset.
improve comments

Introduce a new callback hook for calendar item edit

Whitespace changes

improve spelling

  1. … 9 more files in changeset.
Reduce divergency between oracle and postgres codebase

Replace ad_decode idiom and unnest expr

Fix typo in doc

Add a callback hook to put logic before calendar item deletion

    • -0
    • +15
    ./calendar-callback-hooks-procs.tcl
make tested API calls explicit

  1. … 5 more files in changeset.
prefer "aa_equals" over "aa_true"+"string equal"

  1. … 5 more files in changeset.
Fix typos

  1. … 6 more files in changeset.
Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @cvs_id -> @cvs-id

- @version -> @cvs-id

- @creation_date -> @creation-date

- @date -> @creation-date

- Different variations of $Id$

- Remove wrong @param entry

- Fix typos

  1. … 368 more files in changeset.
Use @return in the proc documentation

  1. … 2 more files in changeset.
Provide a minimal documentation to public procs

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
calendar reform (part 2):

- make "forgotten" fields "related_link_url", "related_link_text",

"redirect_to_rel_link_p" of acs-events usable from the calendar.

- add web interface for "location" field as well

- bump version to 2.10.0d4

  1. … 10 more files in changeset.
make spelliing more uniform

Prefer '{}' to '[list]' when creating empty lists

  1. … 204 more files in changeset.
Fix typo + Whitespace

Rework variable assignment (set -> lassign)

  1. … 12 more files in changeset.
whitespace cleanup

  1. … 2 more files in changeset.