OpenACS / openacs-4 / packages / acs-tcl / tcl

text-html-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 28 Dec 24
Commits this week: 0
Total Lines of Code (LoC): 3,222
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 18 Jul 2024
12:05 pm

gustafn

Fixed regression test and make more use of "aa_test_start" and "aa_test_end"

This change reduces the errors in the log file a lets run the

regression test (on my site) without reported errors as reported by

acs_kernel__server_startup_ok.

Options
    • -5
    • +9
    ./text-html-procs.tcl
  2. … 3 more files in changeset.
Wednesday 17 Jul 2024
2:53 pm

antoniop

Complete the URL earlier, so that protocol-relative URLs can be correctly determined as external or not

Options
    • -7
    • +11
    ./text-html-procs.tcl
2:29 pm

antoniop

Rework URL validation in ad_dom_sanitize_html

We now prefer higher level api to determine:

- if a URL is external

- what protocol should be assumed for a URL when this is relative or protocol-relative

Options
    • -81
    • +38
    ./text-html-procs.tcl
Tuesday 16 Jul 2024
3:31 pm

gustafn

made test for valid protocols case invariant

Options
    • -7
    • +13
    ./text-html-procs.tcl
Wednesday 10 Jul 2024
3:57 pm

antoniop

In the end we do phase out the util_expand_entities* procs for being too lame

Good riddance

Options
    • -7
    • +10
    ./text-html-procs.tcl
  2. … 1 more file in changeset.
Monday 08 Jul 2024
5:17 pm

antoniop

Reimplement util_expand_entities_ie_style

This proc turned out to be long broken. We could consider phasing it out, but as it is a public interface used in a few places we prefer to keep it around and try to fix it.

The intended behavior has been reconstructed from the documentation. The new approach uses a single regexp to extract entities, which does not risk to loop indefinitely as before.

Options
    • -44
    • +29
    ./text-html-procs.tcl
4:07 am

gustafn

fixed broken indentation and broken nesting

Options
    • -1149
    • +1148
    ./text-html-procs.tcl
Sunday 07 Jul 2024
12:16 pm

gustafn

fix incorrect nesting in switch statements

Options
    • -36
    • +36
    ./text-html-procs.tcl
Friday 31 May 2024
2:00 pm

gustafn

improved spelling

Options
    • -2
    • +2
    ./text-html-procs.tcl
  2. … 5 more files in changeset.
Tuesday 19 Mar 2024
11:47 am

antoniop

Untangle if logics

Options
    • -23
    • +30
    ./text-html-procs.tcl
11:46 am

antoniop

Reject URLs displaying multiple protocols

Options
    • -1
    • +27
    ./text-html-procs.tcl
Monday 18 Mar 2024
2:13 pm

antoniop

Strenghten validation against smarter attempts to disguise the javascript: protocol

Options
    • -10
    • +17
    ./text-html-procs.tcl
Friday 16 Feb 2024
12:38 pm

antoniop

Manually replace the ":" entity to prevent attempts at disguising "javascript:" links

Options
    • -1
    • +17
    ./text-html-procs.tcl
Monday 20 Nov 2023
4:04 pm

antoniop

When using ad_dom_sanitize_html to validate markup, treat failure to parse as a normal validation failure, rather than an error

Options
    • -3
    • +4
    ./text-html-procs.tcl
Thursday 06 Jul 2023
10:54 am

gustafn

reduce verbosity

Options
    • -4
    • +4
    ./text-html-procs.tcl
Thursday 23 Mar 2023
4:13 pm

antoniop

Use a better regexp to reimplement ad_looks_like_html_p, use the improved api to port downstream feature: an ad_form datatype validator that won't allow to insert markup

Many thanks to Günter Ernst

Options
    • -6
    • +2
    ./text-html-procs.tcl
  2. … 1 more file in changeset.
Tuesday 07 Feb 2023
1:46 pm

antoniop

Deprecate trivial wrappers for ad_html_text_convert

Options
    • -3
    • +11
    ./text-html-procs.tcl
  2. … 2 more files in changeset.
Thursday 22 Dec 2022
3:39 am

gustafn

improve robustness

Options
    • -3
    • +3
    ./text-html-procs.tcl
  2. … 1 more file in changeset.
Sunday 04 Dec 2022
12:36 pm

gustafn

make parsing more robust

Options
    • -2
    • +2
    ./text-html-procs.tcl
Friday 21 Oct 2022
1:30 pm

trenner

fix typo

Options
    • -2
    • +2
    ./text-html-procs.tcl
Thursday 29 Sep 2022
6:04 pm

gustafn

reduce verbosity

Options
    • -6
    • +6
    ./text-html-procs.tcl
  2. … 2 more files in changeset.
Monday 05 Sep 2022
5:07 pm

antoniop

Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

Options
    • -2
    • +2
    ./text-html-procs.tcl
  2. … 6 more files in changeset.
Thursday 01 Sep 2022
9:21 am

trenner

if truncate_len is provided we have to call util_close_html_tags for truncating the string

Options
    • -2
    • +2
    ./text-html-procs.tcl
Tuesday 30 Aug 2022
4:48 pm

antoniop

Rename proc according to convention enforced in acs-tcl: naming__proc_naming

Options
    • -5
    • +4
    ./text-html-procs.tcl
10:47 am

gustafn

comment tags, which are NOT supported by HTML5, allow "abbr" in enhanced text

Options
    • -3
    • +13
    ./text-html-procs.tcl
Monday 29 Aug 2022
5:15 pm

gustafn

Reduce verbosity

Options
    • -8
    • +2
    ./text-html-procs.tcl
3:35 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./text-html-procs.tcl
3:02 pm

gustafn

implemented ad_html_security_check based on ns_parsehtml

Options
    • -44
    • +144
    ./text-html-procs.tcl
1:53 pm

gustafn

Use "ns_parsehtml" for speed and correctness when available

The new NaviServer built-in command "ns_parsehtml" is used on

several occasions in the code when available, namely in

- util_close_html_tags

- escaping disallowed HTML tags in ad_text_to_html

- util_close_html_tags

The command "util_close_html_tags" has a long history of troubles,

since it was implemented originally based on regular expressions. It

was reported in Jan 2009, that the function took on certain forums

entries 6 to 9 hours (e.g. /forums/message-view?message_id=357753) to

finish. Therefore, at this time a quick version based on tdom was

introduced, which reduced at that time the performance to 7.3

seconds. However, the tdom-based version tend to fail on invalid HTML,

so it could cover only a few cases. The new "ns_parsehtml" is more

robust and works very stable on openacs.org with the know problem

cases. Furthermore, this version is also significantly faster than the

tdom version.

Options
    • -33
    • +269
    ./text-html-procs.tcl
  2. … 1 more file in changeset.
Friday 26 Aug 2022
3:00 pm

antoniop

Deprecate ad_parameter_all_values_as_list: it does not provide much value and was also often use improperly

Options
    • -30
    • +9
    ./text-html-procs.tcl
  2. … 4 more files in changeset.