• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improve spelling

  1. … 6 more files in changeset.
Move 'util::content_size_pretty' into 'acs-lang' and rename it to 'lc_content_size_pretty', localicing 'bytes' and adapting automated tests. Bump 'acs-lang' version.

  1. … 41 more files in changeset.
Trailing whitespace cleanup

Prettify data size using 'util::content_size_pretty'

whitespace changes

  1. … 50 more files in changeset.
Replace ad_decode idioms

  1. … 1 more file in changeset.
Use more API when retrieving user info and portrait, streamline queries, put all sql inline

Prefer API over handcrafted queries

remove conditions, which are always true

  1. … 7 more files in changeset.
Portrait management reform and correction

Moved logics to create a portrait in a proc in order to reuse it in other places

such as picture retrieval services (e.g. Bach picture retrieval at WU). Turns out

we were not doing our homeworks here: when the portrait is created into CR, a

cr_child_rel is created. When the portrait was erased though, this was not cleaned

up propely, leaving dangling acs_objects with no reference in cr_child_rels table.

On busy sites, this can grow in the ten thousands order of magnitude. Changes include

also fix for this behavior and tuples cleanup.

  1. … 12 more files in changeset.
fix ad_form definition (moved redirect in after_submit block, ad_return_template at the end of template outside the ad_form) (thanks to Felix Moedritscher)

Use consistently ad_script_abort after ad_return_error.

Break long lines

  1. … 21 more files in changeset.
add ad_script_abort after ad_returnredirect to make termination intent explicit

  1. … 48 more files in changeset.
make sure to call ad_script_abort after ad_returnredirect

  1. … 15 more files in changeset.
make sure to call ad_script_abort after ad_returnredirect

  1. … 2 more files in changeset.
Bug fix: avoid confusion between command argument and option, when argument starts with "-"

  1. … 80 more files in changeset.
Small improvement for portrait management (deletion)

Exploit existing on delete cascade constraints when we delete a portrait, instead of deleting stuff manually.

Also, put remaining logics into a proc and use it in acs_user::delete to address legit use case of people wanting

to remove a user permanently without removing portrait in advance.

  1. … 1 more file in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7824 more files in changeset.
Reflow content

- make boolean tests in .adp files more uniform

  1. … 55 more files in changeset.
- prefer "localurl" over "return_url" of name of page filter

  1. … 83 more files in changeset.
- improve checking of return_urls in page_contracts

  1. … 80 more files in changeset.
- fix quoting in SQL

- make code more robust

- write sql statements between curly braces

  1. … 14 more files in changeset.
.xql-file reform of acs-subsite:

- remove obsolete queries

email_image::new_item.new_lob_size

email_image::new_item.new_lob_size

group::member_p.group_id_from_name

subsite::default::create_app_group.group_exists

package_mounted_p

- add missing Oracle queries

acs-subsite/tcl/rel-types-procs-oracle.xql

rel_types::additional_rel_types_group_p.group_rel_type_exists

rel_types::additional_rel_types_group_type_p.group_rel_type_exists

www/admin/group-types/new-oracle.xql

select_group_supertypes

- add missing PostgreSQL queries

acs-subsite/tcl/rel-types-procs-postgresql.xql.xql

rel_types::additional_rel_types_group_p.group_rel_type_exists

- remove obsolete files

www/admin/index-oracle.xql

www/admin/index-postgresql.xql

www/admin/index.xql

www/admin/rel-types/roles/new-oracle.xql

www/admin/rel-types/roles/new-postgresql.xql

www/permissions/one.xql

www/pvt/unsubscribe-2-oracle.xql

www/pvt/unsubscribe-2-postgresql.xql

www/pvt/unsubscribe-oracle.xql

www/pvt/unsubscribe-postgresql.xql

www/pvt/unsubscribe.xql

www/register/user-new.xql

www/shared/portrait-bits-oracle.xql

www/shared/portrait-bits-postgresql.xql

www/shared/portrait-bits.xql

  1. … 26 more files in changeset.
- fix old security hole, that allowed to download arbitrary files given a known item_id

  1. … 5 more files in changeset.
- pass values via reference

  1. … 1 more file in changeset.
- add editor hints to keep spaces/tabs in the furture more consistent

  1. … 747 more files in changeset.
- standardize argument passing to adp-includes, don't perform double i18n and double quoting

  1. … 124 more files in changeset.
- fix and standardize quoting in template properties

  1. … 389 more files in changeset.