• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
harden page contracts

  1. … 24 more files in changeset.
change datatype to file to ensure template::data::validate::file is executed

Reuse computation

Avoid catch where a more appropriate idiom exists

Improve documentation

Cleanup case

Whitespace cleanup

Harden page contract

Harden page contract

Make script more robust to agents that won't specify the tmpfile via using the api to retrieve the file information

Whitespace cleanup

improve spelling

  1. … 6 more files in changeset.
Move 'util::content_size_pretty' into 'acs-lang' and rename it to 'lc_content_size_pretty', localicing 'bytes' and adapting automated tests. Bump 'acs-lang' version.

  1. … 41 more files in changeset.
Trailing whitespace cleanup

Prettify data size using 'util::content_size_pretty'

whitespace changes

  1. … 50 more files in changeset.
Replace ad_decode idioms

  1. … 1 more file in changeset.
Use more API when retrieving user info and portrait, streamline queries, put all sql inline

Prefer API over handcrafted queries

remove conditions, which are always true

  1. … 7 more files in changeset.
Portrait management reform and correction

Moved logics to create a portrait in a proc in order to reuse it in other places

such as picture retrieval services (e.g. Bach picture retrieval at WU). Turns out

we were not doing our homeworks here: when the portrait is created into CR, a

cr_child_rel is created. When the portrait was erased though, this was not cleaned

up propely, leaving dangling acs_objects with no reference in cr_child_rels table.

On busy sites, this can grow in the ten thousands order of magnitude. Changes include

also fix for this behavior and tuples cleanup.

  1. … 12 more files in changeset.
fix ad_form definition (moved redirect in after_submit block, ad_return_template at the end of template outside the ad_form) (thanks to Felix Moedritscher)

Use consistently ad_script_abort after ad_return_error.

Break long lines

  1. … 21 more files in changeset.
add ad_script_abort after ad_returnredirect to make termination intent explicit

  1. … 48 more files in changeset.
make sure to call ad_script_abort after ad_returnredirect

  1. … 15 more files in changeset.
make sure to call ad_script_abort after ad_returnredirect

  1. … 2 more files in changeset.
Bug fix: avoid confusion between command argument and option, when argument starts with "-"

  1. … 80 more files in changeset.
Small improvement for portrait management (deletion)

Exploit existing on delete cascade constraints when we delete a portrait, instead of deleting stuff manually.

Also, put remaining logics into a proc and use it in acs_user::delete to address legit use case of people wanting

to remove a user permanently without removing portrait in advance.

  1. … 1 more file in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7824 more files in changeset.
Reflow content