• last updated 55 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 3 more files in changeset.
Make api deprecated, complies with acs-api-browser.graph__bad_calls automated test

    • -2
    • +2
    ./tcl/acs-mail-lite-callback-procs.tcl
mark functions called only internally as private

  1. … 12 more files in changeset.
improve listing of test coverage

  1. … 8 more files in changeset.
Add default to avoid empty values. Fixes 'acs_mail_lite_inbound_procs_check' test case

make listing of tested procs more complete

  1. … 6 more files in changeset.
Handle to_addr specified as "DisplayName <email>": keep the display name in the header value and strip it in the RCPT TO

make end of options explicit

  1. … 41 more files in changeset.
improve spelling (follow LDP)

  1. … 15 more files in changeset.
Fix typos

Fix priority check in 'acs_mail_lite_inbound_procs_check' test case

warn about unexpected entries (typos) in EmailDeliveryMode

Index acs_mail_lite_queue(package_id)

    • -1
    • +3
    ./sql/postgresql/acs-mail-lite-create.sql
file upgrade-5.10.0d11-5.10.0d12.sql was initially added on branch oacs-5-10.

Add a second period to new lines starting with one ('dot-stuffing'), as defined by RFC 5321 section 4.5.2, before sending mail via nssmptd.

According to the RFC:

- "Before sending a line of mail text, the SMTP client checks the

first character of the line. If it is a period, one additional period is inserted at

the beginning of the line."

- "When a line of mail text is received by the SMTP server, it checks the line. If the

line is composed of a single period, it is treated as the end of mail indicator. If

the first character is a period and there are other characters on the line, the first

character is deleted."

This change adds the second period at the beginning of a line suggested in the first

paragraph, preventing nssmptd from deleting dots by acting as mentioned in the second one.

In the case of lines comprised of just a single period, '::mime::qp_encode' already takes

care of them by converting the '.' into '=2E', so they are not affected by this.

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

  1. … 57 more files in changeset.
make packages in principle installable under PG 13+

    • -2
    • +2
    ./sql/postgresql/acs-mail-lite-create.sql
  1. … 19 more files in changeset.
Use only 100 objects for the test, as in large instances this can take several minutes

Improve sql portability

Replace limit (pg only) with fetch idiom, which should be portable on "modern" Oracle

Fix typo in description

Drop duplicate index 'acs_mail_lite_from_external_aml_email_id_idx'. Postgres creates automatically indexes for unique constraints and primary keys, this index duplicates 'acs_mail_lite_from_external_pkey'

    • -3
    • +1
    ./sql/postgresql/acs-mail-lite-create.sql
    • -2
    • +1
    ./sql/postgresql/acs-mail-lite-drop.sql
file upgrade-5.10.0d10-5.10.0d11.sql was initially added on branch oacs-5-10.

Whitespace changes

    • -64
    • +64
    ./sql/postgresql/acs-mail-lite-create.sql
    • -6
    • +3
    ./sql/postgresql/acs-mail-lite-drop.sql
Drop duplicate index 'acs_mail_lite_send_msg_id_map_msg_id_idx'. Postgres creates automatically indexes for unique constraints and primary keys, this index duplicates 'acs_mail_lite_send_msg_id_map_pkey'

    • -4
    • +1
    ./sql/postgresql/acs-mail-lite-create.sql
    • -2
    • +1
    ./sql/postgresql/acs-mail-lite-drop.sql
file upgrade-5.10.0d9-5.10.0d10.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.0d9-5.10.0d10.sql
mprove spelling: move closer to the linux documentation recommendations

    • -2
    • +2
    ./tcl/acs-mail-lite-callback-procs.tcl
    • -4
    • +4
    ./www/doc/incoming-email-legacy-notes.adp
  1. … 17 more files in changeset.
improve wording for package parameters

add EmailDeliveryMode 'ignore'. Similar to 'log' but less verbose.

use 'ignore' in case 'redirect' is set wihout a value for EmailRedirectTo