OpenACS / openacs-4 / packages

acs-lang

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 41
Last Commit: 08 May
Commits this week: 0
Total Lines of Code (LoC): 19,392
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 15 Feb 2022
5:50 pm

gustafn

Fixes for Oracle 19c boolean types in query

This fixes the following bug for Oracle:

: SQL:

: select locale

: from ad_locales l

: where language = :language

: and enabled_p

: !>>>!and (default_p or not exists (select 1 from ad_locales

: where language = :language

: and locale <> l.locale))

:

Options
    • -5
    • +6
    ./tcl/lang-util-procs.tcl
Saturday 12 Feb 2022
9:11 pm

gustafn

improving Oracle upgrade scripts

Oracle has no "ALTER TABLE ADD COLUMN ...."

Oracle has no "ALTER TABLE ADD COLUMN if exists .."

Options
    • -3
    • +17
    ./sql/oracle/upgrade/upgrade-5.10.0d11-5.10.0d12.sql
  2. … 8 more files in changeset.
Thursday 10 Feb 2022
10:33 pm

gustafn

fixes for Oracle 19c

Options
    • -7
    • +8
    ./sql/oracle/message-catalog.sql
  2. … 5 more files in changeset.
Tuesday 01 Feb 2022
2:23 pm

antoniop

Reduce need for xql

Options
    • -6
    • +4
    ./tcl/lang-message-procs.tcl
    • -12
    • +0
    ./tcl/lang-message-procs.xql
2:17 pm

antoniop

Cleanup hacks addressing #2011927 bug in Oracle: this has been supposedly addressed in version 9i, already EOL

See http://oracle-docs.dartmouth.edu/dba-docs/patchset_9.2.0.4.htm

Options
    • -19
    • +5
    ./tcl/lang-message-procs.tcl
    • -16
    • +0
    ./tcl/lang-message-procs.xql
Monday 31 Jan 2022
5:33 pm

antoniop

Fix acs-lang.test_message_register automated test:

when checking if a message should be created or updated, do not trust the nsv, which won't be there for messages that have been soft-deleted and go to the db instead. When a message is soft deleted, cleanup the nsv cache.

Options
    • -4
    • +14
    ./tcl/lang-message-procs.tcl
5:25 pm

antoniop

Expose a bug in the message key registration:

when a message key is soft-deleted and the server is restarted, upon re-registration the nsv that signals its presence won't be found and an insertion will be attempted. However, as the db entry is there, a primary key constraint will be triggered.

Options
    • -1
    • +35
    ./tcl/test/acs-lang-message-procs.tcl
Tuesday 14 Dec 2021
11:04 am

antoniop

Stick to packages that are enabled

Options
    • -4
    • +6
    ./tcl/test/acs-lang-test-procs.tcl
  2. … 1 more file in changeset.
10:51 am

antoniop

Use the intended table to get packages that are known to the system

Options
    • -1
    • +1
    ./tcl/test/acs-lang-test-procs.tcl
  2. … 1 more file in changeset.
Monday 13 Dec 2021
2:35 pm

antoniop

Add comment

Options
    • -0
    • +3
    ./tcl/test/acs-lang-test-procs.tcl
2:26 pm

antoniop

Make api to retrieve the dependencies of a package public, as we use it in a test in another package, swith to the api that will retrieve the cached value instead of re-computing the result

Options
    • -1
    • +1
    ./tcl/test/acs-lang-test-procs.tcl
  2. … 1 more file in changeset.
Friday 10 Dec 2021
4:03 pm

antoniop

New test to check that message keys are used consistently with package dependencies

this can only be enforced as a warning because it is possible to have constructs such as "if installed, then use message key" that would be tricky to detect

Options
    • -0
    • +84
    ./tcl/test/acs-lang-test-procs.tcl
Friday 26 Nov 2021
2:10 pm

antoniop

Reuse computation of lang::conn::locale when invoked again in the same request

This reduces stress on the util_memoize cache for those installation that invoke this api often.

Options
    • -4
    • +26
    ./tcl/locale-procs.tcl
Monday 04 Oct 2021
12:12 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -19
    • +0
    ./tcl/lang-util-procs-oracle.xql
    • -18
    • +0
    ./tcl/lang-util-procs-postgresql.xql
    • -2
    • +8
    ./tcl/lang-util-procs.tcl
    • -36
    • +0
    ./www/admin/batch-editor-oracle.xql
    • -29
    • +0
    ./www/admin/batch-editor-postgresql.xql
    • -1
    • +20
    ./www/admin/batch-editor.tcl
  7. … 3 more files in changeset.
Thursday 16 Sep 2021
10:27 am

gustafn

fix release dates in .info files

Options
    • -1
    • +1
    ./acs-lang.info
  2. … 82 more files in changeset.
Wednesday 15 Sep 2021
6:11 pm

gustafn

release work

Options
    • -6
    • +6
    ./acs-lang.info
    • -0
    • +0
    ./www/doc/i18n-requirements.adp
  3. … 203 more files in changeset.
Tuesday 07 Sep 2021
11:39 am

gustafn

regenerated documentation, including change log

Options
    • -0
    • +0
    ./www/doc/i18n-requirements.adp
  2. … 117 more files in changeset.
Friday 03 Sep 2021
11:14 am

gustafn

regenerated documentation

Options
    • -3
    • +3
    ./www/doc/i18n-design.adp
    • -3
    • +4
    ./www/doc/i18n-requirements.adp
    • -1
    • +1
    ./www/doc/index.adp
  4. … 466 more files in changeset.
Thursday 02 Sep 2021
7:22 pm

gustafn

bump version numbers of 5.9|5.10 packages to 5.10.0b1

adjust dependencies

Options
    • -6
    • +6
    ./acs-lang.info
  2. … 87 more files in changeset.
Tuesday 31 Aug 2021
1:49 pm

antoniop

Fix overquoting resulting in batch message key editor

This was caused by the now stricter quoting applied to ad_form, which is used under the hood to produce this UI

Options
    • -1
    • +2
    ./www/admin/batch-editor.tcl
Tuesday 03 Aug 2021
1:40 pm

gustafn

make sure that the query variable "show" is only passed non-empty, otherwise the page-contract of admin/message-list.tcl will fail

Options
    • -9
    • +9
    ./www/admin/edit-localized-message.tcl
Wednesday 31 Mar 2021
1:49 pm

gustafn

list called api procs

Options
    • -0
    • +3
    ./tcl/test/acs-lang-test-procs.tcl
Tuesday 30 Mar 2021
5:52 pm

hectorr

Mark 'lang::message::cache' as public, as it is used in 'acs-admin'

Options
    • -2
    • +2
    ./tcl/lang-message-procs.tcl
5:49 pm

hectorr

Mark 'lang::catalog::package_catalog_dir' as public, as it is used in 'acs-admin'

Options
    • -2
    • +2
    ./tcl/lang-catalog-procs.tcl
5:48 pm

hectorr

Mark 'lang::util::get_hash_indices' as public, as it is used in 'acs-admin'

Options
    • -2
    • +2
    ./tcl/lang-util-procs.tcl
Friday 26 Mar 2021
4:56 pm

hectorr

Remove ancient tests for 'acs-lang', which use obsolete API and don't work for the most part anymore

Options
    • -71
    • +0
    ./www/admin/test/catalog-test.adp
    • -38
    • +0
    ./www/admin/test/catalog-test.tcl
    • -28
    • +0
    ./www/admin/test/compile.tcl
    • -38
    • +0
    ./www/admin/test/format-test.adp
    • -29
    • +0
    ./www/admin/test/format-test.tcl
    • -10
    • +0
    ./www/admin/test/format-test.xql
    • -22
    • +0
    ./www/admin/test/index.html
    • -28
    • +0
    ./www/admin/test/show.tcl
    • -91
    • +0
    ./www/admin/test/test.adp
    • -79
    • +0
    ./www/admin/test/test.tcl
    • -10
    • +0
    ./www/admin/test/test.xql
    • -26
    • +0
    ./www/admin/test/translator-mode.adp
    • -43
    • +0
    ./www/admin/test/translator-mode.tcl
    • -40
    • +0
    ./www/admin/test/tz-test.tcl
Saturday 27 Feb 2021
9:19 pm

gustafn

complete listing of covered procs in test cases

Options
    • -0
    • +2
    ./tcl/test/acs-lang-test-procs.tcl
  2. … 14 more files in changeset.
Monday 22 Feb 2021
4:51 pm

antoniop

Make api public, complies with acs-api-browser.graph__bad_calls automated test

Options
    • -3
    • +3
    ./tcl/lang-message-procs.tcl
  2. … 4 more files in changeset.
Friday 19 Feb 2021
11:11 am

gustafn

remove protection "private", since function has to be called from other packages

Options
    • -2
    • +2
    ./tcl/lang-message-procs.tcl
  2. … 6 more files in changeset.
Thursday 18 Feb 2021
3:28 pm

gustafn

bring test coverage to >50% by adding test cases and marking only locally called functions as private

Options
    • -5
    • +5
    ./tcl/lang-message-procs.tcl
    • -2
    • +2
    ./tcl/localization-procs.tcl
    • -0
    • +29
    ./tcl/test/acs-lang-localization-procs.tcl