OpenACS / openacs-4 / packages

acs-lang

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 2
Total Committers: 40
Last Commit:
Commits this week: 2
Total Lines of Code (LoC): 19,392
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 19 Jan
1:10 pm

gustafn

make comment more precise

Options
    • -2
    • +7
    ./tcl/test/acs-lang-test-procs.tcl
Monday 18 Jan
5:22 pm

antoniop

New test to enforce that catalog files are valid XML

Options
    • -0
    • +17
    ./tcl/test/acs-lang-test-procs.tcl
Wednesday 16 Dec 2020
3:41 pm

antoniop

Define arguments so that documentation__check_parameters automated test does find -varname flag correctly

Options
    • -3
    • +11
    ./tcl/lang-message-procs.tcl
Wednesday 02 Sep 2020
6:48 pm

antoniop

Pass missing object_id flag

Options
    • -2
    • +4
    ./tcl/lang-util-procs.tcl
1:25 pm

antoniop

Do not insert object_ids that do not exist in acs_object (leftover group message keys)

Options
    • -1
    • +2
    ./sql/oracle/upgrade/upgrade-5.10.0d13-5.10.0d14.sql
    • -1
    • +2
    ./sql/postgresql/upgrade/upgrade-5.10.0d13-5.10.0d14.sql
Tuesday 01 Sep 2020
7:24 pm

antoniop

Improve sql portability

Options
    • -22
    • +22
    ./tcl/test/acs-lang-localization-procs.tcl
  2. … 6 more files in changeset.
Friday 28 Aug 2020
2:23 pm

antoniop

Improve test

Options
    • -8
    • +13
    ./tcl/test/acs-lang-localization-procs.tcl
2:17 pm

antoniop

New test for lang::util::convert_to_i18n pinpointing some expected behaviors of this proc

Options
    • -0
    • +67
    ./tcl/test/acs-lang-localization-procs.tcl
Thursday 27 Aug 2020
5:48 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./tcl/lang-message-procs.tcl
2:53 pm

antoniop

acs-lang reform:

when calling lang::util::convert_to_i18n, do not always register a en_US translation, which will be otherwise always overridden. Instead, let lang::message::register make sure that a en_US message exists and create it only when needed as a fallback. Before, lang::message::register would return an error when e.g. a new message keys was registered for de_DE and no en_US was there. Now the en_US will be just created on the fly.

This does not break current automated tests

Options
    • -8
    • +15
    ./tcl/lang-message-procs.tcl
    • -8
    • +3
    ./tcl/lang-util-procs.tcl
Tuesday 25 Aug 2020
6:27 pm

antoniop

Take also care to populate the newly created column with the group ids coming from automatically generated message keys

Options
    • -2
    • +2
    ./acs-lang.info
    • -0
    • +8
    ./sql/oracle/upgrade/upgrade-5.10.0d13-5.10.0d14.sql
    • -0
    • +7
    ./sql/postgresql/upgrade/upgrade-5.10.0d13-5.10.0d14.sql
6:27 pm

antoniop

file upgrade-5.10.0d13-5.10.0d14.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.0d13-5.10.0d14.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.0d13-5.10.0d14.sql
6:19 pm

antoniop

Create index on the new lang_message_keys.object_id column

Options
    • -2
    • +2
    ./acs-lang.info
    • -0
    • +3
    ./sql/oracle/upgrade/upgrade-5.10.0d12-5.10.0d13.sql
    • -0
    • +2
    ./sql/postgresql/upgrade/upgrade-5.10.0d12-5.10.0d13.sql
6:19 pm

antoniop

file upgrade-5.10.0d12-5.10.0d13.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.0d12-5.10.0d13.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.0d12-5.10.0d13.sql
3:38 pm

antoniop

file upgrade-5.10.0d11-5.10.0d12.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.0d11-5.10.0d12.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.0d11-5.10.0d12.sql
3:38 pm

antoniop

acs-lang reform

Provide an optional object_id which can be used to register message keys that will be bound to the lifecycle of an acs-object. When the object is deleted, so will the message key.

This is useful for groups that automatically define a message key for their pretty name. Tcl api was already aware of this and would cleanup such message keys, but other idioms e.g. stored procedures used to delete groups would leave leftovers behind. These can become relatively numerous on group-intensive systems such as LEARN.

Other future usages for this new feature might be the automatic localization of xowiki FormPage properties.

Options
    • -2
    • +2
    ./acs-lang.info
    • -1
    • +9
    ./sql/oracle/message-catalog.sql
    • -0
    • +5
    ./sql/oracle/upgrade/upgrade-5.10.0d11-5.10.0d12.sql
    • -1
    • +9
    ./sql/postgresql/message-catalog.sql
    • -0
    • +4
    ./sql/postgresql/upgrade/upgrade-5.10.0d11-5.10.0d12.sql
    • -2
    • +12
    ./tcl/lang-message-procs.tcl
    • -9
    • +0
    ./tcl/lang-message-procs.xql
    • -2
    • +9
    ./tcl/lang-util-procs.tcl
  9. … 2 more files in changeset.
Friday 07 Aug 2020
12:30 pm

gustafn

improve spelling

Options
    • -1
    • +1
    ./tcl/test/acs-lang-test-procs.tcl
    • -2
    • +2
    ./www/doc/i18n-requirements.adp
    • -2
    • +2
    ./www/doc/i18n-requirements.html
  4. … 2 more files in changeset.
Wednesday 29 Jul 2020
1:27 pm

antoniop

Cleanup broken tests from the old good days, timezone features in acs-lang are already tested in lang_test__lc_procs

Options
    • -2
    • +0
    ./www/admin/test/index.html
    • -59
    • +0
    ./www/admin/test/timezone.adp
    • -75
    • +0
    ./www/admin/test/timezone.tcl
    • -11
    • +0
    ./www/admin/test/timezone.xql
Wednesday 22 Jul 2020
1:49 pm

antoniop

Keep using ad_conn in lang::conn::timezone as set_get_timezone needs to simulate lack of connection and ad_conn allows to override the "real" value

Options
    • -2
    • +2
    ./tcl/locale-procs.tcl
Tuesday 21 Jul 2020
5:17 pm

hectorr

Refactor 'locale_language_fallback' testcase, using 'aa_run_with_teardown' and preventing errors when the 'en_GB' locale is not enabled

Options
    • -20
    • +44
    ./tcl/test/acs-lang-test-procs.tcl
3:58 pm

gustafn

prefer "ns_conn isconnected" over "ad_conn isconnected", since the latter might not notice changes in the connect state

Options
    • -2
    • +2
    ./tcl/lang-message-procs.tcl
    • -2
    • +2
    ./tcl/lang-util-procs.tcl
    • -3
    • +3
    ./tcl/locale-procs.tcl
    • -3
    • +3
    ./tcl/localization-procs.tcl
  5. … 15 more files in changeset.
Friday 03 Jul 2020
9:53 am

gustafn

mprove spelling: move closer to the linux documentation recommendations

Options
    • -2
    • +2
    ./tcl/lang-catalog-procs.tcl
    • -3
    • +3
    ./tcl/localization-procs.tcl
    • -1
    • +1
    ./tcl/test/acs-lang-test-procs.tcl
    • -1
    • +1
    ./www/admin/export-locale-to-files.tcl
    • -1
    • +1
    ./www/admin/import-locale-from-files.tcl
    • -3
    • +3
    ./www/doc/i18n-design.adp
    • -3
    • +3
    ./www/doc/i18n-design.html
    • -8
    • +7
    ./www/doc/i18n-requirements.adp
    • -9
    • +8
    ./www/doc/i18n-requirements.html
  10. … 13 more files in changeset.
Thursday 18 Jun 2020
8:56 am

gustafn

improve error message

Options
    • -2
    • +2
    ./tcl/lang-util-procs.tcl
Wednesday 17 Jun 2020
11:56 am

gustafn

provide a more friendly error message for broken configurations

Options
    • -3
    • +11
    ./tcl/lang-util-procs.tcl
11:55 am

gustafn

avoid repeated lookup for the same locale

Options
    • -4
    • +23
    ./tcl/lang-message-procs.tcl
11:43 am

gustafn

remove quotes from quoted vars

Options
    • -12
    • +12
    ./www/admin/index.tcl
Saturday 06 Jun 2020
6:27 pm

gustafn

- simplifying one more expression

- bump version number to 5.10.0d11

Options
    • -2
    • +2
    ./acs-lang.info
    • -4
    • +5
    ./tcl/lang-message-procs.tcl
2:44 pm

gustafn

reduced the number of mutex locks for message keys lookup by a factor of two by using naviserver commands

Options
    • -33
    • +72
    ./tcl/lang-message-procs.tcl
Monday 18 May 2020
11:20 pm

gustafn

use dot instead of colon as separator between package name and cache key to ease readability

Options
    • -2
    • +2
    ./tcl/lang-util-procs.tcl
    • -3
    • +3
    ./tcl/locale-procs.tcl
    • -2
    • +2
    ./tcl/localization-procs.tcl
  4. … 8 more files in changeset.
11:13 pm

gustafn

acs::per_thread_cache: standardize per-thread caching

- added per-thread cache based on namespaced Tcl variables.

- use per-thread-cache on several occasions

- bump version number of acs-tcl to 5.10.0d34

Options
    • -3
    • +3
    ./acs-lang.info
    • -5
    • +4
    ./tcl/lang-util-procs.tcl
    • -19
    • +9
    ./tcl/locale-procs.tcl
    • -6
    • +4
    ./tcl/localization-procs.tcl
  5. … 11 more files in changeset.