• last updated 17 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Cleanup leftover, fix typos

    • -5
    • +2
    ./tcl/test/acs-lang-localization-procs.tcl
lc_time_tz_convert reform:

- enforce that only dates in the ISO format "%Y-%m-%d %H:%M:%S" are accepted

- apply clock api normalization to seemingly out of range time_values, as per https://www.tcl.tk/man/tcl/TclCmd/clock.html#M25

- return the empty string every time input is invalid or a conversion cannot be determined

- return a value, as ISO date, only when conversion is successful

- prefer the clock api to perform the conversion, but fall back to the ref-timezones datamodel when the timezone is not supported by Tcl

    • -15
    • +0
    ./tcl/localization-procs-oracle.xql
    • -12
    • +0
    ./tcl/localization-procs-postgresql.xql
Introduce a thorough test of the lc_time_tz_convert api checking:

- dates in the distant past

- dates in the distant future

- daylight saving for different times of the year across the two timezones

- historical circumstances (e.g. Pre-timezones US)

- Invalid input

The test shows that the current api does not behave consistently in certain circumstances:

- the same time_value is sometimes returned with invalid input

- the empty string is sometimes returned with valid input

- for dates where the ref-timezones package does not provide information, no result is returned

    • -0
    • +118
    ./tcl/test/acs-lang-localization-procs.tcl
improve spelling

    • -1
    • +1
    ./tcl/test/acs-lang-localization-procs.tcl
  1. … 8 more files in changeset.
improve Oracle compatibility

Improved appearance in TRN mode

- don't set "alt" attribute in classic mode by default to the title.

The title is often be provided as a message key, using it twice

causes two edit controls

- in acs-lang, the extra setting of link_html, which provided

the title attribute can be omitted, since adp:icon renders this

by itself.

  1. … 1 more file in changeset.
improve Oracle compatibility

  1. … 1 more file in changeset.
more beautification of admin pages, make interface more consistent

  1. … 1 more file in changeset.
minor UI improvement

break overlong lines

produce error message in the error log, if the parameter value_array_list is not well formed

Document public api

Document public api

  1. … 1 more file in changeset.
Deprecate export_ns_set_vars and extend export_vars to be able to export also a custom ns_set, which was the real added value provided by this api

  1. … 11 more files in changeset.
Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

  1. … 6 more files in changeset.
Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

  1. … 28 more files in changeset.
Properly escape "<" and ">" in api-doc documentation.

Since all documentation is rendered via HTML, the characters

"<" and ">" have to be HTML-quoted, otherwise strange things

(omission, unintended renderings) might occur.

E.g. the sentence

Define an interface between a page and an

ADP <include> similar to the page_contract.

was rendered as

Define an interface between a page and an

ADP similar to the page_contract.

which is incorrect.

  1. … 13 more files in changeset.
Return 0 when looking up the existance of a message key in an unsupported locale instead of failing, test the behavior

    • -0
    • +56
    ./tcl/test/acs-lang-localization-procs.tcl
Improve test precision: take into account packages defined as <install... in the info file, as e.g. dotlrn does

Fallback here as well to en_US when no supported locale is found

info files do not contain message keys

Reimplement the message-list UI using the template::list

Reimplement package-list UI using the template::list

Reimplement the main admin locale UI using the template::list

use cookie namespace also for stored locales

Make use of uniform styling based on adp:icon

  1. … 14 more files in changeset.
Constrain the language we return for the connection to the ones we support: could happen on system that have supposted a language in the past and still have users set it as their preferred language

Fixes for Oracle 19c: (temporary?) fix for message catalogs

This change fixes the problem that after a fresh installation, all (!)

messages keys are empty. I am not sure what the source of the problem

is, why this has supposedly worked some years before, and whether

there are undesired side-effects of this change. Without this change,

the openacs installation leads to fully broken state.

improved error message

Fixes for Oracle 19c boolean types in query

This fixes the following bug for Oracle:

: SQL:

: select locale

: from ad_locales l

: where language = :language

: and enabled_p

: !>>>!and (default_p or not exists (select 1 from ad_locales

: where language = :language

: and locale <> l.locale))

: