OpenACS / openacs-4 / packages

acs-lang

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 41
Last Commit: 14 Jun
Commits this week: 0
Total Lines of Code (LoC): 19,392
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 24 Mar 2023
4:51 pm

antoniop

Complete coverage for the package

Options
    • -0
    • +60
    ./tcl/test/lang-widget-procs.tcl
4:51 pm

antoniop

file lang-widget-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/lang-widget-procs.tcl
Tuesday 21 Mar 2023
2:44 pm

antoniop

Go ahead and reimplement also lc_time_utc_to_local

Options
    • -16
    • +0
    ./tcl/localization-procs-oracle.xql
    • -14
    • +0
    ./tcl/localization-procs-postgresql.xql
    • -10
    • +7
    ./tcl/localization-procs.tcl
2:34 pm

antoniop

Reimplement lc_time_local_to_utc using lc_time_tz_convert

Options
    • -11
    • +0
    ./tcl/localization-procs-oracle.xql
    • -9
    • +0
    ./tcl/localization-procs-postgresql.xql
    • -10
    • +9
    ./tcl/localization-procs.tcl
2:31 pm

antoniop

Improve test for lc_time_local_to_utc, showing that its behavior is inconsitent with respect to invalid input

Options
    • -0
    • +33
    ./tcl/test/acs-lang-localization-procs.tcl
Friday 10 Feb 2023
4:48 pm

antoniop

Return the system locale as the user locale also when user preferences are there for the user, but the locale is empty

Options
    • -10
    • +10
    ./tcl/locale-procs.tcl
4:34 pm

antoniop

Replace api outside of the package dependencies

Options
    • -1
    • +1
    ./tcl/test/lang-catalog-procs.tcl
1:01 pm

antoniop

Deprecate Oracle-specific collation api

Although it could be interesting to have OpenACS cross-db support for collation, it is unclear if just using different idioms in xql files would not achieve the same.

Options
    • -2
    • +10
    ./tcl/lang-util-procs.tcl
Thursday 09 Feb 2023
3:10 pm

antoniop

Update thead variable them setting the translator mode

Options
    • -1
    • +2
    ./tcl/lang-util-procs.tcl
3:07 pm

antoniop

Increase coverage

This test will currently fail because the translator mode flag is cached per thread, but the set api won't update this cache.

Options
    • -0
    • +25
    ./tcl/test/lang-util-procs.tcl
2:43 pm

antoniop

Increase proc coverage

Options
    • -0
    • +35
    ./tcl/test/lang-util-procs.tcl
2:28 pm

antoniop

Increase proc coverage

Options
    • -1
    • +21
    ./tcl/test/lang-util-procs.tcl
2:14 pm

antoniop

Re-load also all other enabled locales to avoid test side effects

Options
    • -0
    • +6
    ./tcl/test/lang-catalog-procs.tcl
1:43 pm

antoniop

Increase proc coverage

Options
    • -1
    • +23
    ./tcl/test/lang-util-procs.tcl
1:41 pm

antoniop

Wrap test in a transaction

Options
    • -116
    • +118
    ./tcl/test/lang-catalog-procs.tcl
1:20 pm

antoniop

file lang-util-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/lang-util-procs.tcl
1:11 pm

antoniop

Increase proc coverage

Options
    • -0
    • +1
    ./tcl/test/acs-lang-test-procs.tcl
    • -0
    • +51
    ./tcl/test/lang-util-procs.tcl
Wednesday 08 Feb 2023
5:56 pm

antoniop

Improve coverage

Options
    • -0
    • +22
    ./tcl/test/locale-procs.tcl
5:15 pm

antoniop

Increase proc coverage

Options
    • -1
    • +92
    ./tcl/test/locale-procs.tcl
4:25 pm

antoniop

Cleanup private interface lang::system::timezone_support_p: ref-timezones has been made a dependency of acs-lang long ago

Options
    • -33
    • +2
    ./tcl/locale-procs.tcl
    • -83
    • +73
    ./tcl/test/acs-lang-test-procs.tcl
    • -1
    • +1
    ./www/change-locale-include.tcl
    • -3
    • +0
    ./www/admin/index.adp
    • -2
    • +1
    ./www/admin/index.tcl
    • -6
    • +0
    ./www/admin/set-system-timezone.tcl
4:09 pm

antoniop

Allow to specify a user for lang::user::language, default to the package default locale when a locale for user+package is not found

Options
    • -3
    • +4
    ./tcl/locale-procs.tcl
    • -4
    • +10
    ./tcl/locale-procs.xql
4:08 pm

antoniop

Increase proc coverage

This test will fail because of two reasons:

- when using package-level locales and a package default locale is specified, but no user+package locale, the expected behavior should be that the default from the package is used, but this is not the case

- lang::user::language does not allow to specify a user id

Options
    • -0
    • +101
    ./tcl/test/locale-procs.tcl
4:08 pm

antoniop

file locale-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/locale-procs.tcl
2:49 pm

antoniop

Increase proc coverage

Options
    • -5
    • +104
    ./tcl/test/lang-catalog-procs.tcl
1:54 pm

antoniop

Increase proc coverage

Options
    • -0
    • +46
    ./tcl/test/lang-catalog-procs.tcl
1:54 pm

antoniop

file lang-catalog-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/lang-catalog-procs.tcl
1:47 pm

antoniop

Export the catalog via the api to normalize quoting

Options
    • -2
    • +2
    ./acs-lang.info
    • -5
    • +5
    ./catalog/acs-lang.en_US.ISO-8859-1.xml
Thursday 26 Jan 2023
5:30 pm

antoniop

Cleanup leftover, fix typos

Options
    • -5
    • +2
    ./tcl/test/acs-lang-localization-procs.tcl
5:24 pm

antoniop

lc_time_tz_convert reform:

- enforce that only dates in the ISO format "%Y-%m-%d %H:%M:%S" are accepted

- apply clock api normalization to seemingly out of range time_values, as per https://www.tcl.tk/man/tcl/TclCmd/clock.html#M25

- return the empty string every time input is invalid or a conversion cannot be determined

- return a value, as ISO date, only when conversion is successful

- prefer the clock api to perform the conversion, but fall back to the ref-timezones datamodel when the timezone is not supported by Tcl

Options
    • -15
    • +0
    ./tcl/localization-procs-oracle.xql
    • -12
    • +0
    ./tcl/localization-procs-postgresql.xql
    • -11
    • +73
    ./tcl/localization-procs.tcl
5:20 pm

antoniop

Introduce a thorough test of the lc_time_tz_convert api checking:

- dates in the distant past

- dates in the distant future

- daylight saving for different times of the year across the two timezones

- historical circumstances (e.g. Pre-timezones US)

- Invalid input

The test shows that the current api does not behave consistently in certain circumstances:

- the same time_value is sometimes returned with invalid input

- the empty string is sometimes returned with valid input

- for dates where the ref-timezones package does not provide information, no result is returned

Options
    • -0
    • +118
    ./tcl/test/acs-lang-localization-procs.tcl