OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 19
Total Committers: 146
Last Commit: 12:28
Commits this week: 19
Total Lines of Code (LoC): 7,560,946
Net change in LoC this week: 3

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 28 Apr 2023
3:12 pm

trenner

verify provided object_type

Options
    • -1
    • +6
    /openacs-4/packages/xowiki/www/admin/delete-type.tcl
3:11 pm

antoniop

Sign the return_url we set when we generate a zip file to prevent tampering

Options
    • -1
    • +1
    /openacs-4/packages/file-storage/www/download-zip.tcl
    • -5
    • +5
    /openacs-4/packages/file-storage/www/folder-chunk.tcl
Thursday 27 Apr 2023
3:48 pm

antoniop

Reintroduce exec-based approach for unzipping, as zipfile::decode will not handle files > 2GB well

Options
    • -71
    • +94
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
11:42 am

gustafn

provide hint for the potential source of the problem

In error cases, sometimes code is executed, although there is no connection

to the client open. In such cases, this code should probable not executed.

Options
    • -2
    • +2
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
11:17 am

gustafn

fix typo in message key

Options
    • -2
    • +2
    /openacs-4/packages/dotlrn/dotlrn.info
    • -1
    • +1
    /openacs-4/packages/dotlrn/catalog/dotlrn.ar_LB.utf-8.xml
    • -1
    • +1
    /openacs-4/packages/dotlrn/catalog/dotlrn.ca_ES.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/dotlrn/catalog/dotlrn.ch_zh.utf-8.xml
    • -1
    • +1
    /openacs-4/packages/dotlrn/catalog/dotlrn.da_DK.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/dotlrn/catalog/dotlrn.de_DE.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/dotlrn/catalog/dotlrn.en_AU.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/dotlrn/catalog/dotlrn.en_US.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/dotlrn/catalog/dotlrn.es_CO.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/dotlrn/catalog/dotlrn.es_ES.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/dotlrn/catalog/dotlrn.es_GT.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/dotlrn/catalog/dotlrn.fi_FI.utf-8.xml
    • -1
    • +1
    /openacs-4/packages/dotlrn/catalog/dotlrn.fr_FR.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/dotlrn/catalog/dotlrn.gl_ES.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/dotlrn/catalog/dotlrn.hi_IN.utf-8.xml
  16. … 15 more files in changeset.
Wednesday 26 Apr 2023
1:50 pm

antoniop

Re-introduce the exec and document why

Options
    • -7
    • +15
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
Tuesday 25 Apr 2023
4:24 pm

antoniop

Close channel

Options
    • -1
    • +3
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
4:22 pm

antoniop

Provide exec-free implementation of tarball extraction

Options
    • -5
    • +7
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
2:00 pm

antoniop

Deprecate apm_file_type_keys, which can be inlined by a simple dict idiom

Options
    • -4
    • +7
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
    • -2
    • +1
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
    • -2
    • +0
    /openacs-4/packages/acs-tcl/tcl/test/apm-procs.tcl
1:53 pm

antoniop

Avoid dubious catches, collect more logics in the proc

Options
    • -20
    • +9
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
1:45 pm

antoniop

Test apm_workspace directory api

Options
    • -0
    • +54
    /openacs-4/packages/acs-tcl/tcl/test/apm-file-procs.tcl
Monday 24 Apr 2023
6:33 pm

antoniop

Add missing flag -file to the api call

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
6:31 pm

antoniop

Make so that -all also overrides the database type check, which appears to have been the expected behavior: in fact, this api was used to retrieve the files to extract in the tarball generation

Options
    • -10
    • +14
    /openacs-4/packages/acs-bootstrap-installer/tcl/30-apm-load-procs.tcl
6:20 pm

antoniop

Test that "apm_get_package_files -all" should return all files for a package

This currently fails, as "-all" does not override the dbms check, so e.g. on a Postgres installation, all Oracle xql files would be skipped.

Note that the test uses acs-tcl as target because it is a package that is only supposed to contain "package-relevant" files. This is not a rule and is not the case in other packages such as acs-automated-testing, which creates many files during its operations that do not belong to the source tree.

Options
    • -0
    • +30
    /openacs-4/packages/acs-bootstrap-installer/tcl/test/30-apm-load-procs.tcl
5:45 pm

antoniop

Test creating and extracting an APM Package tarball

Options
    • -0
    • +70
    /openacs-4/packages/acs-tcl/tcl/test/apm-file-procs.tcl
5:45 pm

antoniop

file apm-file-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/test/apm-file-procs.tcl
3:53 pm

antoniop

As tcllib was released in 2016, I believe we can cleanup the legacy zip implementation

Options
    • -71
    • +3
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +0
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
Friday 21 Apr 2023
6:28 pm

antoniop

Provide exec-free implementation of util::unzip using zipfile::decode

Options
    • -39
    • +59
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
6:15 pm

antoniop

Extend the test to cover also cornercase behavior concerning overwriting of files

Options
    • -1
    • +38
    /openacs-4/packages/acs-tcl/tcl/test/utilities-procs.tcl
5:34 pm

antoniop

Test zipping and unzipping utilities

Options
    • -0
    • +37
    /openacs-4/packages/acs-tcl/tcl/test/utilities-procs.tcl
2:43 pm

antoniop

Make test less tautological

Options
    • -1
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
2:41 pm

antoniop

Test for psql only when this is expected

Options
    • -12
    • +20
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
2:27 pm

antoniop

Prefer OS-agnostic path separator, add cvs to the exec dependencies

Options
    • -4
    • +4
    /openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl
    • -3
    • +4
    /openacs-4/packages/acs-admin/tcl/test/acs-admin-procs.tcl
1:25 pm

antoniop

Cleanup copy paste error

Options
    • -1
    • +0
    /openacs-4/packages/caldav/tcl/test/caldav-test-procs.tcl
12:42 pm

gustafn

Removed untested and unmaintained code

Options
    • -15
    • +0
    /openacs-4/packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl
    • -17
    • +0
    /openacs-4/packages/acs-automated-testing/www/rebuild-server.tcl
    • -1
    • +8
    /openacs-4/packages/acs-automated-testing/www/doc/usage.adp
    • -1
    • +8
    /openacs-4/packages/acs-automated-testing/www/doc/usage.html
    • -1
    • +6
    /openacs-4/packages/acs-automated-testing/www/doc/xml/using.xml
Thursday 20 Apr 2023
5:49 pm

antoniop

Fallback to the location of the psql executable when a pgbin was not explicitly defined in the config file (which is allowed)

Options
    • -2
    • +15
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
5:36 pm

antoniop

Prefer exec-free variant

Options
    • -3
    • +1
    /openacs-4/packages/assessment/tcl/as-item-procs.tcl
    • -15
    • +1
    /openacs-4/packages/assessment/tcl/test/as-assessment-procs.tcl
5:21 pm

antoniop

Cleanup copy paste

Options
    • -2
    • +0
    /openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl
5:16 pm

antoniop

Test external command dependencies

Options
    • -0
    • +20
    /openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl
    • -0
    • +14
    /openacs-4/packages/xowf/tcl/test/xowf-test-procs.tcl
5:04 pm

antoniop

Test external command dependencies

Options
    • -0
    • +21
    /openacs-4/packages/search/tcl/test/search-procs.tcl
    • -0
    • +15
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl