• last updated 8 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
protect against invalid data

added a test for checking the results of the preview of test-items

Since the preview workflow requires a multiple redirects, xowiki::test::edit_form_page

requires a new flag refetch to actually turn off automatic refetching of the result

page, since this does not give us access to the redirect location returned by

the edit command.

    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
include item_id in result dict of ::xowiki::test::create_form_page

this makes it possible to perform further checks without refetch by name

fixed test case

returned violation on plain instance

added test case for composite test item

New automated test for a page, including another page, which includes a picture, checking that everything works as expected

output warning message, in case form constraints could not be parsed

    • -1
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Differentiate the case of a field being a repeat field or a "normal" coumpound field: in the first case, the whole 'internal' should be converted regardless of the number of components, in the latter, keep the previous behavior

Fixes xowiki create_form_with_numeric after regression in https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Aantoniop%3A20220117174044

    • -4
    • +0
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
fix broken regression test

VS: ----------------------------------------------------------------------

Do not apply the new convert_to_external to repeat fields, stick with the previous behavior

Fixes xowiki create_form_with_form_instance automated test

    • -0
    • +4
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
Added question_ids to "details" in grading info and to the "__results" property

All of test-items is name-based to support input/export from different

OpenACS instances. In some situations, it is still necessary to pinpoint

the origin of questions, e.g. when importing pool-questions to an external

gradebook, where e.g. one wants to associate a replacement questions with

the original pool question.

Now we keep an additional question id, which will point to the pool question

or the simple question together with the question names. The instance

attribute "__results" is set once the exam-protocol was rendered

completely.

__results {

UID1 {

QN1 {achieved 4 achievable 6 question_id 187610}

QN2 {achieved 0.0 achievable 1 question_id 163716}

QN3 (achieved 0.0 achievable 2 question_id 163714}

}

UID2 ...

}

added comments and portlets locations for default ports

xotcl/chache: added button to flush all caches

security::locations: return configured servers from the driver/servers section

additionally, improve caching

improve spelling

validate format of richtext field always

tighten page_contract to mitigate certain attacks

improve readability of generated HTML

added "@see" to deprecated proc

improve warning message

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
get rid of legacy message key "menu-Clipboard-Copy"; "menu-Clipboard-Use-Copy" is used since several years instead

    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
Remove unopened tag

Quote URL in the redirect

Whitespace cleanup

Test ::xowf::Package proc create_new_workflow_page

Mark api as tested

Test content::item::content_is_null public api, which has immediately found a typo

improved prepared-statement handling

- avoid separate SQL statement for testing, whether prepared statement

exists already in the SQL session.

- use true SQL session-id (obtained via "ns_pg pid") when available

- improve source code documentation

added @see tags for deprecated commands