OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 5
Total Committers: 146
Last Commit: 20 Dec
Commits this week: 5
Total Lines of Code (LoC): 7,561,347
Net change in LoC this week: 335

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 09 Jan 2022
6:23 pm

gustafn

Various small improvements:

- Page->content_header_append/content_header_get: new methods to

include HTML content before the form. One use case ist to include

additional forms this way, since these cannot be included in the

main form of a FormPage. The additional content is displayed in the

www-view method.

- FormPage->create_form_fields_from_names: new convenience function to create

form-fields via their names. The definitions of the named form-fields are

taken from the provided form_constraints. This function is useful when

only a subset of the form-constraints definitions should be used

to create form-fields.

- improve comments

- improve argument checking on parent_id to be able to provide better

error messages

- reduce usage of regexp for performance reasons

- improve spelling

Options
    • -5
    • +8
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -10
    • +64
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -7
    • +27
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
Saturday 08 Jan 2022
5:05 pm

gustafn

Improved handling of pages with parent_id == 0 (which come from site-wide pages)

Provide warning, when pretty_link is called on such pages.

Options
    • -4
    • +11
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
5:00 pm

gustafn

Perform a full initialize on both packages to get ::xo::cc initialized

Options
    • -2
    • +5
    /openacs-4/packages/xowiki/tcl/test/xowiki-link-test-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
4:57 pm

gustafn

prefer call of "pretty_link" on package_id to avoid suprises on pages from shared locations

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
4:37 pm

gustafn

Extended LockfreeCache:

- Feneralized flag "-no_empty" of "LockfreeCache eval" to "-no_cache LIST"

The provided list can contain multiple values that should not be cached.

- The new parameter "-from_cache_indicator" can be used to return information

whether the returned value was returned from the cache or not.

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -6
    • +21
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
4:18 pm

gustafn

Provide an exception in case get_instance_from_db is called with an invalid argument combination.

Added convenience methods "::xo::db::CrClass->ensure_item_ids_instantiated"

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/xotcl-core.info
    • -3
    • +21
    /openacs-4/packages/xotcl-core/tcl/cr-procs.tcl
Friday 07 Jan 2022
2:59 pm

antoniop

Add the root folder id to the cache key so that when one does not specify any parent_id, the method still reacts to a package being uninstantiated or the root folder messed around with

Fixes xowiki automated tests when run all together in the same request

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/06-package-procs.tcl
Wednesday 05 Jan 2022
8:17 pm

gustafn

factor out common code

Options
    • -12
    • +3
    /openacs-4/packages/xowiki/tcl/table-widget-procs.tcl
    • -1
    • +20
    /openacs-4/packages/xowiki/tcl/xowiki-utility-procs.tcl
    • -11
    • +4
    /openacs-4/packages/xowiki/www/admin/list.tcl
7:59 pm

gustafn

make listing more compact

Options
    • -4
    • +3
    /openacs-4/packages/xowiki/www/admin/list.tcl
7:00 pm

antoniop

Port reform that replaces publish status display from a png to a character + css style to the xowiki/admin/list

The behavior of the default table widget had to be adapted to reflect that of the bootstrap one: css class from the line is appended to that from the field definition

Options
    • -3
    • +10
    /openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/bootstrap-procs.tcl
    • -12
    • +18
    /openacs-4/packages/xowiki/www/admin/list.tcl
3:16 pm

gustafn

provide as well a minimal compatibility for "-size" parameter on ns_baseunit

Options
    • -2
    • +14
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
    • -13
    • +1
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
3:10 pm

gustafn

use ns_baseunit for time span calculation

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -1
    • +1
    /openacs-4/packages/xotcl-request-monitor/xotcl-request-monitor.info
    • -4
    • +3
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
3:00 pm

gustafn

added a partial backwards compatibility implementation of for ns_baseunit (as used in request processor)

Options
    • -0
    • +28
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
    • -12
    • +7
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
2:10 pm

gustafn

move broken procs based on undefined function to decprecated procs and comment it out

Options
    • -32
    • +1
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
    • -2
    • +50
    /openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl
    • -9
    • +1
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
2:09 pm

gustafn

correct comment

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
Tuesday 04 Jan 2022
9:22 pm

gustafn

use per-request cache for relatively expensive operation, which is called potentially often per request

We might consider in the future a longer lasting cache for "global" form pages.

Options
    • -22
    • +32
    /openacs-4/packages/xotcl-core/tcl/06-package-procs.tcl
8:59 pm

gustafn

use same idom for loading named forms as on other places

Options
    • -4
    • +4
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
8:58 pm

gustafn

improve styling in exam protocol

Options
    • -0
    • +4
    /openacs-4/packages/xowf/www/resources/test-item.css
6:49 pm

gustafn

use "throw" in exception handling with "try"

Options
    • -4
    • +8
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
5:14 pm

antoniop

Fail with the actual error message when parsing the value fails, rather than because of "result" variable not being set

Options
    • -7
    • +5
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
Monday 03 Jan 2022
5:00 pm

gustafn

Added support for user-supplied grading schemes

Grading schemes provide a means to map achieved percentages to a numeric grade.

In the current versions, a fixed number of 5 grades is supported.

A grading scheme consists of a grounding scheme and grading boundaries.

- A grading scheme can be selected at exam definition time

- Lecturers can define their own grading schemes and reuse these between exams

- Available grounding schemes:

* no rounding (recommended for small exams, e.g. 5 minutes or 2 points)

* by percent (the calculated percentages are rounded to the provided number of digits)

* by points (the calculated points are rounded to the provided number of digits)

- The grounding precision can be defined by the user (e.g. to 2 digits)

- The grading boundaries represent percentages boundaries necessary for a certain grade

- When selecting no grading scheme, no grading information is provided in the exam protocol

(just percentages)

More changes:

- allow grading also, when student has not submitted the exam

- added percentage information in the grading-box (esp. useful for composite questions)

- renamed predefined grading schemes to more neutral terms

- provide easy-to-type names for question-manager, answer-manager and form-loader

- new utility for more robust list-comparions

- defined validating form-field type for grading boundaries

Options
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -5
    • +18
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -3
    • +17
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -4
    • +3
    /openacs-4/packages/xowf/catalog/xowf.es_ES.ISO-8859-1.xml
    • -3
    • +3
    /openacs-4/packages/xowf/catalog/xowf.it_IT.ISO-8859-1.xml
    • -0
    • +168
    /openacs-4/packages/xowf/lib/edit-grading-scheme.wf
    • -7
    • +11
    /openacs-4/packages/xowf/lib/inclass-exam-answer.wf
    • -1
    • +1
    /openacs-4/packages/xowf/lib/inclass-exam.wf
    • -0
    • +12
    /openacs-4/packages/xowf/resources/prototypes/edit-grading-scheme.wf.page
    • -2
    • +4
    /openacs-4/packages/xowf/resources/prototypes/select_question.form.page
    • -0
    • +370
    /openacs-4/packages/xowf/tcl/grading-procs.tcl
    • -370
    • +258
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -0
    • +69
    /openacs-4/packages/xowf/tcl/xowf-form-field-procs.tcl
    • -1
    • +25
    /openacs-4/packages/xowf/www/resources/test-item.css
5:00 pm

gustafn

file edit-grading-scheme.wf was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/xowf/lib/edit-grading-scheme.wf
5:00 pm

gustafn

file grading-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/xowf/tcl/grading-procs.tcl
5:00 pm

gustafn

file edit-grading-scheme.wf.page was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/xowf/resources/prototypes/edit-grading-scheme.wf.page
1:58 pm

antoniop

Replace reference to long-missing message key

Options
    • -3
    • +3
    /openacs-4/packages/forums/tcl/messages-procs.tcl
Sunday 02 Jan 2022
8:38 pm

gustafn

reduce verbosity

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
8:32 pm

gustafn

support grading passed in via property

Options
    • -2
    • +3
    /openacs-4/packages/xowf/lib/inclass-exam.wf
7:13 pm

gustafn

still initialize array

Options
    • -1
    • +6
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
7:07 pm

gustafn

improve comment.

Options
    • -3
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
7:04 pm

gustafn

since "nsv_get $array $member varname" returns 0, when the array does not exist, we do not need the extra value for initialization

Options
    • -2
    • +1
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl