• last updated 19 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
support grading passed in via property

    • -2
    • +3
    /openacs-4/packages/xowf/lib/inclass-exam.wf
still initialize array

    • -1
    • +6
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
improve comment.

    • -3
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
since "nsv_get $array $member varname" returns 0, when the array does not exist, we do not need the extra value for initialization

    • -2
    • +1
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
cache parsed form_constraints via nsv instead of via global variable

    • -14
    • +21
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
- Define converters as procs

- Register these procs as aliases where convenient

- this effects:

dict_to_fc, dict_to_spec, spec_to_dict, fc_to_dict, dict_value

- extended regression test

- bumped version number to 5.10.1d9

    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -38
    • +140
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
minor editing changes

improve location of comment

prefer "Package require" over "Package initialize" when possible

    • -8
    • +8
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
adjust code with regression test, which performs literal comparison of rendered content

performance improvements for "::xo::db::Class proc get_instance_from_db"

when the object exists already, the text for existance is made earlier

to void useless operations. This change improves the performance by a factor of 3

when the object was already loaded.

OLD {4.544836 microseconds per iteration}

NEW {1.310991 microseconds per iteration}

Smartify idioms

Fix typo

reduce verbosity

    • -3
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Similar to the folder-create script, complain if the filename turns out empty after sanitizing

Allow the maximum size permitted by the datamodel in the UI, but then validate it before saving

When deleting, make sure supplied id is actually a room id

    • -1
    • +10
    /openacs-4/packages/chat/www/room-delete-2.tcl
    • -1
    • +9
    /openacs-4/packages/chat/www/room-delete.tcl
Trap the attempt to retrieve a non-existing forum and return a 404 in this case

this might need to happen in other places and/or be refined

Make error consistent with the already existing check in the content-repository

Handle more gracefully the case, which should not happen on a production system, that the file being downloaded does not exist on the filesystem

simplify idioms

- deactivate unused link-templates

- make quoting of label more consistent (it is passed in already quoted from the rich-text editors)

- whitespace changes

    • -125
    • +146
    /openacs-4/packages/xowiki/tcl/link-procs.tcl
Deprecate template::util::list_opts: it can be replaced by trivial tcl idioms

Streamline ns_set idioms

Streamline ns_set idiom

Streamline idioms

Streamline ns_set idioms

Fix typo

Deprecate template::util::set_to_vars: it can be replaced with trivial idioms

Deprecate template::util::set_to_list: this proc can be replaced with trivial ns_set and tcl idioms