OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 8
Total Committers: 146
Last Commit: 14:20
Commits this week: 8
Total Lines of Code (LoC): 7,560,931
Net change in LoC this week: 110

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 14 Feb
4:12 pm

antoniop

Whitespace changes

Options
    • -118
    • +118
    /openacs-4/packages/openacs-bootstrap5-theme/resources/forms/standard.adp
2:23 pm

antoniop

Harden page contracts

Options
    • -4
    • +2
    /openacs-4/packages/calendar-portlet/www/calendar-admin-portlet.tcl
    • -12
    • +2
    /openacs-4/packages/calendar-portlet/www/calendar-full-portlet.tcl
    • -12
    • +2
    /openacs-4/packages/calendar-portlet/www/calendar-list-portlet.tcl
1:54 pm

antoniop

Validate as a token also the default coming from _nls_language, ensure the resulting language key is at most 5 chars long (many thanks to Markus Moser for this)

Options
    • -3
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-form-procs.tcl
12:01 pm

antoniop

Update external dependencies to use the URN version

Options
    • -17
    • +16
    /openacs-4/packages/dotlrn-bootstrap3-theme/dotlrn-bootstrap3-theme.info
    • -3
    • +53
    /openacs-4/packages/dotlrn-bootstrap3-theme/tcl/apm-callback-procs.tcl
11:15 am

antoniop

Provide a more meaningful error message

Options
    • -2
    • +7
    /openacs-4/packages/dotlrn-portlet/tcl/test/dotlrn-portlet-procs.tcl
Tuesday 13 Feb
5:48 pm

antoniop

Reform of error handling in ad_page_contract when template recursion is detected

A "complaint recursion" happens if a validation error takes place in one of the templates used while rendering the error page (for instance, anything we include in the master template or the master template itself).

Previously, we would give up complaining after 10 recursions were detected. This had the consequence that after 10 attempt, the failing template involved in rendering the complaint would be fed the invalid data we were trying to reject.

Now, we complain and stop the execution as soon as a recursion is detected. The error will be rendered in a very basic way that overrides the templating system, so that we can exit the recursion cycle.

In practice, only malicious page manipulation attempts should be affected by this change.

Options
    • -35
    • +60
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
Monday 12 Feb
7:31 pm

gustafn

improved portability: some versions of "gzip" do not support option "-S"

Options
    • -3
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
7:29 pm

gustafn

improved spelling

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/apm-file-procs.tcl
5:22 pm

antoniop

Fix date validation using new contract features

Options
    • -10
    • +2
    /openacs-4/packages/calendar-portlet/www/calendar-portlet.tcl
Friday 09 Feb
2:45 pm

gustafn

pumped version to the highest available version number upstream (11.3.0)

Options
    • -2
    • +2
    /openacs-4/packages/highcharts/highcharts.info
    • -2
    • +2
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
2:44 pm

gustafn

Bumped version to the highest released version number (6.4.2)

Options
    • -2
    • +2
    /openacs-4/packages/fa-icons/fa-icons.info
    • -2
    • +2
    /openacs-4/packages/fa-icons/tcl/resource-procs.tcl
2:43 pm

gustafn

improved spelling

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/www/resources/proctored-page.js
11:36 am

gustafn

improved bootstrap5 compatibility for personal notifications

This change improves the appearance of personal notifications

for bootstrap5. It still works with bootstrap3.

Many thanks to Sebastian Scheder for this contribution!

Options
    • -11
    • +24
    /openacs-4/packages/xowiki/tcl/personal-notification-procs.tcl
11:23 am

gustafn

added commit on openacs for sscheder

Options
    • -0
    • +1
    /CVSROOT/avail
10:49 am

antoniop

Close the connection to the EventSource before leaving the page

Some browsers such as current Firefox may complain otherwise

Many thanks to Sebastian Scheder

Options
    • -0
    • +10
    /openacs-4/packages/xowiki/www/resources/chat.js
Thursday 08 Feb
7:47 pm

gustafn

improved spelling

Options
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/www/admin/record-test.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl
    • -8
    • +8
    /openacs-4/packages/acs-admin/www/apm/parameter-edit.tcl
    • -3
    • +3
    /openacs-4/packages/acs-admin/www/users/merge.adp
7:45 pm

gustafn

improved spacing on documentation page

Options
    • -4
    • +2
    /openacs-4/packages/acs-core-docs/www/xml/developers-guide/db-api.xml
7:44 pm

gustafn

added summary line as well to the begin of the output table

Options
    • -0
    • +11
    /openacs-4/packages/acs-automated-testing/www/admin/index.adp
7:43 pm

gustafn

improved logging output from install.xml files

Options
    • -6
    • +19
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
7:42 pm

gustafn

removed the previous half finished change, the update of the timezone data helps

Options
    • -8
    • +0
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl
7:40 pm

gustafn

Updates timezone data once again, bump version to 5.10.1b3

The timezone data from IANA has changed (probably several years ago),

and the min/max years have to be changed to -2147481748/2147485547,

which are no acceptable years for timestamps in PostgreSQL and

Oracle. The new timezone data maps now these boundary values 1/9999.

This commit fixes as well a bug introduced by the last version of the

timezone data in cases, where Tcl versions with older timezone data

were used, and the fallback operations based on Tcl failed. Tcl

versions 8.6.14* and Tcl 9.0* have up-to-date time zones, e.g. Tcl

8.6.13 still requires in some rare cases the fallback to the database,

where the error might show up.

Options
    • -2
    • +2
    /openacs-4/packages/ref-timezones/ref-timezones.info
    • -80739
    • +81885
    /openacs-4/packages/ref-timezones/sql/common/timezone-rules.dat
    • -162
    • +210
    /openacs-4/packages/ref-timezones/sql/common/timezones.dat
    • -4
    • +5
    /openacs-4/packages/ref-timezones/sql/postgresql/upgrade/upgrade-timezones.ctl
    • -1
    • +7
    /openacs-4/packages/ref-timezones/tcl/apm-callback-procs.tcl
7:14 pm

gustafn

improved spelling

Options
    • -1
    • +1
    /openacs-4/packages/acs-templating/tcl/currency-procs.tcl
    • -1
    • +2
    /openacs-4/packages/acs-templating/tcl/test/acs-integration-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/test/date-procs.tcl
6:55 pm

gustafn

improved spelling

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/admin/themes/index.adp
    • -2
    • +2
    /openacs-4/packages/acs-subsite/tcl/attribute-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-subsite/tcl/email-image-procs.tcl
    • -18
    • +20
    /openacs-4/packages/acs-subsite/tcl/test/subsite-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/permissions/perm-include.tcl
1:49 pm

gustafn

fix regression test to cope with time zone

Since OpenACS timezone data is now newer as in many tcl versions, some time zones

might not be available in tcl. Therefore, tcl-based conversions with these

time zones will fail.

This change skips these timezones (on my system, 2 cases). But this

is just a part of the fix. The "DB-based conversion" in "lc_time_tz_convert"

seems to be broken for these cases as well, otherwise the regression

test would not have stopped working.

Options
    • -0
    • +8
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl
10:41 am

gustafn

fixed bug #3469

First submenu item was missing. This bug is identical in the bootstrap3

and bootstrap5 theme packages. Many thanks to Keith Paskett for

rpeoprting and suggesting a fix.

Options
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/resources/widgets/navigation.tcl
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/resources/widgets/navigation.tcl
Wednesday 07 Feb
10:27 am

hectorr

Adapt test to current timezones

Options
    • -7
    • +0
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl
Tuesday 06 Feb
11:00 am

antoniop

Improve visualization of test info

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
10:32 am

antoniop

Relax test condition:

make sure potential injections are not rendered on the page response.

Options
    • -6
    • +13
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
Monday 05 Feb
6:44 pm

gustafn

Added dotlrn-bootstrap3-theme as default and use it instead of the outdated one

Options
    • -0
    • +3
    /openacs-4/packages/dotlrn/install.xml
6:25 pm

gustafn

Added dotlrn-bootstrap3-theme to modules and to dotlrn-all

Options
    • -1
    • +2
    /CVSROOT/modules