• last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Increase proc coverage

Increase proc coverage

Increase proc coverage

Test synonym api, cleanup redundant tests

Test cache initialization in an own test

Test additional api

Test additional behavior from api

Clarify commands scope

Declare additional coverage

Declare additional coverage

Consider failures obtaining the token as failure to verify the value and report into the log file

Fix boolean syntax in adp

Fix/modernize boolean syntax in adp

Declare api as tested

Make the api creating the Service Contract implementations for RSS in the file-storage package private, as they are meant to be invoked only once at install/uninstall time

Deprecate fs::torrent::get_hashsum, which can be replaced by a oneliner idiom on modern NaviServer

Increase proc coverage

Deprecate fs::add_created_version

This api was nowhere used in upstream code, however, allowed to create a new file object revision by text content, different from fs::add_version, which would only allow to create a revision from a file.

As the two apis were otherwise identical, I have ported the behavior of fs::add_created_version info fs::add_version.

The new fs::add_version will also take many defaults for unspecified parameters from the existing content item.

Make service contract implementation private

Give priority to the information provided explicitly to the api (the forum_id) in order to determine the package id and fallback to the connection context only when this is not available

    • -12
    • +37
    /openacs-4/packages/forums/tcl/forums-procs.tcl
Provide package_id to the api explicitly

Cleanup unused variables

Cleanup reference to non-existent parameter

Test checking for attachments availability by providing explicit package_id

Do not require a connection context to determine whether attachments are enabled on a certain package and provide explicit available information instead

Harden page contract

Value checkers will let empty values pass through

E.g. for a query like "?popular=&summary=1", the checker won't complain for "popular" being empty. Make sure empty values are normalized to false.

    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Harden page contract

Enforce data type of hidden fields, add missing parameters to the page contract

Make Service Contract implementation private

    • -3
    • +6
    /openacs-4/packages/faq/tcl/faq-procs.tcl