OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 24 Feb 2023
2:19 pm

antoniop

Give priority to the information provided explicitly to the api (the forum_id) in order to determine the package id and fallback to the connection context only when this is not available

Options
    • -12
    • +37
    /openacs-4/packages/forums/tcl/forums-procs.tcl
2:04 pm

antoniop

Provide package_id to the api explicitly

Options
    • -2
    • +2
    /openacs-4/packages/calendar/www/cal-item-view.tcl
2:03 pm

antoniop

Cleanup unused variables

Options
    • -4
    • +1
    /openacs-4/packages/calendar/www/cal-item-view.tcl
2:02 pm

antoniop

Cleanup reference to non-existent parameter

Options
    • -2
    • +1
    /openacs-4/packages/calendar/www/cal-item-view.tcl
1:53 pm

antoniop

Test checking for attachments availability by providing explicit package_id

Options
    • -2
    • +10
    /openacs-4/packages/calendar/tcl/test/calendar-procs.tcl
1:53 pm

antoniop

Do not require a connection context to determine whether attachments are enabled on a certain package and provide explicit available information instead

Options
    • -7
    • +6
    /openacs-4/packages/calendar/tcl/cal-item-procs.tcl
    • -43
    • +0
    /openacs-4/packages/calendar/tcl/cal-item-procs.xql
    • -3
    • +20
    /openacs-4/packages/calendar/tcl/calendar-procs.tcl
10:56 am

antoniop

Harden page contract

Options
    • -2
    • +2
    /openacs-4/packages/notifications/www/request-delete.tcl
Thursday 23 Feb 2023
6:05 pm

antoniop

Value checkers will let empty values pass through

E.g. for a query like "?popular=&summary=1", the checker won't complain for "popular" being empty. Make sure empty values are normalized to false.

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
5:24 pm

antoniop

Harden page contract

Options
    • -3
    • +3
    /openacs-4/packages/notifications/www/object-goto.tcl
5:12 pm

antoniop

Enforce data type of hidden fields, add missing parameters to the page contract

Options
    • -3
    • +6
    /openacs-4/packages/forums/lib/message/post.tcl
4:25 pm

antoniop

Make Service Contract implementation private

Options
    • -3
    • +6
    /openacs-4/packages/faq/tcl/faq-procs.tcl
4:04 pm

antoniop

Fix bulk_mail::url using the site_node api

Options
    • -14
    • +4
    /openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl
4:04 pm

antoniop

Complete coverage for the package

This test currently fails because a query was lost for bulk_mail::url

Options
    • -8
    • +24
    /openacs-4/packages/bulk-mail/tcl/test/bulk-mail-procs.tcl
3:47 pm

antoniop

Deprecate bulk_mail::pretty_name, trivial wrapper to the parameter api, which won't do anything to ensure that the pretty_name we are retrieving actually comes from a bulk-mail instance

Options
    • -2
    • +9
    /openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl
    • -2
    • +2
    /openacs-4/packages/bulk-mail/www/index.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn-bm/www/admin/index.tcl
3:28 pm

antoniop

Deprecate bulk_mail::parameter, which implements a global parameter logic

For now, the occurrences have just been inlined (fixing also the inconsistent naming PrettyName vs pretty_name). A future reform might create a proper global parameter for this.

Options
    • -1
    • +6
    /openacs-4/packages/assessment/www/asm-admin/bulk-mail.tcl
    • -2
    • +5
    /openacs-4/packages/bm-portlet/www/bm-portlet.tcl
    • -2
    • +8
    /openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl
    • -1
    • +6
    /openacs-4/packages/dotlrn/www/spam-recipients.tcl
    • -2
    • +6
    /openacs-4/packages/dotlrn/www/spam.tcl
2:38 pm

antoniop

Complete coverage for the package

Options
    • -5
    • +166
    /openacs-4/packages/chat/tcl/test/chat-test-procs.tcl
1:48 pm

antoniop

Fix syntax for proc coverage

Options
    • -2
    • +2
    /openacs-4/packages/chat/tcl/test/chat-test-procs.tcl
1:46 pm

antoniop

Expect arbitrary arguments on inherited methods, detect instance variables that should be passed to the object creation in save_new

Options
    • -4
    • +21
    /openacs-4/packages/chat/tcl/xotcl-chat-procs.tcl
1:45 pm

antoniop

Test chat room creation

This test now fails because certain acs_object metadata are not taken from instance variables, but from the context

Options
    • -0
    • +65
    /openacs-4/packages/chat/tcl/test/chat-test-procs.tcl
1:45 pm

antoniop

file chat-test-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/chat/tcl/test/chat-test-procs.tcl
1:13 pm

antoniop

Fix typo, make mailNickname required as per Microsoft specs (see https://learn.microsoft.com/en-us/graph/api/team-clone?view=graph-rest-1.0&tabs=http#request-body)

Many thanks to Sebastian Scheder

Options
    • -2
    • +2
    /openacs-4/packages/xooauth/tcl/ms-procs.tcl
1:04 pm

antoniop

Deprecate template::form::export, superseded by export_vars

Options
    • -3
    • +7
    /openacs-4/packages/acs-templating/tcl/form-procs.tcl
12:57 pm

antoniop

Test all the cornercases of this api as intended, without using ad_tmpnam

Options
    • -30
    • +30
    /openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl
Wednesday 22 Feb 2023
4:55 pm

antoniop

Make sure the cal item notification has at least 1 subscriber

Options
    • -4
    • +21
    /openacs-4/packages/calendar/tcl/test/cal-item-procs.tcl
1:57 pm

gustafn

increased value checking for paramter that might be influenced by user input

Options
    • -6
    • +6
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/import-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/link-procs.tcl
    • -7
    • +7
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/tree-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
1:06 pm

antoniop

Use a test admin user to run the ics test

Options
    • -3
    • +7
    /openacs-4/packages/calendar/tcl/test/cal-item-procs.tcl
Tuesday 21 Feb 2023
11:59 am

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
11:58 am

antoniop

Test db_foreach with -column_set with at least 2 rows to check that feering the ns_set works properly

Options
    • -5
    • +12
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
11:53 am

antoniop

Repair -column_set flag

A more efficient approach would use db api returning ns_sets directly, rather than db_list_of_lists, however this would require a deeper refactoring.

Options
    • -7
    • +26
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
11:49 am

antoniop

Test db_foreach -column_set flag, documented and used e.g. in the schema-browser

Options
    • -0
    • +8
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl