OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 18
Total Committers: 146
Last Commit: 28 Nov
Commits this week: 18
Total Lines of Code (LoC): 7,560,946
Net change in LoC this week: 3

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 17 Jan 2023
10:54 am

antoniop

Do not extend the existing multirow, we only enforce that this call will have the same columns

Options
    • -8
    • +2
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
10:53 am

antoniop

Test that appending to an existing multirow from the db works as expected: when the columns defined via query and extend are the same, this should succeed

Options
    • -0
    • +39
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
Monday 16 Jan 2023
6:27 pm

antoniop

Don't collide with multirows created by other tests

Options
    • -5
    • +5
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
5:23 pm

antoniop

Do not enforce that body is a list

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
5:11 pm

antoniop

Fix typo

Options
    • -1
    • +1
    /openacs-4/packages/file-storage/www/folder-chunk-postgresql.xql
3:42 pm

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
3:40 pm

antoniop

Performance improvements:

- set variables from the ns_set and extended variables separately

- collect the values and append to the multirow in one sweep

- when no code body is there, just bulk append the values

This appears to be ~5% faster than db_multirow when both are invoked with a code body and ~30% faster when invoked without (with no prepared statements)

Options
    • -20
    • +36
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
12:30 pm

antoniop

Simplify idiom

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
11:52 am

antoniop

Fix behavior of continue in the multirow code block, make the generic fallback behave the same as the postgres version with respect to appending

Options
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
11:51 am

antoniop

Test ::xo::dc multirow further

- break and continue behavior in the code block (this will expose a bug)

- appending to an existing multirow

Options
    • -4
    • +29
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
Friday 13 Jan 2023
6:21 pm

antoniop

Cleanup leftover line

Options
    • -2
    • +1
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
6:17 pm

antoniop

Extend automated tests to cover new ::xo::dc multirow api

Options
    • -9
    • +147
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
6:16 pm

antoniop

Provide an ::xo::dc api to generate multirows

Notable differences with the classical db_multirow:

- a multirow will always be appended when it already exists. The constraint that the two multirows must have the same columns remains.

- no "if_no_rows_code_block"

- no unclobber

- no subst, do it yourself :-)

- no cache stuff

- support for prepared statements

The remaining behavior has been kept the same, e.g. variables will always be reset to empty string, even if they existed outside of the code block. Compatibility has been checked with knowns idiosyncrasies.

Options
    • -1
    • +116
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
11:11 am

trenner

show the question_count in the title only while filling in the exam

Options
    • -1
    • +3
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Thursday 12 Jan 2023
2:43 pm

trenner

use message key

Options
    • -1
    • +1
    /openacs-4/packages/xowf/lib/inclass-exam.wf
2:35 pm

trenner

ensure variable results is defined

Options
    • -0
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Tuesday 10 Jan 2023
3:59 pm

antoniop

Fix prepared statement syntax

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
    • -6
    • +4
    /openacs-4/packages/proctoring-support/tcl/proctoring-procs.tcl
    • -1
    • +1
    /openacs-4/packages/proctoring-support/lib/examination-statement-accept.tcl
    • -4
    • +1
    /openacs-4/packages/proctoring-support/tcl/safe-exam-browser-procs.tcl
3:18 pm

antoniop

Remove test of undocumented format to specify prepared statement

Options
    • -10
    • +0
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
2:17 pm

trenner

show composite subquestions in question_overview_block

Options
    • -32
    • +47
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Monday 09 Jan 2023
6:11 pm

antoniop

Provide, as for other interfaces, a Postgres implementation of database foreach that will support prepared statements won't just wrap the db_* api

Options
    • -0
    • +39
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
5:51 pm

antoniop

Make sure the original SQL stays unchanged, as it is used e.g. in the nsv storing the statement and in log messages

Options
    • -6
    • +6
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
5:48 pm

antoniop

Basic test of xo::dc foreach when using prepared statements

This api currently supports the flag, but will ignore it

Options
    • -0
    • +29
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
4:15 pm

antoniop

Strip the possible validation constraint after the first colon character when building the cache key for a parameter, so that the value is stored correctly regardless of the format used to query the parameter

Fixes xowiki.xowiki_test_cases automated test

Options
    • -1
    • +7
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
11:53 am

antoniop

Improve the approach with strings containing colons in prepared SQL statements:

we first normalize all strings with a safe placeholder, substitute the variables, then put the strings back in place.

Options
    • -2
    • +19
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
11:52 am

antoniop

Extend test for prepared statements containing strings with colon characters, exposing that the latest commit won't address all cases

Options
    • -0
    • +13
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
Thursday 05 Jan 2023
5:54 pm

antoniop

Make test more consistent

Options
    • -1
    • +1
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
5:50 pm

antoniop

Improve the regexp detecting variables in a prepared statement, so that a prepared variable must not be preceded by a semicolon (as before), but also by any character allowed for a variable name

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
5:49 pm

antoniop

Introduce a test exposing that when a statement is prepared on SQL containing colons, this sould fail because they would be interpreted as variables

Options
    • -0
    • +10
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
Wednesday 04 Jan 2023
5:33 pm

antoniop

Reduce logging as we do downstream

Options
    • -2
    • +3
    /openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs.tcl
1:21 pm

antoniop

Refactor the query in the folder-chunk page so that on postgres one can enforce permissions in bulk, rather than for each file

Options
    • -0
    • +47
    /openacs-4/packages/file-storage/www/folder-chunk-postgresql.xql
    • -31
    • +2
    /openacs-4/packages/file-storage/www/folder-chunk.tcl
    • -3
    • +31
    /openacs-4/packages/file-storage/www/folder-chunk.xql