OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 22
Total Committers: 146
Last Commit: 27 Nov
Commits this week: 22
Total Lines of Code (LoC): 7,560,945
Net change in LoC this week: 2

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 19 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 07 Feb 2022
4:05 pm

antoniop

Log the error message

Options
    • -1
    • +2
    /openacs-4/packages/calendar/www/cal-item-delete-confirm.tcl
4:01 pm

antoniop

Return a 404 and trap the error when one supplies an invalid ID

Options
    • -1
    • +8
    /openacs-4/packages/calendar/www/cal-item-delete-confirm.tcl
3:47 pm

antoniop

Fix typo

Options
    • -3
    • +1
    /openacs-4/packages/file-storage/www/folder-delete.tcl
3:20 pm

antoniop

Validate the portal_id via the page contract, keep passing the whole form down as before

Options
    • -7
    • +4
    /openacs-4/packages/dotlrn/www/configure-2.tcl
2:23 pm

gustafn

Export by default only the declared query variables

Varibles are declared via package specification or in the includelet

definition. Previously, all query variables where exported.

Options
    • -13
    • +36
    /openacs-4/packages/xotcl-core/tcl/context-procs.tcl
1:21 pm

gustafn

improve spelling

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/proxy-test-procs.tcl
1:13 pm

gustafn

extend tests and pinpoint essesntials

Options
    • -0
    • +20
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
11:30 am

antoniop

Cleanup smelly comment: we don't need to catch the error, if it fails it fails and the application should handle it

Options
    • -2
    • +1
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
11:20 am

antoniop

Minimize and corrrect test: strings containing the null character are expected to fail when fed to the DBMS, even when quoted

Options
    • -10
    • +14
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
    • -109
    • +0
    /openacs-4/packages/acs-tcl/tcl/test/data/db-quoting-test.txt
Saturday 05 Feb 2022
11:32 pm

gustafn

added support for eliptic curve certificates (ecdsa)

The change will become effective, once the letsencrypt packages

is updated

Options
    • -1
    • +12
    /openacs-4/packages/acs-admin/tcl/acs-admin-procs.tcl
5:59 pm

gustafn

Improved startup time (of server, of threads) by using nsv_dict when available

During definition of attributes, the xo-db inteface checks whether

the db attributes managed by xotcl are in sync with the actual database.

This was done so far by a couple of small database query. When nsv_dict

is available, it can be used for quickly checking those values.

Options
    • -12
    • +52
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
5:56 pm

gustafn

use better idiom for checking for the existence of objects

Options
    • -1
    • +1
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
Friday 04 Feb 2022
4:07 pm

antoniop

Restrict more the kind of items that can pass through the initial check

Options
    • -2
    • +2
    /openacs-4/packages/file-storage/www/download-zip.tcl
3:53 pm

antoniop

ad_conn provides since a long time a fallback when the package_id is queried outside of a connection context, hence no need for these concerning catches

Options
    • -19
    • +20
    /openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
2:40 pm

antoniop

Make fs::get_file_package_id more robust to cases where the package_id is not set on the object itself: climb up the hierarchy

Options
    • -2
    • +18
    /openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
    • -8
    • +0
    /openacs-4/packages/file-storage/tcl/file-storage-procs.xql
12:07 pm

gustafn

Don't trust blindly the mime-type determined by the file extension and try to use the unix command "file" when available

Options
    • -14
    • +36
    /openacs-4/packages/search/tcl/search-convert-procs.tcl
Thursday 03 Feb 2022
8:51 pm

gustafn

add safety belt for unexpected behavior which can show up in some error cases.

Options
    • -0
    • +13
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
7:26 pm

gustafn

Reduce dependencies on YUI 2

- Added native CSS classes for Tree renderer

(named "xowiki-tree" to avoid name clashes).

- Made TreeRenderer more configurable, by providing css class names etc.

- toc includelet: replaced default (when no style is provided)

from yuitree to list + xowiki-tree.

The old behavior can be achieved by {{toc -style yuitree}}

Note that not all features of the YUI tree might be available

- The CSS variant with xowiki-tree can also be used for the folder-tree,

but so far, the bootstrap3 renderer is more nice.

Options
    • -5
    • +16
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
    • -14
    • +25
    /openacs-4/packages/xowiki/tcl/tree-procs.tcl
    • -3
    • +58
    /openacs-4/packages/xowiki/www/resources/xowiki.css
3:33 pm

antoniop

New automated test

Options
    • -0
    • +18
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
    • -0
    • +109
    /openacs-4/packages/acs-tcl/tcl/test/data/db-quoting-test.txt
3:33 pm

antoniop

file db-quoting-test.txt was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/test/data/db-quoting-test.txt
2:58 pm

antoniop

Provide a fallback for vhost_url in ad_conn for code executed before this value has been set by the request processor

Options
    • -1
    • +6
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
1:18 pm

gustafn

provide a clean representation of questions to reduce hacking and complexity

Options
    • -0
    • +29
    /openacs-4/packages/xowf/tcl/test/test-helper-procs.tcl
    • -60
    • +59
    /openacs-4/packages/xowf/tcl/test/test-item-procs.tcl
1:18 pm

gustafn

file test-helper-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/xowf/tcl/test/test-helper-procs.tcl
9:25 am

antoniop

Display the actual smell in the test

Options
    • -5
    • +7
    /openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl
Wednesday 02 Feb 2022
3:17 pm

antoniop

As we cannot know which kind of exercise we got on a page in advance due to randomization, make the parameter we send for an answer dependant on the question type we find

Options
    • -13
    • +34
    /openacs-4/packages/xowf/tcl/test/test-item-procs.tcl
11:30 am

antoniop

Modernize api

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
11:28 am

antoniop

Improve test robustness:

the folder in the test is required, so it might be the case that its state was already tampered with. Change the test to first make sure the state from db and object are consistent, whatever they are, then perform some set/fetch/check tests on 3 arbitrary states

Options
    • -13
    • +15
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
Tuesday 01 Feb 2022
10:10 pm

gustafn

extended regression test

Options
    • -0
    • +47
    /openacs-4/packages/xowiki/tcl/test/api-test-procs.tcl
    • -10
    • +117
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
10:09 pm

gustafn

improve spelling

Options
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/yui-init.tcl
10:09 pm

gustafn

make API call a public one

Options
    • -10
    • +12
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl