Activity OpenACS/

ad_conn provides since a long time a fallback when the package_id is queried outside of a connection context, hence no need for these concerning catches

- -19
- +20
/openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
- History
- Source
- Diff
/openacs-4/.../file-storage-procs.tcl

2:40 pm

antoniop

Make fs::get_file_package_id more robust to cases where the package_id is not set on the object itself: climb up the hierarchy

- -2
- +18
/openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
- History
- Source
- Diff
/openacs-4/.../file-storage-procs.tcl
- -8
- +0
/openacs-4/packages/file-storage/tcl/file-storage-procs.xql
- History
- Source
- Diff
/openacs-4/.../file-storage-procs.xql

12:07 pm

gustafn

Don't trust blindly the mime-type determined by the file extension and try to use the unix command "file" when available

- -14
- +36
/openacs-4/packages/search/tcl/search-convert-procs.tcl
- History
- Source
- Diff
/openacs-4/.../search-convert-procs.tcl

8:51 pm

gustafn

add safety belt for unexpected behavior which can show up in some error cases.

- -0
- +13
/openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../01-debug-procs.tcl

7:26 pm

gustafn

Reduce dependencies on YUI 2

- Added native CSS classes for Tree renderer

(named "xowiki-tree" to avoid name clashes).

- Made TreeRenderer more configurable, by providing css class names etc.

- toc includelet: replaced default (when no style is provided)

from yuitree to list + xowiki-tree.

The old behavior can be achieved by {{toc -style yuitree}}

Note that not all features of the YUI tree might be available

- The CSS variant with xowiki-tree can also be used for the folder-tree,

but so far, the bootstrap3 renderer is more nice.

- -5
- +16
/openacs-4/packages/xowiki/tcl/includelet-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../includelet-procs.tcl
- -14
- +25
/openacs-4/packages/xowiki/tcl/tree-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/tree-procs.tcl
- -3
- +58
/openacs-4/packages/xowiki/www/resources/xowiki.css
- History
- Source
- Diff
/openacs-4/packages/.../resources/xowiki.css

3:33 pm

antoniop

New automated test

- -0
- +18
/openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
- History
- Source
- Diff
/openacs-4/.../db-proc-test-procs.tcl
- -0
- +109
/openacs-4/packages/acs-tcl/tcl/test/data/db-quoting-test.txt
- History
- Source
- Diff
/openacs-4/packages/.../db-quoting-test.txt

3:33 pm

antoniop

More
MAIN:antoniop:20220203143355
deleted 1 file
MAIN

file db-quoting-test.txt was initially added on branch oacs-5-10.

- -0
- +0
/openacs-4/packages/acs-tcl/tcl/test/data/db-quoting-test.txt
- History
- Source
/openacs-4/packages/.../data/db-quoting-test.txt

2:58 pm

antoniop

Provide a fallback for vhost_url in ad_conn for code executed before this value has been set by the request processor

- -1
- +6
/openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
- History
- Source
- Diff
/openacs-4/.../request-processor-procs.tcl

1:18 pm

gustafn

provide a clean representation of questions to reduce hacking and complexity

- -0
- +29
/openacs-4/packages/xowf/tcl/test/test-helper-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test-helper-procs.tcl
- -60
- +59
/openacs-4/packages/xowf/tcl/test/test-item-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test-item-procs.tcl

1:18 pm

gustafn

More
MAIN:gustafn:20220203121825
deleted 1 file
MAIN

file test-helper-procs.tcl was initially added on branch oacs-5-10.

- -0
- +0
/openacs-4/packages/xowf/tcl/test/test-helper-procs.tcl
- History
- Source
/openacs-4/packages/.../test/test-helper-procs.tcl

9:25 am

antoniop

Display the actual smell in the test

- -5
- +7
/openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl
- History
- Source
- Diff
/openacs-4/.../acs-api-browser-procs.tcl

3:17 pm

antoniop

As we cannot know which kind of exercise we got on a page in advance due to randomization, make the parameter we send for an answer dependant on the question type we find

- -13
- +34
/openacs-4/packages/xowf/tcl/test/test-item-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test-item-procs.tcl

11:30 am

antoniop

Modernize api

- -3
- +3
/openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../xowiki-test-procs.tcl

11:28 am

the folder in the test is required, so it might be the case that its state was already tampered with. Change the test to first make sure the state from db and object are consistent, whatever they are, then perform some set/fetch/check tests on 3 arbitrary states