OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 10
Total Committers: 145
Last Commit: 31 May
Commits this week: 10
Total Lines of Code (LoC): 6,873,112
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 19 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 13 Feb 2022
8:31 pm

gustafn

fix cut&paste issue

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/tcl/subsite-callback-procs-postgresql.xql
5:46 pm

gustafn

Fixes for Oracle 19c recursive query

Oracle has a slightly differnt syntax for CTEs require arguments, keyword "recursive" is not allowed.

This fixes the following error during initial installation:

nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00905: missing keyword

SQL:

with recursive !>>>!object_hierarchy as (

select object_type, supertype

from acs_object_types

where object_type = coalesce(:object_type, (select object_type

from acs_objects

where object_id = :object_id))

union all

select t.object_type, t.supertype

from acs_object_types t,

object_hierarchy s

where t.object_type = s.supertype

)

select distinct callback, callback_type as type

from subsite_callbacks

where event_type = :event_type

and object_type in (select object_type from object_hierarchy)

Options
    • -0
    • +30
    /openacs-4/packages/acs-subsite/tcl/subsite-callback-procs-oracle.xql
    • -0
    • +30
    /openacs-4/packages/acs-subsite/tcl/subsite-callback-procs-postgresql.xql
    • -21
    • +2
    /openacs-4/packages/acs-subsite/tcl/subsite-callback-procs.tcl
4:45 pm

gustafn

Fixes for Oracle 19c for membership and composition triggers

Warning: Trigger created with compilation errors.

Errors for TRIGGER MEMBERSHIP_RELS_IN_TR:

LINE/COL ERROR

-------- -----------------------------------------------------------------

14/3 PL/SQL: SQL Statement ignored

16/3 PL/SQL: ORA-00947: not enough values

32/3 PL/SQL: Statement ignored

32/6 PLS-00201: identifier 'V_COMPOSABLE_P' must be declared

Trigger created.

No errors.

Warning: Trigger created with compilation errors.

Errors for TRIGGER COMPOSITION_RELS_IN_TR:

LINE/COL ERROR

-------- -----------------------------------------------------------------

72/21 PL/SQL: SQL Statement ignored

72/48 PL/SQL: ORA-00918: column ambiguously defined

83/7 PL/SQL: Statement ignored

83/47 PLS-00364: loop index variable 'MEMBERS' use is invalid

86/5 PL/SQL: SQL Statement ignored

91/6 PL/SQL: ORA-00918: column ambiguously defined

Trigger created.

No errors.

Options
    • -4
    • +5
    /openacs-4/packages/acs-kernel/sql/oracle/groups-body-create.sql
    • -3
    • +5
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade--5.9.1d15-5.9.1d16.sql
2:21 pm

gustafn

The composite_p attribute for acs_object_type.create_type() was missing

This fixes in essence the following errors.

acs_rel_type.create_type (

*

ERROR at line 35:

ORA-06550: line 35, column 2:

PLS-00306: wrong number or types of arguments in call to 'CREATE_TYPE'

ORA-06550: line 35, column 2:

PL/SQL: Statement ignored

ORA-06550: line 54, column 2:

PLS-00306: wrong number or types of arguments in call to 'CREATE_TYPE'

ORA-06550: line 54, column 2:

PL/SQL: Statement ignored

ORA-06550: line 70, column 2:

PLS-00306: wrong number or types of arguments in call to 'CREATE_TYPE'

ORA-06550: line 70, column 2:

PL/SQL: Statement ignored

No errors

insert into group_type_rels

*

ERROR at line 1:

ORA-02291: integrity constraint (OPENACS.GROUP_TYPE_RELS_GROUP_TYPE_FK)

violated - parent key not found

insert into group_type_rels

*

ERROR at line 1:

ORA-02291: integrity constraint (OPENACS.GROUP_TYPE_RELS_GROUP_TYPE_FK)

violated - parent key not found

Options
    • -5
    • +9
    /openacs-4/packages/acs-kernel/sql/oracle/acs-relationships-create.sql
    • -5
    • +5
    /openacs-4/packages/acs-kernel/sql/oracle/groups-create.sql
1:10 pm

gustafn

Fixes during the creation of the search observer queue for Oracle 19c:

In essence, the change repairs the following error:

Warning: Package Body created with compilation errors.

Errors for PACKAGE BODY SEARCH_OBSERVER:

LINE/COL ERROR

-------- -----------------------------------------------------------------

16/7 PL/SQL: SQL Statement ignored

16/40 PL/SQL: ORA-00933: SQL command not properly ended

Options
    • -4
    • +5
    /openacs-4/packages/search/sql/oracle/search-packages-create.sql
12:46 pm

gustafn

More fixes for Oracle 19c in essential packages

in essence, this fixes

- package content_item

- package content_folder

with the following errors popping at at installation:

Errors for PACKAGE BODY CONTENT_FOLDER:

LINE/COL ERROR

-------- -----------------------------------------------------------------

76/11 PLS-00323: subprogram or cursor 'COPY' is declared in a package

specification and must be defined in the package body

Errors for PACKAGE BODY CONTENT_ITEM:

LINE/COL ERROR

-------- -----------------------------------------------------------------

22/10 PLS-00323: subprogram or cursor 'NEW' is declared in a package

specification and must be defined in the package body

40/1 PL/SQL: Item ignored

67/38 PLS-00382: expression is of wrong type

275/11 PLS-00323: subprogram or cursor 'SET_LIVE_REVISION' is declared

in a package specification and must be defined in the package

body

DRG-10595: ALTER INDEX CR_REV_ATTRIBUTE_INDEX failed

DRG-11000: invalid keyword SYNC

DRG-10595: ALTER INDEX CR_REV_CONTENT_INDEX failed

DRG-11000: invalid keyword SYNC

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/sql/oracle/content-item.sql
    • -3
    • +30
    /openacs-4/packages/acs-content-repository/sql/oracle/content-search.sql
    • -4
    • +6
    /openacs-4/packages/acs-content-repository/sql/oracle/packages-create.sql
Saturday 12 Feb 2022
9:13 pm

gustafn

providing compatibility with Oracle 19c

Either these scripts never worked for Oracle, or these Oracle changed over the years

Options
    • -2
    • +2
    /openacs-4/packages/acs-kernel/sql/oracle/acs-relationships-create.sql
    • -24
    • +31
    /openacs-4/packages/acs-kernel/sql/oracle/utilities-create.sql
9:11 pm

gustafn

improving Oracle upgrade scripts

Oracle has no "ALTER TABLE ADD COLUMN ...."

Oracle has no "ALTER TABLE ADD COLUMN if exists .."

Options
    • -1
    • +1
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade--5.9.1d15-5.9.1d16.sql
    • -3
    • +17
    /openacs-4/packages/acs-lang/sql/oracle/upgrade/upgrade-5.10.0d11-5.10.0d12.sql
    • -1
    • +1
    /openacs-4/packages/assessment/sql/oracle/upgrade/upgrade-0.11-0.12.sql
    • -1
    • +1
    /openacs-4/packages/assessment/sql/oracle/upgrade/upgrade-0.12-0.13.sql
    • -1
    • +1
    /openacs-4/packages/bulk-mail/sql/oracle/upgrade/upgrade-2.10.0d2-2.10.0d3.sql
    • -1
    • +1
    /openacs-4/packages/chat/sql/oracle/upgrade/upgrade-5.0.1d6-5.0.1d7.sql
    • -2
    • +2
    /openacs-4/packages/faq/sql/oracle/upgrade/upgrade-5.10.0d5-5.10.0d6.sql
    • -1
    • +1
    /openacs-4/packages/forums/sql/oracle/upgrade/upgrade-1.3-1.3d1.sql
    • -1
    • +1
    /openacs-4/packages/forums/sql/oracle/upgrade/upgrade-1.3.1d2-1.3.1d3.sql
Friday 11 Feb 2022
6:29 pm

antoniop

Cleanup hardocded xinha references in the plain master

Options
    • -11
    • +0
    /openacs-4/packages/acs-bootstrap-installer/installer/www/blank-master.adp
6:23 pm

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/richtext-xinha/tcl/richtext-procs.tcl
6:17 pm

antoniop

file download.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/richtext-xinha/www/sitewide-admin/download.tcl
6:17 pm

antoniop

file index.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/richtext-xinha/www/sitewide-admin/index.tcl
6:17 pm

antoniop

file index.adp was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/richtext-xinha/www/sitewide-admin/index.adp
6:17 pm

antoniop

Richtext Xinha package revamp:

since this editor now seems to enjoy somewhat better support, I have "borrowed" much of the logic available in richtext-ckeditor4 so that users can keep their editor version up to date.

Notable changes:

- we do not ship the actual Xinha editor ourselves, it will by default come from the cdn (on Amazon servers) or can be downloaded locally as we do for CKEditor4

- plugins that have been developed specifically for OpenACS (which seem to keep working) are now maintained in a separate folder tree and configured in the editor specifically

- The configuration for which plugins should be available is now maintained at the package level

Options
    • -6
    • +7
    /openacs-4/packages/richtext-xinha/richtext-xinha.info
    • -106
    • +218
    /openacs-4/packages/richtext-xinha/tcl/richtext-procs.tcl
    • -388
    • +0
    /openacs-4/packages/richtext-xinha/www/resources/xinha-nightly/Xinha.css
    • -5992
    • +0
    /openacs-4/packages/richtext-xinha/www/resources/xinha-nightly/XinhaConfig.js
    • -8426
    • +0
    /openacs-4/packages/richtext-xinha/www/resources/xinha-nightly/XinhaCore.js
    • -283
    • +0
    /openacs-4/packages/richtext-xinha/www/resources/xinha-nightly/XinhaLoader.js
    • -5
    • +0
    /openacs-4/packages/richtext-xinha/www/resources/xinha-nightly/XinhaLoader_readme.txt
    • -8
    • +0
    /openacs-4/packages/richtext-xinha/www/resources/xinha-nightly/compression_readme.txt
    • -80
    • +0
    /openacs-4/packages/richtext-xinha/www/resources/xinha-nightly/dialog.js
    • -406
    • +0
    /openacs-4/packages/richtext-xinha/www/resources/xinha-nightly/functionsIE.js
    • -883
    • +0
    /openacs-4/packages/richtext-xinha/www/resources/xinha-nightly/functionsMozilla.js
    • -263
    • +0
    /openacs-4/packages/richtext-xinha/www/resources/xinha-nightly/getHTML.js
    • -256
    • +0
    /openacs-4/packages/richtext-xinha/www/resources/xinha-nightly/htmlarea.css
    • -23
    • +0
    /openacs-4/packages/richtext-xinha/www/resources/xinha-nightly/htmlarea.js
    • -327
    • +0
    /openacs-4/packages/richtext-xinha/www/resources/xinha-nightly/inline-dialog.js
  16. … 1939 more files in changeset.
Thursday 10 Feb 2022
10:33 pm

gustafn

fixes for Oracle 19c

Options
    • -2
    • +2
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-authentication/tcl/test/authentication-procs.tcl
    • -7
    • +8
    /openacs-4/packages/acs-lang/sql/oracle/message-catalog.sql
    • -0
    • +1
    /openacs-4/packages/acs-tcl/tcl/20-memoize-init.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/acs-kernel-procs.tcl
    • -4
    • +5
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
5:31 pm

antoniop

Provide an api to delete proctoring artifacts together with their folder in order to reduce duplication

Options
    • -2
    • +2
    /openacs-4/packages/proctoring-support/proctoring-support.info
    • -13
    • +3
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
    • -0
    • +21
    /openacs-4/packages/proctoring-support/tcl/proctoring-procs.tcl
    • -21
    • +78
    /openacs-4/packages/proctoring-support/tcl/test/proctoring-test-procs.tcl
2:54 pm

antoniop

Fix typo in doc

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/tcl/proctoring-procs.tcl
2:51 pm

antoniop

Fix typo in doc

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/tcl/proctoring-procs.tcl
2:16 pm

antoniop

Provide an api to store proctoring artifacts, and a callback hook for postprocessing

Options
    • -2
    • +2
    /openacs-4/packages/proctoring-support/proctoring-support.info
    • -14
    • +8
    /openacs-4/packages/proctoring-support/lib/proctoring-upload.tcl
    • -0
    • +17
    /openacs-4/packages/proctoring-support/tcl/proctoring-callback-procs.tcl
    • -0
    • +81
    /openacs-4/packages/proctoring-support/tcl/proctoring-procs.tcl
    • -0
    • +124
    /openacs-4/packages/proctoring-support/tcl/test/proctoring-test-procs.tcl
12:50 pm

trenner

ensure html markup is well formed

"::xowiki::includelet::personal-notification-messages modal_message_dialog"

is returning the html link with an open a-tag, which has to be closed from the caller

Options
    • -4
    • +2
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
10:32 am

antoniop

file apm-callback-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/proctoring-support/tcl/apm-callback-procs.tcl
10:32 am

antoniop

Introduce a data model for "proctoring artifacts", aka the pictures

and audios, which so far have only lived as files in the filesystem

named after a convention

The new datamodel allows to quickly and reliably retrieve the pictures

collected by proctoring and also provides for a technical space, in

form of a JSON metadata column, to store additional information coming

from e.g. postprocessing phases.

The idea is to use this feature to provide reviewing tools of proctoring results and allow for flexile downstream postprocessing.

The file naming convention has not been changed for the time being, so this would be

retro-compatible. However, integrators should start relying on the new

data model to retrieve pictures.

Options
    • -3
    • +4
    /openacs-4/packages/proctoring-support/proctoring-support.info
    • -2
    • +11
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
    • -70
    • +83
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
    • -0
    • +10
    /openacs-4/packages/proctoring-support/lib/proctoring-upload.tcl
    • -0
    • +45
    /openacs-4/packages/proctoring-support/sql/postgresql/proctoring-support-create.sql
    • -0
    • +1
    /openacs-4/packages/proctoring-support/sql/postgresql/proctoring-support-drop.sql
    • -0
    • +48
    /openacs-4/packages/proctoring-support/sql/postgresql/upgrade/upgrade-3.0.0-3.1.0.sql
    • -0
    • +113
    /openacs-4/packages/proctoring-support/tcl/apm-callback-procs.tcl
    • -1
    • +1
    /openacs-4/packages/proctoring-support/www/upload.tcl
10:32 am

antoniop

file upgrade-3.0.0-3.1.0.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/proctoring-support/sql/postgresql/upgrade/upgrade-3.0.0-3.1.0.sql
10:01 am

gustafn

bump version number of CKeditor to 4.17.2 and package to 0.24

Options
    • -2
    • +2
    /openacs-4/packages/richtext-ckeditor4/richtext-ckeditor4.info
    • -3
    • +3
    /openacs-4/packages/richtext-ckeditor4/tcl/richtext-procs.tcl
Wednesday 09 Feb 2022
4:53 pm

trenner

display notification link while the exam is published

Options
    • -2
    • +2
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
4:09 pm

antoniop

Get the user_id directly

Options
    • -3
    • +1
    /openacs-4/packages/proctoring-support/lib/proctoring-upload.tcl
3:55 pm

antoniop

Not rely on a deprecated command to check for websockets, improve idiom

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/lib/proctoring-upload.tcl
3:50 pm

antoniop

Merge if conditions

Options
    • -5
    • +6
    /openacs-4/packages/proctoring-support/tcl/proctoring-procs.tcl
3:41 pm

antoniop

Improve doc

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/tcl/proctoring-callback-procs.tcl
3:33 pm

antoniop

Fix typical last minute mistake

Options
    • -1
    • +2
    /openacs-4/packages/proctoring-support/tcl/proctoring-callback-procs.tcl