• last updated 57 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
automated tests: fix broken argument in test case

- return results as dict

- make array argument optional

- improve documentation

Align XoWiki UI naming to that currently in xowiki.pretty_name

Mark flags as required

- fix file handling of SQL files

- add counting of blank lines

- add counting of comment lines

Trailing whitespace cleanup

whitespace changes

Let the teardown code take care of removing the site nodes (fixes tests on a vanilla core-only instance)

Unnest list idiom when we retrieve the url by package id in non-xotcl site node implementation (fixes tests on a vanilla instance with just the core packages)

undo previous change, problem was solved more generically in form-field-procs.tcl

    • -27
    • +0
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
whitespace changes

improve indentation

    • -2
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Fix behavior, in case a default value was provided for a checkbox part of a compound field.

When the user resets this default (i.e. clears the checkmark) no data is

transmitted from the browser, but the client side has to handle this. Such cases were

so far only handled so far outside of compound fields.

Example as give my Michael Aram (many thanks!):

# Class create mycompound -superclass CompoundField

#

# mycompound instproc initialize {} {

# if {${:__state} ne "after_specs"} return

# :create_components [subst {

# {start_on_publish {checkbox,default=t,options={YES t}}}

# {whatever {text}}

# }]

# set :__initialized 1

# }

Relax the test as some homepages might redirect to the login page and little assumptions can be made about the content (fixes vanilla dotlrn case)

Add doc to public procs (fixes automated tests)

Make tclwebtest procs private (fixes automated tests)

Whitespace cleanup

Follow redirects in this test to accomodate e.g. the vanilla dotlrn installation scenario

Add new parameter 'depth' deciding whether we want to follow redirects when testing a URL (default is we don't follow redirects as before)

prefer dict over anonymous array

    • -10
    • +17
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -30
    • +42
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
remove unneeded variable

CSP: allow frame-ancestors

Bump version number

Export message keys from UI to normalize sorting and HTML quoting

Exclude locales that are not enabled from test

Do not test deleted keys

- if one is handling ::db::Object slots generally, to it correctly (including "object_id")

- reduce redundancy

Display error message when the test fails

Backport changes from downstream: add CrItems we skip as they are handled by ::xo::db::Object already

check if is_self_link parameter exist - ExternalLink don't have it defined

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl