OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 146
Last Commit: 29 Jul
Commits this week: 0
Total Lines of Code (LoC): 7,561,801
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 28 Mar 2023
1:20 pm

antoniop

Remove no_alarms_until column

Rationale: the column or the related api is never used in upstream code to check whether notifications should be sent or not or not. The UI to manage the column's value was not linked anywhere. On the instances accessible by me downstream, no tuple was found where this column had a value.

Options
    • -7
    • +0
    /openacs-4/packages/acs-core-docs/www/groups-design.adp
    • -6
    • +0
    /openacs-4/packages/acs-core-docs/www/groups-design.html
    • -1
    • +0
    /openacs-4/packages/acs-core-docs/www/parties.adp
    • -2
    • +1
    /openacs-4/packages/acs-core-docs/www/parties.html
    • -2
    • +1
    /openacs-4/packages/acs-core-docs/www/xml/developers-guide/parties.xml
    • -1
    • +0
    /openacs-4/packages/acs-core-docs/www/xml/kernel/ext-auth-design.xml
    • -10
    • +0
    /openacs-4/packages/acs-core-docs/www/xml/kernel/groups-design.xml
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -2
    • +2
    /openacs-4/packages/acs-kernel/sql/oracle/acs-create.sql
    • -27
    • +1
    /openacs-4/packages/acs-kernel/sql/oracle/community-core-create.sql
    • -0
    • +200
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1d17-5.10.1d18.sql
    • -37
    • +1
    /openacs-4/packages/acs-kernel/sql/postgresql/community-core-create.sql
    • -0
    • +49
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d17-5.10.1d18.sql
    • -8
    • +0
    /openacs-4/packages/acs-subsite/www/pvt/set-on-vacation-to-null.adp
    • -29
    • +0
    /openacs-4/packages/acs-subsite/www/pvt/set-on-vacation-to-null.tcl
  16. … 4 more files in changeset.
1:20 pm

antoniop

file upgrade-5.10.1d17-5.10.1d18.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1d17-5.10.1d18.sql
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d17-5.10.1d18.sql
11:54 am

antoniop

Avoid fetching the request forum manually

Options
    • -8
    • +12
    /openacs-4/packages/acs-subsite/www/admin/rel-types/roles/edit.tcl
11:48 am

antoniop

Whitespace and comment cleanup

Options
    • -5
    • +2
    /openacs-4/packages/acs-subsite/www/admin/rel-types/roles/edit.tcl
11:47 am

antoniop

Cleanup redundant parameter fetching

Options
    • -3
    • +1
    /openacs-4/packages/acs-subsite/www/admin/attributes/edit-one.tcl
11:44 am

antoniop

Fix typo

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/admin/groups/rel-type-add.adp
11:35 am

antoniop

Update documentation

Options
    • -3
    • +2
    /openacs-4/packages/acs-tcl/tcl/widgets-procs.tcl
Monday 27 Mar 2023
2:20 pm

trenner

put the notification creation in a db_transaction to ensure same subscription is created only once (e.g. double-clicks)

Options
    • -8
    • +10
    /openacs-4/packages/notifications/www/request-new.tcl
10:04 am

trenner

improve input validation

Options
    • -0
    • +19
    /openacs-4/packages/acs-subsite/www/permissions/perm-modify.tcl
Friday 24 Mar 2023
6:12 pm

antoniop

Apply downstream fixes

Options
    • -3
    • +2
    /openacs-4/packages/calendar-portlet/www/calendar-portlet.adp
6:11 pm

antoniop

Test of the calendar portlet, admin and regular, for all views

The tests exposes typos and forgottent variables in upstream code

Options
    • -0
    • +66
    /openacs-4/packages/calendar-portlet/tcl/test/calendar-portlet-procs.tcl
5:47 pm

antoniop

Test bm_portlet::show, but then make it private: it is not supposed to be invoked on its own, but via the Service Contract API

Options
    • -2
    • +2
    /openacs-4/packages/bm-portlet/tcl/bm-portlet-procs.tcl
    • -1
    • +37
    /openacs-4/packages/bm-portlet/tcl/test/bm-portlet-procs.tcl
5:28 pm

antoniop

Claim additional coverage

Options
    • -1
    • +3
    /openacs-4/packages/acs-service-contract/tcl/test/acs-service-contract-procs.tcl
5:23 pm

antoniop

Basic test of acs_mail_lite::send

Options
    • -0
    • +103
    /openacs-4/packages/acs-mail-lite/tcl/test/acs-mail-lite-procs.tcl
5:23 pm

antoniop

file acs-mail-lite-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-mail-lite/tcl/test/acs-mail-lite-procs.tcl
5:02 pm

antoniop

Make acs_mail_lite::utils::build_body, replace (commented) references in other packages

Options
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/utils-procs.tcl
    • -2
    • +0
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
4:51 pm

antoniop

Complete coverage for the package

Options
    • -0
    • +60
    /openacs-4/packages/acs-lang/tcl/test/lang-widget-procs.tcl
4:51 pm

antoniop

file lang-widget-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-lang/tcl/test/lang-widget-procs.tcl
4:21 pm

antoniop

State new dependencies

Options
    • -2
    • +2
    /openacs-4/packages/acs-datetime/acs-datetime.info
    • -3
    • +3
    /openacs-4/packages/calendar/calendar.info
1:43 pm

hectorr

Whitespace changes

Options
    • -11
    • +11
    /openacs-4/packages/dotlrn/www/weblog-new.tcl
Thursday 23 Mar 2023
6:22 pm

antoniop

Replace deprecated api

Options
    • -2
    • +8
    /openacs-4/packages/evaluation/www/admin/tasks/task-add-edit.tcl
6:12 pm

antoniop

Use new feature for dt_get_info to retrieve variables in a way that we know what is there and what not

Options
    • -8
    • +12
    /openacs-4/packages/calendar/www/mini-calendar.tcl
    • -1
    • +1
    /openacs-4/packages/calendar/www/view-month-display.adp
    • -7
    • +7
    /openacs-4/packages/calendar/www/view-month-display.tcl
6:11 pm

antoniop

Allow dt_get_info to return its results as a dict or a simple value, without settings a ton of variable in the caller scope that are difficult to track

Options
    • -5
    • +29
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
5:15 pm

antoniop

Deprecate leftover api

Options
    • -2
    • +2
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
5:14 pm

antoniop

Deprecate all remaining dt_widget_* api

The rationale is that modern HTML5 provides already consistent and localized UI elements for date and time input. It is also difficult to style a widget that comes pre-baked by the api. One should either use acs-templating or xowiki feature to generate UIs, or modern HTML5 is in most cases sufficient.

Options
    • -4
    • +22
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
    • -5
    • +30
    /openacs-4/packages/acs-datetime/tcl/acs-datetime-procs.tcl
    • -33
    • +1
    /openacs-4/packages/acs-datetime/www/doc/design.adp
    • -42
    • +9
    /openacs-4/packages/acs-datetime/www/doc/design.html
    • -37
    • +0
    /openacs-4/packages/acs-datetime/www/doc/examples/calendar-widgets.adp
    • -40
    • +0
    /openacs-4/packages/acs-datetime/www/doc/examples/calendar-widgets.tcl
    • -53
    • +0
    /openacs-4/packages/acs-datetime/www/doc/examples/datetime-widgets.adp
    • -52
    • +0
    /openacs-4/packages/acs-datetime/www/doc/examples/datetime-widgets.tcl
    • -5
    • +1
    /openacs-4/packages/acs-datetime/www/doc/examples/index.adp
4:50 pm

antoniop

Replace deprecated api

Options
    • -11
    • +10
    /openacs-4/packages/dotlrn/www/weblog-new.tcl
4:41 pm

antoniop

Prevent Javascript in the comment content

Note that this check is additional to that coming from e.g. allowed tags or similar

Options
    • -1
    • +18
    /openacs-4/packages/general-comments/www/comment-add-2.tcl
    • -1
    • +18
    /openacs-4/packages/general-comments/www/comment-edit-2.tcl
4:24 pm

antoniop

Do not allow markup in the portlet name

Options
    • -3
    • +6
    /openacs-4/packages/static-portlet/www/element.tcl
4:22 pm

antoniop

Localize error message

Options
    • -3
    • +8
    /openacs-4/packages/acs-templating/tcl/data-procs.tcl
4:13 pm

antoniop

Use a better regexp to reimplement ad_looks_like_html_p, use the improved api to port downstream feature: an ad_form datatype validator that won't allow to insert markup

Many thanks to Günter Ernst

Options
    • -6
    • +2
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -1
    • +20
    /openacs-4/packages/acs-templating/tcl/data-procs.tcl