• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- simplify logic; set message(screen_name) always

- flatten nested lindex-structures

- use single "lassign" instead of multiple "lindex" operations

    • -2
    • +2
    ./packages/acs-templating/tcl/parse-procs.tcl
    • -4
    • +4
    ./packages/acs-templating/tcl/widget-procs.tcl
- brace expressions

- factor out groupby tests

    • -25
    • +28
    ./packages/acs-templating/tcl/list-procs.tcl
- avoid setting one-use variables for frequently called code

- fold multiple upvars to a single one

- make indentation more regular

- fix one case of double dollar

    • -103
    • +87
    ./packages/acs-templating/tcl/form-procs.tcl
- normalize string expressions

    • -2
    • +2
    ./packages/acs-tcl/tcl/xml-1-dom-procs.tcl
- normalize string expressions

    • -3
    • +3
    ./packages/acs-templating/tcl/data-procs.tcl
    • -5
    • +5
    ./packages/acs-templating/tcl/date-procs.tcl
    • -2
    • +2
    ./packages/acs-templating/tcl/filter-procs.tcl
    • -7
    • +7
    ./packages/acs-templating/tcl/form-procs.tcl
    • -22
    • +22
    ./packages/acs-templating/tcl/list-procs.tcl
    • -4
    • +4
    ./packages/acs-templating/tcl/widget-procs.tcl
- use numeric comparison for truth values

    • -4
    • +4
    ./packages/acs-subsite/tcl/attribute-procs.tcl
    • -3
    • +3
    ./packages/acs-subsite/tcl/package-procs.tcl
    • -2
    • +2
    ./packages/acs-subsite/tcl/rel-types-procs.tcl
    • -3
    • +3
    ./packages/acs-subsite/www/admin/groups/new.tcl
    • -3
    • +3
    ./packages/acs-subsite/www/admin/parties/new.tcl
    • -4
    • +4
    ./packages/acs-subsite/www/admin/users/new.tcl
    • -3
    • +3
    ./packages/acs-subsite/www/permissions/one.tcl
    • -3
    • +3
    ./packages/acs-subsite/www/pvt/alerts.tcl
    • -5
    • +5
    ./packages/acs-subsite/www/site-map/index.tcl
- use numeric comparison for truth value comparison

    • -3
    • +3
    ./packages/forums/lib/message/thread-chunk.tcl
    • -2
    • +2
    ./packages/forums/www/message-view.tcl
- get screen name only when requested

- brace while expressions

- don't use expr within while expression

- use numeric comparison for truth values

- normalize string expressions

    • -2
    • +2
    ./packages/acs-tcl/tcl/admin-procs.tcl
    • -2
    • +2
    ./packages/acs-tcl/tcl/aolserver-3-procs.tcl
    • -2
    • +2
    ./packages/acs-tcl/tcl/apm-install-procs.tcl
    • -10
    • +10
    ./packages/acs-tcl/tcl/security-procs.tcl
    • -2
    • +2
    ./packages/acs-tcl/tcl/site-nodes-procs.tcl
    • -5
    • +5
    ./packages/acs-tcl/tcl/table-display-procs.tcl
    • -30
    • +30
    ./packages/acs-tcl/tcl/utilities-procs.tcl
    • -2
    • +2
    ./packages/acs-tcl/tcl/xml-0-sgml-procs.tcl
    • -2
    • +2
    ./packages/acs-tcl/tcl/xml-1-dom-procs.tcl
- use per-thread caching for security::driver and ad_server_modules

    • -6
    • +14
    ./packages/acs-tcl/tcl/security-procs.tcl
- new functions security::driver and ad_server_modules to simplify

redundant logic for determining secure drivers

    • -32
    • +47
    ./packages/acs-tcl/tcl/security-procs.tcl
- added author for blaming

    • -1
    • +3
    ./packages/acs-tcl/tcl/utilities-procs.tcl
- ad_job: Added convenience wrapper for simple usages of ns_job with timeout

    • -1
    • +33
    ./packages/acs-tcl/tcl/utilities-procs.tcl
- no need to write ad_quoted to error.log

    • -2
    • +2
    ./packages/acs-admin/tcl/apm-admin-procs.tcl
- remove temp files from apm generator

    • -1
    • +2
    ./packages/acs-admin/tcl/apm-admin-procs.tcl
fixes for download-zip:

- require login for zip-downloads (keep away spiders)

- return "not found" on if ids are no acs-objects

- clean temp-files on errors

    • -2
    • +13
    ./packages/file-storage/www/download-zip.tcl
Logging information about the system's encoding while booting.

- remove default value from ns_config, otherwise the function determines 443 also for non-configured ssl

    • -2
    • +2
    ./packages/acs-tcl/tcl/security-procs.tcl
- fix uninitialized variable

    • -4
    • +5
    ./packages/acs-tcl/tcl/security-procs.tcl
- try to simplify logic to determine drivers

- dropped nsunix

- use string ops instead of regexp

    • -72
    • +59
    ./packages/acs-tcl/tcl/security-procs.tcl
- remove .css

    • -3
    • +3
    ./packages/acs-subsite/www/doc/image-doc.tcl
    • -2
    • +0
    ./packages/acs-subsite/www/doc/images.html
- update images.html + add generator script

    • -0
    • +26
    ./packages/acs-subsite/www/doc/image-doc.tcl
    • -61
    • +66
    ./packages/acs-subsite/www/doc/images.html
file image-doc.tcl was initially added on branch oacs-5-8.

    • -0
    • +0
    ./packages/acs-subsite/www/doc/image-doc.tcl
- deprecated oacs::user::get as suggested by Roberto Mello; acs_user::get is significantly faster

- replace deprecated oacs::user::get by acs_user::get

    • -1
    • +1
    ./packages/forums/www/user-history.adp
    • -2
    • +2
    ./packages/forums/www/user-history.tcl
- avoid unneeded eval for better bytecode compilation

    • -11
    • +5
    ./packages/acs-templating/tcl/parse-procs.tcl
- make ad_return deprecated; maybe this function was useful for ancient versions of tcl, but as it is, it does not make sense (see comment in code)

- fix call to ad_return_complaint

- standardize setting of variable ::template::parse_level

    • -3
    • +2
    ./packages/xowiki/tcl/template-procs.tcl
    • -4
    • +4
    ./packages/xowiki/tcl/xowiki-www-procs.tcl
- siumplify setting of head-variables

    • -19
    • +12
    ./packages/acs-templating/tcl/head-procs.tcl