• last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Use consistently ad_script_abort after ad_return_error.

    • -0
    • +1
    ./acs-tcl/tcl/form-processing-procs.tcl
Use consistently ad_script_abort after ad_return_warning

    • -6
    • +8
    ./acs-api-browser/www/content-page-view.tcl
    • -7
    • +14
    ./acs-api-browser/www/display-sql.tcl
    • -6
    • +8
    ./acs-api-browser/www/procs-file-view.tcl
use consistently ad_script_abort after ad_return_forbidden

    • -6
    • +4
    ./dotlrn/www/admin/site-wide-admin-toggle.tcl
    • -59
    • +53
    ./dotlrn-portlet/tcl/dotlrn-portlet-procs.tcl
User consistently ad_script_abort adter ad_returnredirect

    • -1
    • +8
    ./dotlrn-admin/www/admin/add-instructor-3.tcl
    • -2
    • +8
    ./dotlrn-admin/www/admin/browse-toggle.tcl
    • -3
    • +3
    ./dotlrn-admin/www/admin/guest-toggle.tcl
    • -5
    • +13
    ./dotlrn-admin/www/admin/password-update-2.tcl
    • -0
    • +9
    ./dotlrn-admin/www/admin/unarchive.tcl
Use consistently ad_script_abort after ad_return_error.

    • -1
    • +2
    ./acs-admin/www/apm/parameter-edit-2.tcl
    • -4
    • +5
    ./acs-admin/www/users/member-state-change.tcl
    • -3
    • +2
    ./acs-admin/www/users/user-batch-add-2.tcl
    • -3
    • +3
    ./dotlrn/www/admin/community-members-add-to-community.tcl
  1. … 19 more files in changeset.
Use consistently ad_script_abort after ad_return_error.

Break long lines

    • -3
    • +5
    ./acs-subsite/www/admin/group-types/delete.tcl
    • -3
    • +5
    ./acs-subsite/www/admin/rel-segments/one.tcl
    • -3
    • +5
    ./acs-subsite/www/admin/rel-types/one.tcl
  1. … 10 more files in changeset.
remove unneeded "ns_conn close" operations (connections are already closed by prior commands).

    • -3
    • +1
    ./acs-tcl/tcl/request-processor-procs.tcl
Make termination after connection closing commands explicit

remove obsolete files

    • -17
    • +0
    ./acs-tcl/tcl/set-operation-procs.tcl
    • -12
    • +0
    ./acs-tcl/tcl/table-display-procs.tcl
rename deprecated-utility-procs.xql to deprecated-procs.xql

    • -0
    • +18
    ./acs-tcl/tcl/deprecated-procs.xql
    • -18
    • +0
    ./acs-tcl/tcl/deprecated-utilities-procs.xql
Make termination after connection closing commands explicit

    • -2
    • +3
    ./simple-survey/www/admin/edit-logic.tcl
    • -1
    • +2
    ./simple-survey/www/admin/modify-responses.tcl
    • -2
    • +2
    ./simple-survey/www/admin/question-delete.tcl
Fix boolean expressions in .adp files, make termination after connection closing commands explicit

Fix boolean expressions in .adp files

    • -6
    • +6
    ./assessment-portlet/www/assessment-portlet.tcl
Add compatibility for Tcl 8.5

Make termination after connection closing commands explicit

    • -1
    • +2
    ./schema-browser/www/column-comments.tcl
Fix boolean expressions in -adp files, make termination after connection closing commands explicit

    • -2
    • +3
    ./forums/lib/message/attachment-list.tcl
    • -1
    • +2
    ./general-comments/www/comment-edit.tcl
    • -1
    • +2
    ./general-comments/www/file-download.tcl
  1. … 4 more files in changeset.
add ad_script_abort after connection-closing commands to make termination intent explicit

    • -2
    • +2
    ./download/www/admin/approve-or-reject-2.tcl
    • -4
    • +10
    ./download/www/admin/export-csv.tcl
    • -1
    • +2
    ./download/www/admin/repository-types-delete.tcl
    • -2
    • +2
    ./edit-this-page/templates/news-index.adp
    • -1
    • +2
    ./edit-this-page/www/etp-install-portlet.tcl
    • -0
    • +2
    ./edit-this-page/www/etp-subtopic-create.tcl
  1. … 17 more files in changeset.
add ad_script_abort after ad_returnredirect to make termination intent explicit

    • -6
    • +3
    ./assessment/www/admin/asm-action-delete.tcl
    • -1
    • +2
    ./assessment/www/admin/asm-action-new.tcl
    • -0
    • +2
    ./assessment/www/admin/set-reg-assessment.tcl
  1. … 19 more files in changeset.
add ad_script_abort after ad_returnredirect to make termination intent explicit

    • -1
    • +2
    ./acs-admin/www/apm/version-generate-info.tcl
    • -1
    • +2
    ./acs-admin/www/users/session-history.tcl
    • -1
    • +2
    ./acs-admin/www/users/sessions-one-month.tcl
    • -1
    • +2
    ./acs-automated-testing/www/admin/init-file-resource.tcl
    • -0
    • +2
    ./acs-bootstrap-installer/installer.tcl
    • -0
    • +1
    ./acs-lang/www/admin/message-conflict-revert.tcl
  1. … 8 more files in changeset.
make loading of deprecated code optional

remove deprecated-utility-procs (was moved into deprecated-procs.tcl

    • -247
    • +0
    ./acs-tcl/tcl/deprecated-utilities-procs.tcl
Move deprecated procs into deprecated-procs.tcl

    • -18
    • +1
    ./acs-tcl/tcl/00-database-procs.tcl
    • -18
    • +1
    ./acs-tcl/tcl/community-core-2-procs.tcl
    • -95
    • +1
    ./acs-tcl/tcl/community-core-procs.tcl
    • -1
    • +2056
    ./acs-tcl/tcl/deprecated-procs.tcl
    • -504
    • +0
    ./acs-tcl/tcl/http-client-procs.tcl
    • -135
    • +1
    ./acs-tcl/tcl/set-operation-procs.tcl
    • -886
    • +1
    ./acs-tcl/tcl/table-display-procs.tcl
add ad_script_abort

    • -1
    • +134
    ./acs-tcl/tcl/deprecated-procs.tcl
    • -133
    • +1
    ./acs-tcl/tcl/document-procs.tcl
add comment

Whitespace changes and improve spelling

    • -162
    • +162
    ./acs-tcl/tcl/memoize-procs.tcl
quoting in log-file not needed

whitespace changes

Don't hard-code the SiteNodeCache sizes in the library file and bump version number

Backport from HEAD

Don't hard-code the SiteNodeCache sizes in the library file,

but allow configuration via the config-file.

Example:

#

# Provide tailored sizes for the site node cache in acs-tcl:

#

ns_section ns/server/${server}/acs/acs-tcl

ns_param SiteNodesCacheSize 2000000

ns_param SiteNodesIdCacheSize 100000

ns_param SiteNodesChildenCacheSize 100000

#

    • -11
    • +28
    ./acs-tcl/tcl/site-nodes-procs.tcl
add ad_script_abort after ad_returnredirect to make termination intent explicit

    • -2
    • +2
    ./categories/www/cadmin/category-link-add-2.tcl
    • -0
    • +1
    ./categories/www/cadmin/category-link-add-3.tcl
    • -0
    • +1
    ./categories/www/cadmin/category-link-add-4.tcl
    • -1
    • +1
    ./categories/www/cadmin/category-links-view.tcl
    • -4
    • +4
    ./categories/www/cadmin/object-map.tcl
    • -0
    • +1
    ./categories/www/cadmin/one-object.tcl
  1. … 6 more files in changeset.