OpenACS / openacs-4 / packages / xotcl-core / tcl

05-db-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 02 May
Commits this week: 0
Total Lines of Code (LoC): 2,826
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 19 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 16 Jan 2023
5:23 pm

antoniop

Do not enforce that body is a list

Options
    • -2
    • +2
    ./05-db-procs.tcl
3:42 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./05-db-procs.tcl
3:40 pm

antoniop

Performance improvements:

- set variables from the ns_set and extended variables separately

- collect the values and append to the multirow in one sweep

- when no code body is there, just bulk append the values

This appears to be ~5% faster than db_multirow when both are invoked with a code body and ~30% faster when invoked without (with no prepared statements)

Options
    • -20
    • +36
    ./05-db-procs.tcl
12:30 pm

antoniop

Simplify idiom

Options
    • -2
    • +2
    ./05-db-procs.tcl
11:52 am

antoniop

Fix behavior of continue in the multirow code block, make the generic fallback behave the same as the postgres version with respect to appending

Options
    • -3
    • +3
    ./05-db-procs.tcl
Friday 13 Jan 2023
6:21 pm

antoniop

Cleanup leftover line

Options
    • -2
    • +1
    ./05-db-procs.tcl
6:16 pm

antoniop

Provide an ::xo::dc api to generate multirows

Notable differences with the classical db_multirow:

- a multirow will always be appended when it already exists. The constraint that the two multirows must have the same columns remains.

- no "if_no_rows_code_block"

- no unclobber

- no subst, do it yourself :-)

- no cache stuff

- support for prepared statements

The remaining behavior has been kept the same, e.g. variables will always be reset to empty string, even if they existed outside of the code block. Compatibility has been checked with knowns idiosyncrasies.

Options
    • -1
    • +116
    ./05-db-procs.tcl
Monday 09 Jan 2023
6:11 pm

antoniop

Provide, as for other interfaces, a Postgres implementation of database foreach that will support prepared statements won't just wrap the db_* api

Options
    • -0
    • +39
    ./05-db-procs.tcl
5:51 pm

antoniop

Make sure the original SQL stays unchanged, as it is used e.g. in the nsv storing the statement and in log messages

Options
    • -6
    • +6
    ./05-db-procs.tcl
11:53 am

antoniop

Improve the approach with strings containing colons in prepared SQL statements:

we first normalize all strings with a safe placeholder, substitute the variables, then put the strings back in place.

Options
    • -2
    • +19
    ./05-db-procs.tcl
Thursday 05 Jan 2023
5:50 pm

antoniop

Improve the regexp detecting variables in a prepared statement, so that a prepared variable must not be preceded by a semicolon (as before), but also by any character allowed for a variable name

Options
    • -2
    • +2
    ./05-db-procs.tcl
Wednesday 04 Jan 2023
12:34 pm

antoniop

Allow to prepare a statement with no parameters (See https://www.postgresql.org/docs/11/sql-prepare.html)

Options
    • -3
    • +11
    ./05-db-procs.tcl
Monday 12 Sep 2022
3:09 pm

antoniop

Add doc to public api

Options
    • -2
    • +11
    ./05-db-procs.tcl
  2. … 1 more file in changeset.
Monday 22 Aug 2022
7:06 pm

gustafn

new proc "ad_log_deprecated": unified interface for logging deprecated usages

The existing code used a larger variety of different messages to

denote invocations of deprecated procs and other

artifacts. "ad_log_deprecated" provides a unified interface, and

provides a usage hint what to use instead based on the API-doc

definitions in the log-file.

Options
    • -3
    • +3
    ./05-db-procs.tcl
  2. … 11 more files in changeset.
Wednesday 30 Mar 2022
3:45 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./05-db-procs.tcl
Tuesday 29 Mar 2022
6:12 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./05-db-procs.tcl
6:07 pm

antoniop

Make ::xo::db::require package a shorthand for ::xo::library require, which will remember the dependency

This will also make sure that dependent files are reloaded when a dependency is reloaded

Options
    • -11
    • +6
    ./05-db-procs.tcl
Tuesday 15 Mar 2022
1:01 pm

gustafn

prefer global variable over proc

Options
    • -2
    • +2
    ./05-db-procs.tcl
  2. … 6 more files in changeset.
Tuesday 08 Mar 2022
9:56 am

gustafn

improve comment

Options
    • -4
    • +3
    ./05-db-procs.tcl
Wednesday 23 Feb 2022
7:40 pm

gustafn

Prefer "::acs::dc call ..." over "::xo::db::sql::..."

Use the common new acs interface rather than the xotcl-core variant.

Goal should be on the medium time range to replace all of the

"::xo::db::sql::*" interface.

Options
    • -123
    • +136
    ./05-db-procs.tcl
  2. … 2 more files in changeset.
Sunday 20 Feb 2022
6:24 pm

gustafn

Fixes for Oracle 19c: boolean and timestamp handling, *lobs

- fix boolean permission query

- function "now()" does not exist, use "CURRENT_TIMESTAMP" instead

- revived blob and clob handling in "xo::dc dml" since this is needed

for updating

- modernize Oracle offset/limit handling

- added missing "-dbn" attributes for Oracle xo::dc calls

Options
    • -14
    • +14
    ./05-db-procs.tcl
  2. … 2 more files in changeset.
Thursday 17 Feb 2022
11:37 am

gustafn

Fixes for Oracle 19c: consistenly rely on uppercasing of the schema names in the called functions

Options
    • -16
    • +4
    ./05-db-procs.tcl
Wednesday 16 Feb 2022
8:22 pm

gustafn

Fixes for Oracle 19c:

- added special rules for DML differences in Oracle ("MODIFY" option in ALTER TABLE)

- fixed call of ns_pg_bind in Oracle applications

- fixed call of an SQL function returning a table

Options
    • -6
    • +43
    ./05-db-procs.tcl
Saturday 05 Feb 2022
5:59 pm

gustafn

Improved startup time (of server, of threads) by using nsv_dict when available

During definition of attributes, the xo-db inteface checks whether

the db attributes managed by xotcl are in sync with the actual database.

This was done so far by a couple of small database query. When nsv_dict

is available, it can be used for quickly checking those values.

Options
    • -12
    • +52
    ./05-db-procs.tcl
Saturday 22 Jan 2022
12:33 pm

gustafn

make function private

Options
    • -2
    • +2
    ./05-db-procs.tcl
Thursday 13 Jan 2022
1:36 pm

gustafn

improved prepared-statement handling

- avoid separate SQL statement for testing, whether prepared statement

exists already in the SQL session.

- use true SQL session-id (obtained via "ns_pg pid") when available

- improve source code documentation

Options
    • -25
    • +50
    ./05-db-procs.tcl
Sunday 26 Dec 2021
7:24 am

gustafn

deactive callback definition to avoid calls of deprecated xo::parameter functions

Options
    • -1
    • +2
    ./05-db-procs.tcl
  2. … 1 more file in changeset.
Sunday 05 Dec 2021
5:18 pm

gustafn

modernize code

Options
    • -9
    • +6
    ./05-db-procs.tcl
Tuesday 07 Sep 2021
7:51 pm

gustafn

simplify code (allow warning, although i am not fully convinced, this is a good idea)

Options
    • -2
    • +1
    ./05-db-procs.tcl
  2. … 1 more file in changeset.
7:35 pm

gustafn

move documentation to the generic level, don't make methods public, which are intentionally non-public

Options
    • -5
    • +7
    ./05-db-procs.tcl