• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Patches to make OpenACS PG 7.3 compatible.

  1. … 53 more files in changeset.
adding package version information to message catalog files

    • -1
    • +1
    ./catalog/notifications.en_US.ISO-8859-1.xml
  1. … 42 more files in changeset.
Made the queries match the working PG queries

Some semicolons snuck in from my test .sql files

Improved test scripts slightly.

file test-cleanup.tcl was initially added on branch oacs-4-6.

file test.adp was initially added on branch oacs-4-6.

The never ending attempt to fix notifications ...

    • -29
    • +20
    ./tcl/sweep-procs-postgresql.xql
Added files to implement the "change frequency" functionality

    • -0
    • +17
    ./www/request-change-frequency-oracle.xql
    • -0
    • +17
    ./www/request-change-frequency-postgresql.xql
file request-change-frequency-oracle.xql was initially added on branch oacs-4-6.

    • -0
    • +0
    ./www/request-change-frequency-oracle.xql
file request-change-frequency.xql was initially added on branch oacs-4-6.

    • -0
    • +0
    ./www/request-change-frequency.xql
file request-change-frequency.tcl was initially added on branch oacs-4-6.

    • -0
    • +0
    ./www/request-change-frequency.tcl
file request-change-frequency.adp was initially added on branch oacs-4-6.

    • -0
    • +0
    ./www/request-change-frequency.adp
file request-change-frequency-postgresql.xql was initially added on branch oacs-4-6.

    • -0
    • +0
    ./www/request-change-frequency-postgresql.xql
rollback peterm's change as donb is adding these files

there are no www/request-change-frequencey files so I removed them from the info file

1. Changed the manage page to use acs_object.name rather than do its own

special case checking (Oracle)

2. Added code from ssv2 to allow a user to change their notification

frequency without deleting and adding the notification

3. Changed form-driven pages to use ad_form

sync info files with package data and correct provides identifiers

  1. … 36 more files in changeset.
1. Changed cleanup sweep interval to 15 minutes

2. Fixed broken PostgreSQL and Oracle queries that were supposed to select

notifications for deletion but rather returned all notifications if any

were ripe for deletion, causing seemingly random failure to deliver

notifications. Sloan had hacked this with a kludge to only delete

notifications older than two days but this didn't work on openacs.org,

which supports weekly summaries of notifications.

3. Changed notification::new to not insert notifications that have no

pending requests. This avoids having to waste time deleting them

afterwards.

4. Added notification_request::request_exists which returns true if

there's at least one notification request for a given object and

notification type.

5. Added a couple of indexes to speed queries that ran slow on openacs.org.

    • -1
    • +3
    ./sql/oracle/notifications-core-create.sql
    • -3
    • +19
    ./tcl/notification-display-procs.tcl
    • -1
    • +10
    ./tcl/notification-request-procs.tcl
    • -15
    • +15
    ./tcl/sweep-procs-postgresql.xql
merge from oacs-4-6

    • -3
    • +10
    ./tcl/notification-display-procs.tcl
    • -5
    • +12
    ./tcl/notification-request-procs.tcl
    • -2
    • +14
    ./tcl/notifications-security-procs.tcl
  1. … 90 more files in changeset.
add redirect to manage as index page bug 1951

file index.tcl was initially added on branch oacs-4-6.

I18N: converting the notifications package to using the message catalog

    • -0
    • +25
    ./catalog/notifications.en_US.ISO-8859-1.xml
back out Bens changes per bug 3

added notifications documentation!

    • -3
    • +10
    ./tcl/notification-display-procs.tcl
    • -5
    • +12
    ./tcl/notification-request-procs.tcl
    • -2
    • +14
    ./tcl/notifications-security-procs.tcl
apm_package_url_from_key returns url with leading and trailing slashes

Fixed the EmailDomain, so it doesn't default to openacs.org. Instead, I've changed address_domain so that if there's no domain specified here, we do a regexp on [ad_url] to find out what the domain likely is.

Added new files to .info files

  1. … 38 more files in changeset.
reply_address: Use a reasonable sender email address even if there's no object_id or type_id.

typo in query name, default to disallow mail

    • -2
    • +2
    ./tcl/notifications-security-procs.tcl
    • -1
    • +1
    ./tcl/notifications-security-procs.xql