OpenACS / openacs-4 / packages

notifications

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 44
Last Commit: 28 Dec 24
Commits this week: 0
Total Lines of Code (LoC): 10,059
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 11 Dec 2002
3:13 am

donb

1. Changed the manage page to use acs_object.name rather than do its own

special case checking (Oracle)

2. Added code from ssv2 to allow a user to change their notification

frequency without deleting and adding the notification

3. Changed form-driven pages to use ad_form

Options
    • -9
    • +14
    ./notifications.info
    • -15
    • +1
    ./www/manage-oracle.xql
    • -1
    • +1
    ./www/manage-postgresql.xql
    • -2
    • +2
    ./www/manage.adp
    • -2
    • +3
    ./www/manage.tcl
    • -1
    • +1
    ./www/request-delete.tcl
    • -1
    • +1
    ./www/request-new-2.tcl
    • -25
    • +11
    ./www/request-new.tcl
Monday 09 Dec 2002
3:29 pm

jeffd

sync info files with package data and correct provides identifiers

Options
    • -1
    • +1
    ./notifications.info
  2. … 36 more files in changeset.
Friday 06 Dec 2002
10:03 pm

donb

1. Changed cleanup sweep interval to 15 minutes

2. Fixed broken PostgreSQL and Oracle queries that were supposed to select

notifications for deletion but rather returned all notifications if any

were ripe for deletion, causing seemingly random failure to deliver

notifications. Sloan had hacked this with a kludge to only delete

notifications older than two days but this didn't work on openacs.org,

which supports weekly summaries of notifications.

3. Changed notification::new to not insert notifications that have no

pending requests. This avoids having to waste time deleting them

afterwards.

4. Added notification_request::request_exists which returns true if

there's at least one notification request for a given object and

notification type.

5. Added a couple of indexes to speed queries that ran slow on openacs.org.

Options
    • -1
    • +3
    ./sql/oracle/notifications-core-create.sql
    • -3
    • +5
    ./sql/postgresql/notifications-core-create.sql
    • -3
    • +19
    ./tcl/notification-display-procs.tcl
    • -10
    • +10
    ./tcl/notification-procs.tcl
    • -1
    • +10
    ./tcl/notification-request-procs.tcl
    • -0
    • +9
    ./tcl/notification-request-procs.xql
    • -5
    • +13
    ./tcl/sweep-init.tcl
    • -17
    • +16
    ./tcl/sweep-procs-oracle.xql
    • -15
    • +15
    ./tcl/sweep-procs-postgresql.xql
    • -11
    • +12
    ./tcl/sweep-procs.tcl
Saturday 30 Nov 2002
6:32 pm

jeffd

merge from oacs-4-6

Options
    • -1
    • +1
    ./notifications.info
    • -3
    • +17
    ./tcl/delivery-method-procs.tcl
    • -2
    • +7
    ./tcl/interval-procs.tcl
    • -3
    • +10
    ./tcl/notification-display-procs.tcl
    • -3
    • +11
    ./tcl/notification-email-procs.tcl
    • -1
    • +28
    ./tcl/notification-procs.tcl
    • -5
    • +8
    ./tcl/notification-reply-procs.tcl
    • -5
    • +12
    ./tcl/notification-request-procs.tcl
    • -2
    • +33
    ./tcl/notification-type-procs.tcl
    • -2
    • +14
    ./tcl/notifications-security-procs.tcl
    • -4
    • +6
    ./tcl/reply-sweep-procs.tcl
    • -3
    • +4
    ./tcl/sweep-procs.tcl
    • -0
    • +1
    ./www/index.tcl
    • -22
    • +2
    ./www/manage-postgresql.xql
  15. … 90 more files in changeset.
Thursday 21 Nov 2002
12:07 am

jeffd

add redirect to manage as index page bug 1951

Options
    • -0
    • +1
    ./www/index.tcl
    • -22
    • +2
    ./www/manage-postgresql.xql
12:07 am

jeffd

file index.tcl was initially added on branch oacs-4-6.

Options
    • -0
    • +0
    ./www/index.tcl
Friday 08 Nov 2002
11:04 am

peterm

I18N: converting the notifications package to using the message catalog

Options
    • -0
    • +25
    ./catalog/notifications.en_US.ISO-8859-1.xml
    • -3
    • +3
    ./tcl/notification-display-procs.tcl
    • -3
    • +5
    ./tcl/notification-email-procs.tcl
    • -3
    • +5
    ./tcl/sweep-procs.tcl
    • -8
    • +9
    ./www/manage.adp
    • -9
    • +9
    ./www/request-new.tcl
Friday 01 Nov 2002
7:48 pm

jeffd

back out Bens changes per bug 3

Options
    • -28
    • +4
    ./tcl/notification-email-procs.tcl
Wednesday 30 Oct 2002
10:12 pm

ben

added notifications documentation!

Options
    • -3
    • +17
    ./tcl/delivery-method-procs.tcl
    • -2
    • +7
    ./tcl/interval-procs.tcl
    • -3
    • +10
    ./tcl/notification-display-procs.tcl
    • -4
    • +28
    ./tcl/notification-email-procs.tcl
    • -1
    • +28
    ./tcl/notification-procs.tcl
    • -5
    • +8
    ./tcl/notification-reply-procs.tcl
    • -5
    • +12
    ./tcl/notification-request-procs.tcl
    • -2
    • +33
    ./tcl/notification-type-procs.tcl
    • -2
    • +14
    ./tcl/notifications-security-procs.tcl
    • -4
    • +6
    ./tcl/reply-sweep-procs.tcl
    • -3
    • +4
    ./tcl/sweep-procs.tcl
Monday 21 Oct 2002
2:39 pm

jeffd

apm_package_url_from_key returns url with leading and trailing slashes

Options
    • -2
    • +2
    ./tcl/notification-email-procs.tcl
Monday 14 Oct 2002
12:31 pm

lars

Fixed the EmailDomain, so it doesn't default to openacs.org. Instead, I've changed address_domain so that if there's no domain specified here, we do a regexp on [ad_url] to find out what the domain likely is.

Options
    • -1
    • +1
    ./notifications.info
    • -2
    • +10
    ./tcl/notification-email-procs.tcl
Tuesday 24 Sep 2002
1:31 am

jeffd

Added new files to .info files

Options
    • -0
    • +7
    ./notifications.info
  2. … 38 more files in changeset.
Sunday 22 Sep 2002
5:49 pm

lars

reply_address: Use a reasonable sender email address even if there's no object_id or type_id.

Options
    • -2
    • +2
    ./tcl/notification-email-procs.tcl
Saturday 21 Sep 2002
1:17 am

jeffd

typo in query name, default to disallow mail

Options
    • -2
    • +2
    ./tcl/notifications-security-procs.tcl
    • -1
    • +1
    ./tcl/notifications-security-procs.xql
Friday 20 Sep 2002
11:18 pm

jeffd

Fixes from sloan

* Increase field sizes for subject

* adds a manage page

* adds a object_id redirect (object-goto.tcl)

* linking to manage page in outgoing message.

Options
    • -2
    • +2
    ./sql/oracle/notifications-core-create.sql
    • -2
    • +2
    ./sql/postgresql/notifications-core-create.sql
    • -1
    • +7
    ./tcl/delivery-method-procs.tcl
    • -2
    • +8
    ./tcl/notification-email-procs.tcl
    • -2
    • +3
    ./tcl/notification-procs-oracle.xql
    • -2
    • +3
    ./tcl/notification-procs-postgresql.xql
    • -3
    • +15
    ./tcl/notifications-security-procs.tcl
    • -0
    • +14
    ./tcl/notifications-security-procs.xql
    • -3
    • +3
    ./tcl/sweep-procs-oracle.xql
    • -3
    • +3
    ./tcl/sweep-procs-postgresql.xql
    • -3
    • +3
    ./tcl/sweep-procs.tcl
    • -0
    • +39
    ./www/manage-oracle.xql
    • -0
    • +44
    ./www/manage-postgresql.xql
    • -0
    • +33
    ./www/manage.adp
    • -0
    • +15
    ./www/manage.tcl
    • -0
    • +23
    ./www/object-goto.tcl
9:32 am

jeffd

fixes bug 1731/patch 442 Tilman Singer

Options
    • -1
    • +2
    ./sql/postgresql/notifications-replies-package-create.sql
Monday 16 Sep 2002
2:36 pm

lars

Maybe redirect for registration.

Options
    • -2
    • +2
    ./www/request-new.tcl
Wednesday 11 Sep 2002
12:21 am

jeffd

cleanup javadoc tags (eg @cvs_id @cvs @cvs-id: instead if @cvs-id)

Options
    • -2
    • +3
    ./tcl/notification-email-procs.tcl
    • -3
    • +3
    ./tcl/reply-sweep-init.tcl
    • -3
    • +3
    ./tcl/sweep-init.tcl
    • -2
    • +2
    ./www/request-delete.tcl
    • -2
    • +2
    ./www/request-new-2.tcl
    • -2
    • +2
    ./www/request-new.tcl
  7. … 687 more files in changeset.
Friday 06 Sep 2002
11:49 pm

jeffd

remove superfluous package local masters and use sitewide master by default

Options
    • -9
    • +0
    ./www/master.adp
    • -1
    • +1
    ./www/request-new.adp
  3. … 700 more files in changeset.
Thursday 05 Sep 2002
1:13 pm

jeffd

move title and context out of page, propigate context

Options
    • -0
    • +6
    ./www/master.adp
    • -4
    • +1
    ./www/request-new.adp
    • -4
    • +8
    ./www/request-new.tcl
Monday 19 Aug 2002
10:38 pm

arjun

fixing

Options
    • -1
    • +13
    ./sql/postgresql/upgrade/upgrade-0.1d-0.2d.sql
10:37 pm

arjun

1. updated .info file with some missing files for PG

2. fixed the notification.delete func in both DBs

3. bumped pacakge version to 0.2d

Options
    • -2
    • +9
    ./notifications.info
    • -0
    • +2
    ./sql/oracle/notifications-package-create.sql
    • -0
    • +1
    ./sql/oracle/upgrade/upgrade-0.1d-0.2d.sql
    • -0
    • +1
    ./sql/postgresql/notifications-package-create.sql
    • -0
    • +1
    ./sql/postgresql/upgrade/upgrade-0.1d-0.2d.sql
Monday 12 Aug 2002
9:56 pm

arjun

removed parens from around select clause in for clause which barfs on pg 7.1. fix from davb

Options
    • -3
    • +3
    ./sql/postgresql/notifications-package-create.sql
Friday 09 Aug 2002
10:51 pm

yon

copyright OpenForce -> MIT

Options
    • -2
    • +2
    ./sql/oracle/delivery-method-sc-create.sql
    • -2
    • +2
    ./sql/oracle/email-sc-impl-create.sql
    • -2
    • +2
    ./sql/oracle/notification-type-sc-create.sql
    • -2
    • +2
    ./sql/oracle/notifications-core-create.sql
    • -2
    • +2
    ./sql/oracle/notifications-core-drop.sql
    • -2
    • +2
    ./sql/oracle/notifications-create.sql
    • -2
    • +2
    ./sql/oracle/notifications-init.sql
    • -1
    • +1
    ./sql/oracle/notifications-package-create.sql
    • -1
    • +1
    ./sql/oracle/notifications-package-drop.sql
    • -1
    • +1
    ./sql/oracle/notifications-replies-create.sql
    • -1
    • +1
    ./sql/oracle/notifications-replies-package-create.sql
    • -3
    • +3
    ./sql/postgresql/delivery-method-sc-create.sql
    • -2
    • +2
    ./sql/postgresql/email-sc-impl-create.sql
    • -2
    • +2
    ./sql/postgresql/notification-type-sc-create.sql
    • -2
    • +2
    ./sql/postgresql/notifications-core-create.sql
  16. … 99 more files in changeset.
Thursday 01 Aug 2002
4:26 pm

lars

Added header to the request-new page. Changed form id from 'request' to 'subscribe' to avoid clash with the form builder magic form id 'request'

Options
    • -3
    • +6
    ./www/request-new.adp
    • -13
    • +18
    ./www/request-new.tcl
2:57 pm

lars

I took the liberty to go ahead and implement this pretty_name addition to subscribe_url that I mentioned in the bboard thread.

Options
    • -3
    • +4
    ./tcl/notification-display-procs.tcl
2:56 pm

lars

The insert statement included a sysdate, yet it was in the common .xql file. I moved it out to the -oracle and -postgresql files and changed it to now() for postgresql.

Options
    • -0
    • +11
    ./tcl/notification-procs-oracle.xql
    • -0
    • +10
    ./tcl/notification-procs-postgresql.xql
    • -10
    • +0
    ./tcl/notification-procs.xql
2:55 pm

lars

Missing columns in query. These were in the Oracle query, and at least the delivery_method_id was expected, and caused failure down the line

Options
    • -0
    • +3
    ./tcl/sweep-procs-postgresql.xql
Sunday 21 Jul 2002
11:25 pm

chak

postgres port stuff

Options
    • -41
    • +41
    ./sql/postgresql/notifications-package-create.sql
    • -0
    • +6
    ./tcl/notification-request-procs-postgresql.xql
  3. … 6 more files in changeset.
Thursday 11 Jul 2002
6:53 am

yon

remove ad_system_name call from instant notification subject. left it in

batched notifications.

Options
    • -24
    • +23
    ./tcl/notification-email-procs.tcl
    • -2
    • +2
    ./tcl/sweep-procs.tcl