Activity OpenACS/openacs-4/packages/acs-templating

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	61
Last Commit:	17 May
Commits this week:	0
Total Lines of Code (LoC):	312,825
Net change in LoC this week:	0

Commit Activity

last updated 9 hours ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Monday 05 Sep 2022

5:07 pm

antoniop

Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

- -11
- +8
./tcl/list-procs.tcl
- History
- Source
- Diff
./tcl/list-procs.tcl
- -2
- +2
./tcl/parse-procs.tcl
- History
- Source
- Diff
./tcl/parse-procs.tcl
… 5 more files in changeset.

Friday 02 Sep 2022

4:15 pm

antoniop

Claim additional coverage

- -1
- +4
./tcl/test/parse-test-procs.tcl
- History
- Source
- Diff
./tcl/test/parse-test-procs.tcl

4:14 pm

antoniop

Count already exisring handlers before introducing new ones

- -4
- +11
./tcl/test/parse-test-procs.tcl
- History
- Source
- Diff
./tcl/test/parse-test-procs.tcl

3:18 pm

Improve acs::test::form_reply so that when the attributes of a file upload (*.tmpfile or *.content-type) are part of the update argument, it will switch automatically to a multipart request and implement a "real" file upload

This is important on newer NaviServer versions that will reject any *.tmpfile parameter in a request that was not produced internally after a file upload

- -31
- +0
./tcl/test/file-procs.tcl
- History
- Source
- Diff
./tcl/test/file-procs.tcl
… 1 more file in changeset.

10:46 am

antoniop

Test also nonce rendering

- -1
- +7
./tcl/test/parse-test-procs.tcl
- History
- Source
- Diff
./tcl/test/parse-test-procs.tcl

10:31 am

antoniop

Make test more precise

- -9
- +12
./tcl/test/parse-test-procs.tcl
- History
- Source
- Diff
./tcl/test/parse-test-procs.tcl

Thursday 01 Sep 2022

6:56 pm

antoniop

Test a bunch more api

- -1
- +146
./tcl/test/parse-test-procs.tcl
- History
- Source
- Diff
./tcl/test/parse-test-procs.tcl

6:19 pm

antoniop

Test template::adp_level, fix test coverage declaration

- -3
- +36
./tcl/test/parse-test-procs.tcl
- History
- Source
- Diff
./tcl/test/parse-test-procs.tcl

6:10 pm

antoniop

Test template::adp_parse_string

- -1
- +16
./tcl/test/parse-test-procs.tcl
- History
- Source
- Diff
./tcl/test/parse-test-procs.tcl

6:04 pm

antoniop

Deprecate template::adp_levels, found nowhere in the upstream codebase and superseded by template::adp_level

- -2
- +3
./tcl/parse-procs.tcl
- History
- Source
- Diff
./tcl/parse-procs.tcl

5:52 pm

antoniop

Increase proc coverage

- -39
- +62
./tcl/test/parse-test-procs.tcl
- History
- Source
- Diff
./tcl/test/parse-test-procs.tcl

5:32 pm

antoniop

State additional proc coverage, improve documentation

- -2
- +4
./tcl/parse-procs.tcl
- History
- Source
- Diff
./tcl/parse-procs.tcl
- -0
- +1
./tcl/test/file-procs.tcl
- History
- Source
- Diff
./tcl/test/file-procs.tcl
- -1
- +2
./tcl/test/parse-test-procs.tcl
- History
- Source
- Diff
./tcl/test/parse-test-procs.tcl

5:03 pm

antoniop

Make template::head::prepare_multirows a private interface: its stated purpose is to be used inside of the blank-master and it has no practical use otherwise

- -1
- +1
./tcl/head-procs.tcl
- History
- Source
- Diff
./tcl/head-procs.tcl

4:50 pm

antoniop

Make adp_parse_ad_conn_file a private interface: its stated purpose is to be registered via rp_register_extension_handler in acs-templating/tcl/acs-integration-init.tcl and it has no practical use otherwise

- -3
- +3
./tcl/acs-integration-procs.tcl
- History
- Source
- Diff
./tcl/acs-integration-procs.tcl

2:58 pm

antoniop

Test ad_return_template

- -5
- +76
./tcl/test/acs-integration-procs.tcl
- History
- Source
- Diff
./tcl/test/acs-integration-procs.tcl

Wednesday 31 Aug 2022

12:18 pm

antoniop

Test ad_return_exception_template

- -0
- +76
./tcl/test/acs-integration-procs.tcl
- History
- Source
- Diff
./tcl/test/acs-integration-procs.tcl

12:18 pm

antoniop

More
MAIN:antoniop:20220831101820
deleted 1 file
MAIN

file acs-integration-procs.tcl was initially added on branch oacs-5-10.

- -0
- +0
./tcl/test/acs-integration-procs.tcl
- History
- Source
./tcl/test/acs-integration-procs.tcl

Tuesday 30 Aug 2022

6:07 pm

antoniop

Test ad_dimensional_sql

- -0
- +45
./tcl/test/dimensional-procs.tcl
- History
- Source
- Diff
./tcl/test/dimensional-procs.tcl

5:53 pm

antoniop

Test ad_dimensional

- -0
- +69
./tcl/test/dimensional-procs.tcl
- History
- Source
- Diff
./tcl/test/dimensional-procs.tcl

5:53 pm

antoniop

More
MAIN:antoniop:20220830155350
deleted 1 file
MAIN

file dimensional-procs.tcl was initially added on branch oacs-5-10.

- -0
- +0
./tcl/test/dimensional-procs.tcl
- History
- Source
./tcl/test/dimensional-procs.tcl

11:38 am

antoniop

Fix typo

- -2
- +4
./tcl/element-procs.tcl
- History
- Source
- Diff
./tcl/element-procs.tcl

11:35 am

antoniop

template::element validation reform: do not run custom user-defined validation on fields that are not formally correct

Rationale: user-defined validation often assumes some basic consistency of the submitted value. When this is not formally correct, users might have to reimplement the whole formal validation in their custom fields in order to prevent exceptions. By preventing their custom blocks from being executed, users can rely on their custom fields to be run only against sane values.