• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- fixing a probably old bug: changed the markers in ad_text_to_html since the old markers with the funy camel case led to problems (at least with current regexp implementations)

in the text below, only 5 of the 8 urls were correctly transformed into anchor markup. The new markers uses uniqe single char starting and ending marker, marking also regexp much simpler.

- the function is further generalized (unifying http/https/ftp urls with mailto urls) and probably faster

A welcome contribution would be e.g. an extension of the api-browser for callbacks (listing contracts/implementations, etc.).

[1] http://openacs.org/api-doc/proc-view?proc=callback&source_p=1

[2] https://github.com/openacs/openacs-core/blob/oacs-5-9/packages/search/tcl/search-procs.tcl#L309

[3] https://github.com/openacs/forums/blob/master/tcl/forums-callback-procs.tcl#L104

[4] https://github.com/openacs/openacs-core/blob/oacs-5-9/packages/acs-tcl/tcl/apm-procs.tcl

[5] http://openacs.org/api-doc/proc-view?source_p=1&proc=apm_arg_names_for_callback_type

[6] https://github.com/openacs/xowiki/blob/oacs-5-9/tcl/xowiki-callback-procs.tcl

[7] https://github.com/openacs/openacs-core/blob/oacs-5-9/packages/acs-subsite/tcl/subsite-callback-procs.tcl#L69

[8] https://github.com/openacs/xotcl-core/blob/oacs-5-9/tcl/06-param-procs.tcl#L386

- fix variable name

- remove erroneous warnings

- reduce the number of regsub operations in ad_text_to_html

- improve/fix souce code comments

- protect against potential crashes in tdom, when invalid numeric entities occur in the text

- minor cleanup

- fix typo

- second place, where text conversion speed up by performing a single "string map" and not 70

- fix bug where numeric entities were always output literal

- speed up text conversion by performing a single "string map" and not 70

- increase robsutness of apm_package_installed_p_not_cached

- make ad_unquote capable to unquote ns_qutehtml

- fix test cases

  1. … 4 more files in changeset.
- prefer ns_quotehtml over ad_quotehtml

  1. … 36 more files in changeset.
- add editor hints to keep spaces/tabs in the furture more consistent

  1. … 754 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- remove quote

- simplify tcl

- fix for bug #3225: make sure the result list of ad_parse_html_attributes_upvar is a well-formed list

- Fix for bug #3222. Patches submitted by the bug-tracker with formatting "pre" could not be displayed. additionally removed "pre" formatting option on bug-tracker in HEAD, since it seems superfluous.

- use "lassign" instead of multiple "lindex" operations

  1. … 5 more files in changeset.
- flatten nested "lindex" structures

- merge multiple "lappend" operations

- use "lassign" instead of multiple "lindex" operations

- improve performance util_convert_line_breaks_to_html by reducing

number of regsub operations and more precise regular expressions

- use numeric comparison operator for truth value comparisons

- use "lassign" instead of multiple "lindex" operations

- reduce number of remaining "string equal" operations

  1. … 13 more files in changeset.
- don't use backslash in multiline expressions

- make long expressions more uniform and more readable

- use "in" or not in (ni) operator instead of lsearch

- brace expressions to allow for tcl compilation

- bump version number

  1. … 23 more files in changeset.
- use tcl 8.5 extended index format for "string range"

- modernize tcl

  1. … 6 more files in changeset.
- replace deprecated "philg_quote_double_quotes" by "ad_quotehtml"

  1. … 2 more files in changeset.
- reduce verbosity

- raise limit in html/text processing from 1000 to 3000 in "loop detection"

- improve performance by byte-code-compiling expressions

- use more tcl8.5 idioms

  1. … 2 more files in changeset.
- modernize tcl

- remove unneeded "expr" in side if-expressions

  1. … 13 more files in changeset.
- get rid of empty_string_p

  1. … 20 more files in changeset.
tighten protocol regexp - was matching any word immediately followed by : within a valid html attribute

- normalize string expressions

  1. … 3 more files in changeset.
Non-info file merge results, with conflicts resolved.

  1. … 203 more files in changeset.
Xpath query is not being interpreted as it supposed to ( maybe it is a tdom bug ).