OpenACS / openacs-4 / packages / acs-tcl / tcl

text-html-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 05 Apr
Commits this week: 0
Total Lines of Code (LoC): 2,455
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 19 Mar
11:47 am

antoniop

Untangle if logics

Options
    • -23
    • +30
    ./text-html-procs.tcl
11:46 am

antoniop

Reject URLs displaying multiple protocols

Options
    • -1
    • +27
    ./text-html-procs.tcl
Monday 18 Mar
2:13 pm

antoniop

Strenghten validation against smarter attempts to disguise the javascript: protocol

Options
    • -10
    • +17
    ./text-html-procs.tcl
Friday 16 Feb
12:38 pm

antoniop

Manually replace the ":" entity to prevent attempts at disguising "javascript:" links

Options
    • -1
    • +17
    ./text-html-procs.tcl
Monday 20 Nov 2023
4:04 pm

antoniop

When using ad_dom_sanitize_html to validate markup, treat failure to parse as a normal validation failure, rather than an error

Options
    • -3
    • +4
    ./text-html-procs.tcl
Thursday 06 Jul 2023
10:54 am

gustafn

reduce verbosity

Options
    • -4
    • +4
    ./text-html-procs.tcl
Thursday 23 Mar 2023
4:13 pm

antoniop

Use a better regexp to reimplement ad_looks_like_html_p, use the improved api to port downstream feature: an ad_form datatype validator that won't allow to insert markup

Many thanks to Günter Ernst

Options
    • -6
    • +2
    ./text-html-procs.tcl
  2. … 1 more file in changeset.
Tuesday 07 Feb 2023
1:46 pm

antoniop

Deprecate trivial wrappers for ad_html_text_convert

Options
    • -3
    • +11
    ./text-html-procs.tcl
  2. … 2 more files in changeset.
Thursday 22 Dec 2022
3:39 am

gustafn

improve robustness

Options
    • -3
    • +3
    ./text-html-procs.tcl
  2. … 1 more file in changeset.
Sunday 04 Dec 2022
12:36 pm

gustafn

make parsing more robust

Options
    • -2
    • +2
    ./text-html-procs.tcl
Friday 21 Oct 2022
1:30 pm

trenner

fix typo

Options
    • -2
    • +2
    ./text-html-procs.tcl
Thursday 29 Sep 2022
6:04 pm

gustafn

reduce verbosity

Options
    • -6
    • +6
    ./text-html-procs.tcl
  2. … 2 more files in changeset.
Monday 05 Sep 2022
5:07 pm

antoniop

Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

Options
    • -2
    • +2
    ./text-html-procs.tcl
  2. … 6 more files in changeset.
Thursday 01 Sep 2022
9:21 am

trenner

if truncate_len is provided we have to call util_close_html_tags for truncating the string

Options
    • -2
    • +2
    ./text-html-procs.tcl
Tuesday 30 Aug 2022
4:48 pm

antoniop

Rename proc according to convention enforced in acs-tcl: naming__proc_naming

Options
    • -5
    • +4
    ./text-html-procs.tcl
10:47 am

gustafn

comment tags, which are NOT supported by HTML5, allow "abbr" in enhanced text

Options
    • -3
    • +13
    ./text-html-procs.tcl
Monday 29 Aug 2022
5:15 pm

gustafn

Reduce verbosity

Options
    • -8
    • +2
    ./text-html-procs.tcl
3:35 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./text-html-procs.tcl
3:02 pm

gustafn

implemented ad_html_security_check based on ns_parsehtml

Options
    • -44
    • +144
    ./text-html-procs.tcl
1:53 pm

gustafn

Use "ns_parsehtml" for speed and correctness when available

The new NaviServer built-in command "ns_parsehtml" is used on

several occasions in the code when available, namely in

- util_close_html_tags

- escaping disallowed HTML tags in ad_text_to_html

- util_close_html_tags

The command "util_close_html_tags" has a long history of troubles,

since it was implemented originally based on regular expressions. It

was reported in Jan 2009, that the function took on certain forums

entries 6 to 9 hours (e.g. /forums/message-view?message_id=357753) to

finish. Therefore, at this time a quick version based on tdom was

introduced, which reduced at that time the performance to 7.3

seconds. However, the tdom-based version tend to fail on invalid HTML,

so it could cover only a few cases. The new "ns_parsehtml" is more

robust and works very stable on openacs.org with the know problem

cases. Furthermore, this version is also significantly faster than the

tdom version.

Options
    • -33
    • +269
    ./text-html-procs.tcl
  2. … 1 more file in changeset.
Friday 26 Aug 2022
3:00 pm

antoniop

Deprecate ad_parameter_all_values_as_list: it does not provide much value and was also often use improperly

Options
    • -30
    • +9
    ./text-html-procs.tcl
  2. … 4 more files in changeset.
Thursday 25 Aug 2022
1:44 pm

gustafn

Fixed bug in util_convert_line_breaks_to_html

The code deleted spaces around certain tags, while - according to the

documentation, only line breaks should be removed from there.

Extended regression test.

Options
    • -4
    • +5
    ./text-html-procs.tcl
  2. … 1 more file in changeset.
Friday 08 Jul 2022
3:46 pm

antoniop

Handle upcoming tDOM 0.9.3

This might need some further rethinking

Options
    • -4
    • +20
    ./text-html-procs.tcl
Wednesday 06 Jul 2022
5:37 pm

gustafn

added ADP:ICON to the list of accepted tags (for new instances)

Options
    • -2
    • +2
    ./text-html-procs.tcl
  2. … 1 more file in changeset.
Wednesday 09 Mar 2022
6:14 pm

gustafn

slightly better way to handle testing in vanilla instances

Options
    • -5
    • +10
    ./text-html-procs.tcl
Wednesday 02 Mar 2022
6:01 pm

gustafn

Make ad_html_security_check configurable

ad_html_security_check has now three optional attributes

to make it configurable for different situations

-allowed_tags

-allowed_attributes

-allowed_protocols

If these attributes are not specified, the behavior is exactly like

before. This change makes it also easier to regression test this

function, since the behavior does not necessarily depend on a site's

parameter settings.

The function was also modernized, new regression tests were added.

Options
    • -47
    • +78
    ./text-html-procs.tcl
  2. … 1 more file in changeset.
Wednesday 26 Jan 2022
12:12 am

gustafn

use icanuse machinery for "ns_reflow_text -offset"

Options
    • -26
    • +34
    ./text-html-procs.tcl
  2. … 1 more file in changeset.
Monday 06 Sep 2021
6:56 pm

antoniop

Unwrap fake oneliners

Options
    • -8
    • +30
    ./text-html-procs.tcl
6:51 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./text-html-procs.tcl
11:47 am

gustafn

make ad_dom_sanitize_html more robust against invalid input

Options
    • -5
    • +16
    ./text-html-procs.tcl