• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- change spelling of TCL to Tcl

- change requirements to Tcl 8.5

  1. … 64 more files in changeset.
- only variables in a non-top namespace survive session cleanup. The logic of the old code assumed that global variables survive the request-cleanup. now, the cached values is kept in the ::acs::* namespace

- undo previous secure-cookie change since it interacts badly in situations where "RestrictLoginToSSLP" is "1" and https is available: In such cases, e.g. the login page is redirected from a http (insecure) url to an https (secure) page. But when later continuing on the http connection, the user appears to be not logged in, since a well-behaved browser does not send the "secure" login coockie over the insecure connection.

- white space changes: replace tabs by spaces

- replace "global" statement by variables with namespace paths

- move deprecated procs to file with deprecated functions

  1. … 1 more file in changeset.
- setting login-cookie to "secure" when set over secure connection

- just set secure flag for secure connections

- use signed cookie for session_id

- renew the session_id after privilege level change from unidentified to identified user

- fix typo

- brace while expressions

- don't use expr within while expression

- use numeric comparison for truth values

- normalize string expressions

  1. … 9 more files in changeset.
- use per-thread caching for security::driver and ad_server_modules

- new functions security::driver and ad_server_modules to simplify

redundant logic for determining secure drivers

- remove default value from ns_config, otherwise the function determines 443 also for non-configured ssl

- fix uninitialized variable

- try to simplify logic to determine drivers

- dropped nsunix

- use string ops instead of regexp

- modernize tcl

  1. … 9 more files in changeset.
- replace deprecated "ad_get_user_id" by "ad_conn user_id"

  1. … 8 more files in changeset.
- reduce hard-coded config-section names in code

Performance improvements for rp_filter and parameter:

- improve performance of rp_filter (which is run on every

non-resources request) significantly (often a factor of 2)

- improve scalability by reducing number of required mutex locks

(e.g. for secret token handling)

  1. … 8 more files in changeset.
- store secret tokens as described in the comment per thread (previously it did not)

- use tcl 8.5 language construct to shorten code

Fixed to handler cookies from previous version correctly. Add back in inf max_age for session cookie when Remember Me is checked so it passes the expiration test.

Put the strict check in the wrong place.

use -strict when checking for integer as empty string returns true without it

Fix so if the session renew time is NOT included in the cookie (ie: cookies created before this fix) will be renewed

Include last session renew time in ad_session_id cookie so we can compare expiration independent of validity

Don't discard session cookie if its expired, go to login handler.

Added fix to make session_id cookie persistent if you checked remember me

Typo on proc docu.