OpenACS / openacs-4 / packages / acs-subsite / www / user

portrait

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 21
Last Commit: 02 May
Commits this week: 0
Total Lines of Code (LoC): 493
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 29 May 2018
11:30 am

antoniop

Use more API when retrieving user info and portrait, streamline queries, put all sql inline

Options
    • -4
    • +21
    ./comment-edit.tcl
    • -44
    • +0
    ./comment-edit.xql
Monday 28 May 2018
7:45 pm

antoniop

Prefer API over handcrafted queries

Options
    • -6
    • +6
    ./index.tcl
Wednesday 21 Feb 2018
3:00 pm

antoniop

Portrait management reform and correction

Moved logics to create a portrait in a proc in order to reuse it in other places

such as picture retrieval services (e.g. Bach picture retrieval at WU). Turns out

we were not doing our homeworks here: when the portrait is created into CR, a

cr_child_rel is created. When the portrait was erased though, this was not cleaned

up propely, leaving dangling acs_objects with no reference in cr_child_rels table.

On busy sites, this can grow in the ten thousands order of magnitude. Changes include

also fix for this behavior and tuples cleanup.

Options
    • -16
    • +6
    ./index.tcl
    • -19
    • +0
    ./upload-oracle.xql
    • -22
    • +0
    ./upload-postgresql.xql
    • -75
    • +15
    ./upload.tcl
    • -38
    • +0
    ./upload.xql
  6. … 12 more files in changeset.
Monday 19 Feb 2018
1:31 pm

hectorr

fix ad_form definition (moved redirect in after_submit block, ad_return_template at the end of template outside the ad_form) (thanks to Felix Moedritscher)

Options
    • -3
    • +5
    ./upload.tcl
Sunday 21 Jan 2018
1:35 am

gustafn

Use consistently ad_script_abort after ad_return_error.

Break long lines

Options
    • -3
    • +5
    ./comment-edit.tcl
    • -3
    • +5
    ./upload.tcl
  3. … 23 more files in changeset.
Friday 19 Jan 2018
3:09 pm

gustafn

add ad_script_abort after ad_returnredirect to make termination intent explicit

Options
    • -1
    • +2
    ./comment-edit.tcl
  2. … 48 more files in changeset.
Friday 05 Jan 2018
11:29 pm

gustafn

make sure to call ad_script_abort after ad_returnredirect

Options
    • -4
    • +6
    ./upload.tcl
  2. … 2 more files in changeset.
Wednesday 16 Aug 2017
11:18 am

antoniop

Small improvement for portrait management (deletion)

Exploit existing on delete cascade constraints when we delete a portrait, instead of deleting stuff manually.

Also, put remaining logics into a proc and use it in acs_user::delete to address legit use case of people wanting

to remove a user permanently without removing portrait in advance.

Options
    • -33
    • +5
    ./erase.tcl
    • -46
    • +0
    ./erase.xql
  3. … 1 more file in changeset.
Tuesday 08 Aug 2017
1:47 am

gustafn

merged changes from the oacs-5-9 branch and resolved conflicts

Options
    • -2
    • +8
    ./comment-edit.tcl
    • -1
    • +1
    ./erase.adp
    • -2
    • +8
    ./erase.tcl
    • -4
    • +4
    ./index.adp
    • -15
    • +26
    ./index.tcl
    • -6
    • +12
    ./upload.tcl
  7. … 7829 more files in changeset.
Friday 03 Jul 2015
12:25 pm

gustafn

- fix and standardize quoting in template properties

Options
    • -1
    • +1
    ./comment-edit.adp
    • -1
    • +1
    ./erase.adp
    • -1
    • +1
    ./index.adp
    • -1
    • +1
    ./upload.adp
  5. … 393 more files in changeset.
Saturday 27 Jun 2015
6:47 pm

gustafn

- standardize url construction

Options
    • -3
    • +3
    ./index.tcl
  2. … 6 more files in changeset.
6:03 pm

gustafn

- standardize url construction to protect against injection attacks

Options
    • -2
    • +2
    ./erase.tcl
    • -3
    • +3
    ./upload.tcl
  3. … 55 more files in changeset.
Monday 27 Oct 2014
5:38 pm

victorg

Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

Options
    • -2
    • +2
    ./comment-edit.tcl
    • -2
    • +2
    ./erase.tcl
    • -4
    • +4
    ./index.tcl
    • -2
    • +2
    ./upload.tcl
  5. … 2544 more files in changeset.
Tuesday 31 Mar 2009
5:16 pm

emmar

Loop over the array names instead of the list to resize portrait

Options
    • -4
    • +4
    ./upload.tcl
4:39 pm

emmar

Fix contexts and page titles.

Options
    • -2
    • +2
    ./comment-edit.adp
    • -3
    • +7
    ./comment-edit.tcl
    • -1
    • +1
    ./erase.adp
    • -4
    • +11
    ./erase.tcl
    • -11
    • +5
    ./index.adp
    • -8
    • +8
    ./index.tcl
    • -9
    • +1
    ./upload.adp
    • -17
    • +31
    ./upload.tcl
Tuesday 06 Jan 2009
3:25 am

gustafn

remove deprecated calls to ad_parameter

Options
    • -3
    • +3
    ./upload.tcl
  2. … 5 more files in changeset.
Saturday 22 Mar 2008
7:16 pm

gustafn

normalize some more string expressions

Options
    • -3
    • +3
    ./upload.tcl
  2. … 3 more files in changeset.
Tuesday 27 Nov 2007
9:18 pm

emmar

Change to use form builder

Options
    • -62
    • +0
    ./erase-2.tcl
    • -8
    • +1
    ./erase.adp
    • -4
    • +44
    ./erase.tcl
    • -0
    • +46
    ./erase.xql
  5. … 1 more file in changeset.
8:29 pm

emmar

Change to use form builder

Options
    • -4
    • +1
    ./comment-edit.tcl
    • -18
    • +0
    ./upload-2-oracle.xql
    • -22
    • +0
    ./upload-2-postgresql.xql
    • -129
    • +0
    ./upload-2.tcl
    • -0
    • +19
    ./upload-oracle.xql
    • -0
    • +22
    ./upload-postgresql.xql
    • -30
    • +3
    ./upload.adp
    • -2
    • +124
    ./upload.tcl
7:02 pm

emmar

Change to use form builder

Options
    • -42
    • +0
    ./comment-edit-2.tcl
    • -15
    • +1
    ./comment-edit.adp
    • -4
    • +24
    ./comment-edit.tcl
    • -1
    • +13
    ./comment-edit.xql
6:00 pm

emmar

Replace english text with message keys. Extract sql to xql file

Options
    • -15
    • +5
    ./comment-edit.tcl
    • -0
    • +32
    ./comment-edit.xql
3:51 pm

emmar

Replace english text with message keys

Options
    • -3
    • +3
    ./upload.adp
    • -3
    • +3
    ./upload.tcl
2:23 pm

emmar

Replace english text with message keys

Options
    • -3
    • +3
    ./upload.tcl
Wednesday 21 Nov 2007
6:01 pm

emmar

HTML 4.01 strict cleanup

Options
    • -8
    • +8
    ./comment-edit.adp
    • -5
    • +6
    ./erase.adp
    • -8
    • +9
    ./index.adp
    • -12
    • +10
    ./upload.adp
    • -13
    • +4
    ./upload.tcl
6:01 pm

emmar

Extracting embedded sql

Options
    • -0
    • +38
    ./upload.xql
Tuesday 11 Sep 2007
11:44 am

maltes

Made sure to flush the cache, fixed form error and guaranteed that old images are deleted as well (cleanup)

Options
    • -6
    • +19
    ./erase-2.tcl
    • -1
    • +1
    ./erase.adp
    • -1
    • +4
    ./upload-2.tcl
Tuesday 29 May 2007
7:37 am

maltes

Handle thumbnail portraits correctly. Especially delete them when the original changes or was deleted. Additional delete the items for good and not let them linger around. We do not have an interface to resurrect old portraits and if a user willingly uploads or deletes a portrait he should not have a photo album of portraits to come back to.

Options
    • -6
    • +16
    ./erase-2.tcl
    • -4
    • +18
    ./upload-2.tcl
    • -0
    • +9
    ./upload.adp
    • -1
    • +17
    ./upload.tcl
Monday 14 May 2007
10:30 pm

donb

Merged the 5.3 branch with HEAD. Look for tags with the pattern

drb-*-20070513

Options
    • -5
    • +5
    ./comment-edit.adp
    • -5
    • +3
    ./upload.adp
  3. … 323 more files in changeset.
Wednesday 10 Jan 2007
10:21 pm

gustafn

Normalizing string comparison operations into tcl 8.4 operations, enabling byte-code compilation for expressions and many conditionals

Options
    • -3
    • +3
    ./comment-edit-2.tcl
    • -6
    • +6
    ./comment-edit.tcl
    • -3
    • +3
    ./erase-2.tcl
    • -2
    • +2
    ./erase.tcl
    • -9
    • +9
    ./index.tcl
    • -5
    • +5
    ./upload-2.tcl
    • -4
    • +4
    ./upload.tcl
  8. … 361 more files in changeset.
Friday 15 Dec 2006
6:25 pm

donb

Missed this change in my 5.3 merge

Options
    • -1
    • +2
    ./upload-2.tcl