• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Complete proc coverage for the package

    • -0
    • +21
    ./test/30-apm-load-procs-oracle.xql
    • -0
    • +20
    ./test/30-apm-load-procs-postgresql.xql
fix bug, when Tcl's file command uses uplevel

This change fixes a bug whem "ad_file tmpfile filename ..." is used.

The output variable "filename" was created on the wrong calling level.

remove constant from deprecated message

Configure nsf to keep init commands much earlier, so that we don't lose doc for nsf classes defined before xotcl-core is loaded

  1. … 1 more file in changeset.
Properly escape "<" and ">" in api-doc documentation.

Since all documentation is rendered via HTML, the characters

"<" and ">" have to be HTML-quoted, otherwise strange things

(omission, unintended renderings) might occur.

E.g. the sentence

Define an interface between a page and an

ADP <include> similar to the page_contract.

was rendered as

Define an interface between a page and an

ADP similar to the page_contract.

which is incorrect.

  1. … 13 more files in changeset.
new proc "ad_log_deprecated": unified interface for logging deprecated usages

The existing code used a larger variety of different messages to

denote invocations of deprecated procs and other

artifacts. "ad_log_deprecated" provides a unified interface, and

provides a usage hint what to use instead based on the API-doc

definitions in the log-file.

  1. … 11 more files in changeset.
Add @see to deprecated procs

Deprecate ad_apply, made obsolete in modern Tcl by the expansion operator "{*}"

  1. … 4 more files in changeset.
Whitespace cleanup

Streamline ns_set idioms

  1. … 1 more file in changeset.
improve spelling

  1. … 1 more file in changeset.
Document behavior

Whitespace cleanup

passing "-debug" flag explicitly to nsf::proc

improve comments

improve spelling

  1. … 1 more file in changeset.
reduce the number of locks (nsv-accesses) for OACS_FULLQUERIES by a factor of 3 when NaviServer is used.

OACS_FULLQUERIES is one of the 3 most intensively locked nsv arrays for

busy implementation

    • -20
    • +52
    ./40-db-query-dispatcher-procs.tcl
improve test coverage

reduce visibility of internal functions

move function db_current_rdbms to acs-bootstrap installer to improve code locality

  1. … 1 more file in changeset.
Cleanup of low-level DB-interace: use dict instead of list with fixed positions

VS: ----------------------------------------------------------------------

    • -28
    • +48
    ./40-db-query-dispatcher-procs.tcl
  1. … 3 more files in changeset.
Added support for trailing non-positional arguments

The change makes the old hack with the own trailing-argument-parser

"ad_arg_parser" obsolete by using directly the c-level argument parser

which is anyhow capable of handling trailing arguments. A few changes

were necessary for api doc to handle there trailing arguments as well.

The proc "db_string" is already converted to use native arguments.

  1. … 7 more files in changeset.
added a comment about the usefulness of ad_arg_parser

Fix for issue #3442 to support range types in .xql files

PostgreSQL supports range types since 9.5. When using range types,

square braces have to be used in SQL statements. Since OpenACS uses

always Tcl substitution in .xql files, and OpenACS does NOT allow

backslash substitution in these files, square brackets could not be

escaped and therefore not be used in .xql files so far. This change

allows now a developer to deactivate the substitution by passing

e.g. "-subst none" to the db_* command using the .xql file. Valid

values for "-subst" are "all", "none", "vars", and "commands", default

is "all" which is exactly the behavior of before. Therefore, this

change is fully backward compatible.

  1. … 3 more files in changeset.
reduce the size of the public interface

    • -10
    • +10
    ./40-db-query-dispatcher-procs.tcl
whitespace changes: break overlong lines

    • -150
    • +176
    ./40-db-query-dispatcher-procs.tcl
make clear from the name that db_qd_prepare_queryfile_content is intended to be used in different packages

  1. … 2 more files in changeset.
Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 4 more files in changeset.
Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 3 more files in changeset.
Make proc public (it is used in a test is acs-tcl)

Complies with acs-api-browser.callgraph__bad_calls