• last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- make upgrade script more robust

- replace regular expression by ad_html_qualify_links

- bum version number to 5.9.1d2

- imporve ad_html_qualify_links in various ways (better argument name, better comments, removed superflous slashes, ...

    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
- turn relative links during notifications into absolute links

    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
- add a function ad_html_qualify_links to make e.g. relative URL handing in notifications easier

- use the right variable name

Add index on ad_locale_user_prefs for foreign key user_id

file upgrade-5.9.1d1-5.9.1d2.sql was initially added on branch oacs-5-9.

- fix code for making urls absolute. regexps like [^(http|https|mailto:)] don't work, as the author expected.

Allow messages starting with a dash

Avoid logging every message sent to reduce IO

Removed unnecessary decoding of received messages, fixed encoding of sent messages so special characters are properly urlencoded.

    • -4
    • +5
    /openacs-4/packages/chat/www/ajax/chat.js
- use :form_field_index for adding names recursively to the index

- provide more detailed debugging info

    • -2
    • +1
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
    • -2
    • +10
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Handle in a human way when lookup of a key fails (but keep reporting in the logs)

- remove commented out "if disabled" code; otherwise, the controls are also shown when viewing the items

    • -24
    • +24
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
Fix typo

    • -2
    • +2
    /openacs-4/packages/chat/tcl/chat-procs.tcl
- add repeat container to debugging output

    • -1
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
- add debugging aids in case creation of nested formfields fails

    • -4
    • +6
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
    • -2
    • +13
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
- detect when repeat fields are used in input mode: as long we have no js-support, max repeat count form fields have to be created in advance

- avoid duplicate generations for form fields in some cases

    • -3
    • +14
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
    • -1
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
- move CSP generation to rendering section

- allow the repeat fields to be sent in arbitrary order from the browser

    • -6
    • +19
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Added catalog file of new message keys

Allow user to specify how far in the past people connecting to the chat will see.

This is important on Learn@WU because people joining the chat room later want to

see the full conversation and before this was not settable from the UI. (Now defaults

to 4 hours) Useful also when somebody accidentally refreshes the chat after the

timewindow has passed.

Took this chance to ease a bit every future development: removed stored procedures

slowing greatly any change on the data model in favor of plain sql statements.

Incremented usage of cache.

Removed duplicated database operation when managing transcripts.

Fixed transcript name not being shown when deleting.

    • -27
    • +51
    /openacs-4/packages/chat/tcl/chat-procs.tcl
    • -12
    • +69
    /openacs-4/packages/chat/tcl/chat-procs.xql
    • -50
    • +60
    /openacs-4/packages/chat/www/room-edit.tcl
    • -13
    • +12
    /openacs-4/packages/chat/www/room.tcl
file upgrade-5.0d12-5.0d13.sql was initially added on branch oacs-5-9.

- extend dynamic repeat field creating for nested cases

    • -12
    • +33
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Commit some leftover change, apply some review suggestions

- add functionality to dynamically add components for repeated form fields (no preallocation needed).

This is per default deactivated, .js support for "adding more" is missing.

    • -8
    • +48
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
    • -1
    • +19
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Added info file incrementing the version

Refined error reporting: by returning a page containing the prefix

"chat-errmsg: "

one can decide what to show in case of error, otherwise we stick to the old behaviour (predefined message).

    • -2
    • +7
    /openacs-4/packages/chat/www/ajax/chat.js
Chats won't throw an error anymore when people keep looking to a room that has been closed.

Instead, user will be informed that the room is unavailable.

Added missing locale key source of errors in the log.

Fixed wrong stored procedure, stating different arguments than in actual usage.

Cleaned up weird idioms in xql files and chat api, moved many db operations into tcl api.

Exploited cache (ns_cache) to retrieve quickly chat room information.

Improved code quality a bit.

Ported upstream some local modification, like prettifying of flags in chat room management

and fix of double quoting in chat's javascript.

    • -20
    • +58
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
    • -134
    • +172
    /openacs-4/packages/chat/tcl/chat-procs.tcl
    • -19
    • +5
    /openacs-4/packages/chat/www/chat.tcl
    • -2
    • +15
    /openacs-4/packages/chat/www/room.tcl
    • -5
    • +6
    /openacs-4/packages/chat/www/ajax/chat.js
    • -20
    • +14
    /openacs-4/packages/chat/www/ajax/chat.tcl