OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 3
Total Committers: 145
Last Commit: 17 May
Commits this week: 3
Total Lines of Code (LoC): 6,873,112
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 29 Mar 2022
5:42 pm

trenner

tighten page contract

Options
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/deregister-self-confirm.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn/www/deregister.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn/www/register.tcl
5:39 pm

antoniop

Depend specifically from the form-field-procs file to support the case of reloads

Options
    • -0
    • +1
    /openacs-4/packages/xowf-monaco-plugin/tcl/form-field-procs.tcl
4:58 pm

antoniop

Don't require the whole xowiki, as it is already a dependency

Options
    • -1
    • +0
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -2
    • +0
    /openacs-4/packages/xowf/tcl/xowf-form-field-procs.tcl
    • -1
    • +0
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
4:53 pm

antoniop

Make xowf an explicit dependency, so that we don't need to require xowf and xowiki in the tcl files

Options
    • -2
    • +3
    /openacs-4/packages/xowf-monaco-plugin/xowf-monaco-plugin.info
    • -2
    • +0
    /openacs-4/packages/xowf-monaco-plugin/tcl/form-field-procs.tcl
    • -1
    • +0
    /openacs-4/packages/xowf-monaco-plugin/tcl/test-item-procs.tcl
1:01 pm

trenner

increase robustness

Options
    • -2
    • +4
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
11:25 am

gustafn

New feature: cookie namespaces

So far, all OpenACS versions used "ad_" as a prefix for cookies (such

as ad_login, ad_session_id, ...). In certain situations this can lead

to confusion, since cookies are managed by browsers via domain names,

and running multiple OpenACS instances in the same domain will cause

overwriting of such cookies by these instances. The can happen e.g.

when running multiple instances on the same machine, or using

port-forwarding to virtual machines/containers, using reverse proxies,

etc. Note that the cookie overwriting problem does not exist for

host-node-mapped subsites, since host-node-mapping depends on domain

names.

One could consider using the port in the cookie name (as

sometimes noted as an option), but this would not work, in case the

same server should be reachable over multiple ports.

Therefore, one can now specify a "CookieNamespace" in the OpenACS

configuration file, which is per default "ad_", which is sufficient

for the majority of installations. In cases, where it is needed, a

different CookieNamespace can now be configured.

To manage the cookie names internally, OpenACS provides a new API call

security::cookie_name to derive the namespaced cookie name from a stem.

Snippet of the OpenACS configuration file for setting the CookieNamespace

#---------------------------------------------------------------------

# OpenACS specific settings (per server)

#---------------------------------------------------------------------

ns_section ns/server/${server}/acs {

ns_param CookieNamespace "ad_"

...

}

Options
    • -8
    • +0
    /openacs-4/packages/acs-tcl/tcl/security-procs-oracle.xql
    • -6
    • +0
    /openacs-4/packages/acs-tcl/tcl/security-procs-postgresql.xql
    • -29
    • +52
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
10:53 am

gustafn

cleanup: the updated version of the site-note code is appartently stable enough also for bootstrap situations

Options
    • -16
    • +9
    /openacs-4/packages/acs-tcl/tcl/cluster-init.tcl
10:50 am

gustafn

remove commented out coude

Options
    • -2
    • +1
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
10:49 am

gustafn

Provide better debug info in case "ns_parseurl" fails inside util::split_location

Factor our private function "util::ns_set_pretty_print" which might be

used also on other occasions.

Options
    • -6
    • +41
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
Monday 28 Mar 2022
6:04 pm

gustafn

use bootstrap button classes for print button in the exam protocol (many thanks to Monika Andergassen for the suggestion)

Options
    • -6
    • +6
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
5:51 pm

gustafn

replace non-existing class "btn-small" (for bootstrap3) by non-existing class "btn-secondary", which shows in the right color and is future proof (introduced by bootstrap 4).

Options
    • -1
    • +1
    /openacs-4/packages/xowf/resources/prototypes/select-topics.form.page
    • -3
    • +3
    /openacs-4/packages/xowf/resources/prototypes/select_question.form.page
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Friday 25 Mar 2022
9:24 pm

gustafn

prevent double-sorting

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/last-requests.tcl
9:19 pm

gustafn

some more fine-tuning

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/stat-details.tcl
    • -3
    • +19
    /openacs-4/packages/xotcl-request-monitor/www/whos-online-today.tcl
8:49 pm

gustafn

Make use of extended functionality of OrderedComposite->orderby with -type argument

bumped version number to 0.64

Options
    • -3
    • +3
    /openacs-4/packages/xotcl-request-monitor/xotcl-request-monitor.info
    • -2
    • +5
    /openacs-4/packages/xotcl-request-monitor/www/active-communities.tcl
    • -1
    • +7
    /openacs-4/packages/xotcl-request-monitor/www/last-requests.tcl
    • -2
    • +5
    /openacs-4/packages/xotcl-request-monitor/www/last100.tcl
    • -2
    • +5
    /openacs-4/packages/xotcl-request-monitor/www/last101.tcl
    • -13
    • +7
    /openacs-4/packages/xotcl-request-monitor/www/stat-details.tcl
    • -18
    • +6
    /openacs-4/packages/xotcl-request-monitor/www/whos-online-today.tcl
    • -17
    • +9
    /openacs-4/packages/xotcl-request-monitor/www/whos-online.tcl
8:28 pm

gustafn

Perform stricter checking of parent_ids

bump version number of xowf to 5.10.1d34

Options
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -1
    • +1
    /openacs-4/packages/xowf/lib/answer-single-question.wf
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
8:13 pm

gustafn

use preferred idioms to use btn-default/btn-secondary for bootstrap3/bootstrap5

Options
    • -7
    • +2
    /openacs-4/packages/xowiki/tcl/bootstrap-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
7:46 pm

gustafn

further tighten value checker

Options
    • -1
    • +1
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
11:13 am

gustafn

Perform stricter checking of parent_ids

bump version number of xowiki to 5.10.1d22

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -6
    • +8
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -5
    • +15
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
    • -7
    • +3
    /openacs-4/packages/xowiki/www/admin/import.tcl
11:08 am

gustafn

Added NSF value-checker "cr_item_of_package" for quick checks for valid parameters

This checker is especially useful when processing external values

(query-parameters etc). Since the check involves a DB lookup, it is

no suited inside busy loops.

bumped version number of xotcl-core to 5.10.1d6

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/xotcl-core.info
    • -1
    • +7
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
10:27 am

gustafn

whitespace changes

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/www/admin/import.tcl
Thursday 24 Mar 2022
9:06 am

gustafn

Prefer "... orderby ... -type ..." over mixin for sorting

Options
    • -4
    • +3
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
    • -6
    • +6
    /openacs-4/packages/xowiki/tcl/tree-procs.tcl
Wednesday 23 Mar 2022
9:40 pm

gustafn

Make use of extended functionality of OrderedComposite->orderby

- use integer comparison for "seconds" in participants table

- bumped version number to 5.10.1d33

Options
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -0
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
9:37 pm

gustafn

Make use of extended functionality of OrderedComposite->orderby

- Removed manual adding of mixin ::xo::OrderedComposite::IndexCompare

in "toc" includelet and in xowiki::TableWidget->create_from_form_fields

- xowiki::TableWidget->create_from_form_fields:

added type map to allow caller to specify, on which attributes e.g.

a numeric comparison should be used.

- bumped version number to 5.10.1d22

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
    • -4
    • +5
    /openacs-4/packages/xowiki/tcl/table-widget-procs.tcl
9:29 pm

gustafn

OrderedComposite->orderby: added argument "-type"

By the change, one can now specifiy the sorting type for the ordered

composite. The sorting type can be "integer", "real", "index" or

"dictionary" (default "dictionary"). If the sorting type is set to

"index", the mixin ::xo::OrderedComposite::IndexCompare is added

automatically.

Bump version number to 5.10.1d6

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/xotcl-core.info
    • -7
    • +40
    /openacs-4/packages/xotcl-core/tcl/20-Ordered-Composite-procs.tcl
7:55 pm

gustafn

rework of ad_decode

- modernize code

- improve performance

- extend regression test

Options
    • -35
    • +26
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -0
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
10:17 am

gustafn

stick with integer for purely nsf-based checks in public code.

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/www/admin/import.tcl
10:03 am

gustafn

Added API call "CrClass ad_proc id_belongs_to_package"

The new API call is useful for checking input validity, i.e.

whether to provided revision_id or item_id belongs to the specified package.

bump version number of xowiki to 5.10.1d21

bump version number of xotcl-core to 5.10.1d5

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/xotcl-core.info
    • -2
    • +23
    /openacs-4/packages/xotcl-core/tcl/cr-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -15
    • +3
    /openacs-4/packages/xowiki/www/admin/import.tcl
9:33 am

gustafn

check parent_id more properly

Options
    • -5
    • +24
    /openacs-4/packages/xowiki/www/admin/import.tcl
Tuesday 22 Mar 2022
9:05 pm

gustafn

prefer variable ::acs::rootdir over proc [acs_root_dir]

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-callback-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
9:02 pm

gustafn

improve page contract

Options
    • -5
    • +5
    /openacs-4/packages/xowiki/www/admin/import.tcl