OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 21 Nov 2022
8:46 pm

gustafn

Fix for updating the time window via configuration dialog

In cases, where no student submissions exists, updating the time

window via the configuration dialog was ignored.

Many thanks to Thomas Renner for finding the cause and providing a fix.

Options
    • -1
    • +15
    /openacs-4/packages/xowf/lib/inclass-exam.wf
8:41 pm

gustafn

made time_window_setup public for saving the values from the configuration dialog

Options
    • -1
    • +7
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
10:47 am

gustafn

Improved appearance in TRN mode

- don't set "alt" attribute in classic mode by default to the title.

The title is often be provided as a message key, using it twice

causes two edit controls

- in acs-lang, the extra setting of link_html, which provided

the title attribute can be omitted, since adp:icon renders this

by itself.

Options
    • -3
    • +1
    /openacs-4/packages/acs-lang/www/admin/index.tcl
    • -1
    • +9
    /openacs-4/packages/acs-templating/tcl/style-procs.tcl
Sunday 20 Nov 2022
11:58 am

gustafn

beautify TRN mode in developer support

in essence, this change switches from CSS icons to <adp:icon>

since in default setup (when no themes/icon sets are installed)

the CSS based rendering was bad. Using <adp:icon> offers

more flexibility and tailorability.

Options
    • -7
    • +11
    /openacs-4/packages/acs-templating/tcl/acs-integration-procs.tcl
    • -9
    • +9
    /openacs-4/packages/openacs-bootstrap3-theme/www/resources/css/main.css
    • -9
    • +11
    /openacs-4/packages/openacs-bootstrap5-theme/www/resources/css/main.css
    • -10
    • +9
    /openacs-4/packages/openacs-default-theme/www/resources/styles/default-master.css
11:54 am

gustafn

fix wrong icon in "classic" mode (using images)

Options
    • -1
    • +1
    /openacs-4/packages/acs-templating/tcl/style-procs.tcl
5:38 am

raulr

improve Oracle compatibility

Options
    • -0
    • +32
    /openacs-4/packages/acs-subsite/www/admin/group-types/one-postgresql.xql
    • -0
    • +32
    /openacs-4/packages/acs-subsite/www/admin/group-types/one-oracle.xql
    • -25
    • +3
    /openacs-4/packages/acs-subsite/www/admin/group-types/one.tcl
4:39 am

raulr

improve Oracle compatibility

Options
    • -0
    • +41
    /openacs-4/packages/acs-subsite/www/admin/group-types/index-oracle.xql
4:26 am

raulr

improve Oracle compatibility

Options
    • -5
    • +5
    /openacs-4/packages/acs-subsite/www/admin/groups/elements-by-rel-type.tcl
Thursday 17 Nov 2022
7:48 am

gustafn

fix setting of dict value in error cases

Options
    • -2
    • +1
    /openacs-4/packages/boomerang/tcl/boomerang-procs.tcl
4:48 am

raulr

improve Oracle compatibility

Options
    • -4
    • +8
    /openacs-4/packages/acs-lang/www/admin/index.xql
    • -2
    • +1
    /openacs-4/packages/acs-subsite/www/admin/themes/index.xql
4:28 am

raulr

improve Oracle compatibility

Options
    • -0
    • +17
    /openacs-4/packages/acs-subsite/www/admin/site-map/site-map-oracle.xql
    • -0
    • +18
    /openacs-4/packages/acs-subsite/www/admin/site-map/site-map-postgresql.xql
    • -16
    • +3
    /openacs-4/packages/acs-subsite/www/admin/site-map/site-map.tcl
Wednesday 16 Nov 2022
12:42 pm

gustafn

Don't break appearance for bootstrap3

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
8:30 am

gustafn

make sure, variables for emergency settings are provided

Options
    • -1
    • +2
    /openacs-4/packages/boomerang/tcl/boomerang-procs.tcl
Tuesday 15 Nov 2022
5:59 pm

gustafn

added warnings/errors in case outdated code is encountered

Options
    • -1
    • +13
    /openacs-4/packages/acs-templating/tcl/element-procs.tcl
2:03 pm

trenner

harden policy that a user needs at least admin permission on the package for e.g. editing a question

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Monday 14 Nov 2022
5:16 am

raulr

improve Oracle compatibility

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/admin/applications/index-oracle.xql
3:26 am

raulr

improve Oracle compatibility

Options
    • -0
    • +5
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
Sunday 13 Nov 2022
10:37 am

gustafn

Minor CSP improvements

- provided ability to add "trusted-types" and "require-trusted-types-for"

directives (Trusted Types policies)

For details, see:

https://blog.bitsrc.io/trusted-types-api-for-javascript-dom-security-fcdafa927e73

- changed default "object-src" from 'self' to 'none'

Options
    • -5
    • +8
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
6:11 am

raulr

improve Oracle compatibility

Options
    • -8
    • +18
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
Saturday 12 Nov 2022
6:12 pm

gustafn

register URN for highcharts from CDN only, when highcharts package is not installed

Options
    • -3
    • +5
    /openacs-4/packages/xowiki/tcl/resource-init.tcl
6:05 pm

gustafn

file jquery.ui.touch-punch-0.2.3.js was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/xowiki/www/resources/jquery/jquery.ui.touch-punch-0.2.3.js
6:05 pm

gustafn

Added support for drag&drop on reorder items for mobile devices

Additionally, provided a minimal width for drag items (there is probably a better solution for this)

Options
    • -2
    • +5
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -0
    • +2
    /openacs-4/packages/xowiki/tcl/resource-init.tcl
    • -0
    • +180
    /openacs-4/packages/xowiki/www/resources/jquery/jquery.ui.touch-punch-0.2.3.js
5:16 pm

gustafn

fix icon for boostrap5 (CSS value)

Options
    • -0
    • +10
    /openacs-4/packages/xowiki/www/resources/xowiki-bootstrap3-specific.css
    • -0
    • +11
    /openacs-4/packages/xowiki/www/resources/xowiki-bootstrap5-specific.css
    • -10
    • +0
    /openacs-4/packages/xowiki/www/resources/xowiki.css
Friday 11 Nov 2022
10:26 am

trenner

change datatype to file to ensure template::data::validate::file is executed

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/user/portrait/upload.tcl
Thursday 10 Nov 2022
2:15 pm

trenner

register javascript click event for adding a calender entry only once for each day

before javascript event was registered multiple times: for each day and for each calender event

javascript click event for adding a calender entry was also fired when a calender event was viewed

Options
    • -11
    • +3
    /openacs-4/packages/calendar/www/view-month-display.tcl
Tuesday 08 Nov 2022
7:04 pm

gustafn

Deescalation: the usage of the pairs in export_vars is not so dangerous as it looked at first sight.

The problem case was originating from the call

lappend __vars [lindex $_var 0] [uplevel subst [lindex $_var 1]]

which calls Tcl's "uplevel" with two arguments. In this case, the arguments

are concatenated and the evaluated in the caller's frame. There is a substitution

before the evaluation. When just one argument is passed in, this problem there

is only one evaluation:

lappend __vars [lindex $_var 0] [uplevel [list subst [lindex $_var 1]]]

Options
    • -5
    • +5
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -6
    • +8
    /openacs-4/packages/xotcl-core/tcl/06-package-procs.tcl
3:20 pm

gustafn

avoid subst in export_vars when not necessary

Options
    • -3
    • +3
    /openacs-4/packages/bug-tracker/lib/nav-bar.tcl
3:19 pm

gustafn

avoid subst in export_vars when not necessary

Options
    • -2
    • +3
    /openacs-4/packages/forums/www/forum-view.tcl
    • -2
    • +3
    /openacs-4/packages/acs-api-browser/www/proc-view.tcl
3:02 pm

gustafn

avoided subst in export_vars when not necessary

Options
    • -1
    • +2
    /openacs-4/packages/acs-admin/lib/service-parameters.tcl
    • -2
    • +6
    /openacs-4/packages/acs-subsite/lib/applications.tcl
2:59 pm

gustafn

added warning to export_vars

Options
    • -1
    • +8
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl