OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 18
Total Committers: 146
Last Commit: 28 Nov
Commits this week: 18
Total Lines of Code (LoC): 7,560,946
Net change in LoC this week: 3

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 20 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 09 Nov 2021
9:05 pm

gustafn

Added per-request-cache for parameter::get similar to parameter handling in xotcl-core

This change improves scalability especially on sites with high numbers

of concurrent requests by reducing the number of required locks in

general. This change keeps the parameter dict in a per-request cache

to reduce potentially high number of nsv locks, when parameters of a

package are queried a often per request. Without this change we see on

some sites > 100 locks on the ad_param-nsv per request. Alone the

request-procesor queries a larger set of parameters from the acs-core

package, which requires now a single lock operation.

Using the per-request cache has the advantave of avoiding locks and

keeping the internal representations of tcl-objs (whereas ns_cache or

nsvs use plain strings).

Options
    • -4
    • +24
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
8:33 pm

gustafn

extend/debug simplified where/unless query language

Options
    • -17
    • +36
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
8:27 pm

gustafn

modernize idiom

Options
    • -5
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
Saturday 06 Nov 2021
3:33 pm

gustafn

use fully qualified cmd name in directdispatch

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Friday 05 Nov 2021
9:09 am

gustafn

Added support for tailored messages when autosave is rejected

Optionally, the AJAX call from autosave can be answered with

a JSON structure containing a "feedback". If this is provided, this

is presented to the user. The mechanism can be extended in the

future to include some reason code, etc. for further automatic

processing in JavaScript.

With this change, the inclass-exam-answer workflow will use this

to comminicate the reasone for rejected autosave operations in

situations, where the examtime is up.

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -0
    • +2
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -2
    • +3
    /openacs-4/packages/xowf/lib/inclass-exam-answer.wf
    • -1
    • +6
    /openacs-4/packages/xowiki/www/resources/autosave-text.js
Thursday 04 Nov 2021
6:14 pm

gustafn

keep track of position of a question in the form for correct scrambling also for filtering by form object

background: randomization depends on the per-user random values and by the position

of a test-item in an exam. If one is filtering just for the test-item,

the position of this item in the exam was lost. Now, we keep track

in the filtering cases

Options
    • -3
    • +15
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
6:10 pm

gustafn

minor update of call pattern and debug line

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
5:11 pm

gustafn

mitigate attacks, where the referer header field is changed to a malicious value

The problem does not exist, when CSP is defined properly.

Many thanks to Frank Bergmann for sharing the pen-test protocol

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
    • -5
    • +5
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
    • -1
    • +10
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
Wednesday 03 Nov 2021
8:11 pm

gustafn

make sure, the end_clock is always an integer (as required by "clock format")

Options
    • -8
    • +10
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
7:58 pm

gustafn

improve input checking

Options
    • -7
    • +16
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Tuesday 02 Nov 2021
2:46 pm

gustafn

prefer xowf message catalog

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
11:29 am

gustafn

Performance improvement: make "apm_version_names_compare" faster by a factor of ~100

The function "apm_version_names_compare" is called relatively often

and issues an SQL query. The function is stable (returns always the

same results for the same input) and called with only a few different

input values. By using acs::per_thread_cache the performance improves

from 265 microseconds to 2 microseconds; by using the per-tread cache

the operation scales better since it is fully lock-free (once cached).

Options
    • -13
    • +11
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
10:55 am

gustafn

Deactivate compatibility with versions before OpenACS 5.2 (2005) in

busy code, but leave it there commented out for easy reactivating in

legacy applications.

Options
    • -7
    • +16
    /openacs-4/packages/xotcl-core/tcl/cr-procs.tcl
10:47 am

gustafn

use variable to reference kernel id, white space and comment changes

Options
    • -8
    • +17
    /openacs-4/packages/xotcl-core/tcl/06-param-procs.tcl
Monday 01 Nov 2021
10:19 pm

gustafn

provide means for omit the audio alarm control in the countdown timer

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -1
    • +3
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/xowf/lib/inclass-exam-answer.wf
    • -2
    • +3
    /openacs-4/packages/xowf/resources/prototypes/select_question.form.page
    • -2
    • +7
    /openacs-4/packages/xowf/tcl/xowf-includelet-procs.tcl
11:41 am

gustafn

Remove backward compatibility check in busy code for versions before 5.1.3 (2004)

The checks for backwards compatibility have on busy sites the highest

hit rates of all entries in the util-memoize cache. Since we require the latest

OpenACS 5.9.* for upgrade to 5.10, this can be removed (17 years later).

https://openacs.org/bugtracker/openacs/bug?format=table&f%5fstate=8&bug%5fnumber=2200

Options
    • -22
    • +6
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
Sunday 31 Oct 2021
8:55 pm

gustafn

Show form-field statistics in exam-summary for autograded exams:

- Provide statitics for autograded exams and show this (currently for

MC/SC) in the exam summary. The statistics are generated when the

exam-protocol is rendered and persisted statistics in the workflow

instance.

- Added switch "-generic" to answer_form_field_objs to obtain the

question with all alternatives (not constraint to "show_max") and

without shuffling. This is needed in cases, where e.g. statistics

should be provided for all alternatives shown to all students.

- Question_manager->question_info: separate computation from HTML rendering

- Added statistics handler for the WorkflowPage class to collect

details from the form-fields.

- new private function "tdom_render" (might be useful, but is the

committed version not used)

- split out "spec_to_dict" from "fc_to_dict", since it us also useful on its own

to work on single form-constraint specs.

- make methods add_to_fc and replace_in_fc available to the full AssessmentInterface

Options
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -65
    • +220
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -0
    • +26
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
8:07 pm

gustafn

Refactor form-field statistics (part 1)

- Start move of statistics from being collected in form-fields to

collecting these in the workflow objects. The original code was

developed with less randomization (e.g. no x out of y alternatives)

which requires that the formfields have to be reset multiple times

(e.g. for multiple students in the exam protocol). The exam-protocol

handler cleans regularly the form-fields, which caused also the

deletion of statistics. Collecting these in the (exam) workflow is

safe.

- Collect correct and incorrect statistics per alternative. Since

different students might see different alternatives calculating the

successrate can only be performed by the students having seens this

alternative.

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -13
    • +76
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -1
    • +17
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Saturday 30 Oct 2021
2:08 pm

gustafn

fix typo

Options
    • -2
    • +2
    /openacs-4/packages/boomerang/tcl/boomerang-procs.tcl
2:06 pm

gustafn

remove indent as well on xotcl procs, handle also per-object methods the same way

Options
    • -18
    • +18
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -18
    • +21
    /openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl
Friday 29 Oct 2021
12:35 pm

gustafn

added support for "ns_trim -prefix".

The command is predefined in NaviServer; if not available, a comatibility version is added.

This change also mitigates a potential memory-leak problem in nsv_dict with certain

versions of NaviServer which might lead on busy sites to problems.

Options
    • -3
    • +3
    /openacs-4/packages/acs-api-browser/acs-api-browser.info
    • -6
    • +2
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -12
    • +39
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
10:49 am

gustafn

fix typo

Options
    • -1
    • +1
    /openacs-4/packages/xowf/lib/inclass-quiz.wf
Thursday 28 Oct 2021
6:09 pm

gustafn

add publish status to default list of columns in child-resources

Options
    • -1
    • +4
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
1:41 pm

hectorr

Fix typo

Options
    • -1
    • +1
    /openacs-4/packages/xooauth/tcl/ms-procs.tcl
12:20 pm

gustafn

complete query variables

Options
    • -3
    • +3
    /openacs-4/packages/xooauth/tcl/ms-procs.tcl
12:10 pm

gustafn

prettify API browser rendering for nx methods

- remove redundant doc block

- remove indentation

Options
    • -5
    • +36
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -4
    • +21
    /openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl
10:08 am

gustafn

make sure, no commented out code is added to the proc doc

Options
    • -13
    • +19
    /openacs-4/packages/xooauth/tcl/ms-procs.tcl
9:56 am

gustafn

beautify labels of ensemble methods in object browser

Options
    • -1
    • +6
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
Wednesday 27 Oct 2021
9:34 pm

gustafn

added support for NX ensemble methods

Options
    • -4
    • +5
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
    • -8
    • +6
    /openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl
6:46 pm

gustafn

remove incorrect and misleading comment and simplify code accordingly

Options
    • -15
    • +7
    /openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl