• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Use an idiom without expr to fill up the multirow after the body execution

Test the behavior when the multirow contains values in the form "\d+\.": this shows a bug caused by the value retrieval going through an expr, which will "normalize" the value to "\d+\.0"

handle empty string case

Fix typo

calendar_ids_list won't be passed in the right format to be validated in the page contract, in exchange, quote it properly in the database

Use standard %H:%M notation to pass the event time to calendar creation

form-template: update notation for select box, radio and checkbox to Bootstrap 5

Many thanks to Monika Andergassen

improve spelling

Don't write error to system log due to failed DML call to error log on forseeable conditions

On calls with exception handlers on duplicate name entries, we do not

want to see entries in the sytem log

skip empty entries in mc2 choices

Many thanks to Monika Andergasse for the suggestion

removed hard-coded styling to improver stylability via CSS on admin page

Many thanks to Monika Andergasse for the suggestion

    • -2
    • +2
    /openacs-4/packages/xowiki/www/admin/list.tcl
Whitespace cleanup

Cleanup vars

    • -5
    • +3
    /openacs-4/packages/news/www/preview.tcl
Use modern contract and formfield features to avoid manual date validation

    • -9
    • +9
    /openacs-4/packages/news/www/item-create.tcl
    • -39
    • +10
    /openacs-4/packages/news/www/preview.tcl
Harden page contract, fix exporting of multiple revision ids

Use modern date formfields to avoid manual validation and handling of dates, harden page contract

    • -11
    • +7
    /openacs-4/packages/news/www/item-create.tcl
Clarify idiom, improve markup

Fix typo

Modernize idiom

Harden page contract, use modern date widget to avoid custom date parsing

Fix spec syntax

Cleanup variables never used and form never rendered

    • -15
    • +1
    /openacs-4/packages/calendar/www/mini-calendar.tcl
Harden and modernize page contract, remove reference to non-existing database columns from ancient downstream installations

Rework api to avoid extra checks

Reimplement conversion to and from Julian dates using modern Tcl api

Reinstate lost comment

Use modern date and time form input types so that the time values validated by the contract are the same used by the UI and no different values can be supplied to the form via the pseudo-fields for e.g. year, day and so on...

    • -81
    • +27
    /openacs-4/packages/calendar/www/cal-item-new.tcl
Improve validation

Cleanup leftover, fix typos

lc_time_tz_convert reform:

- enforce that only dates in the ISO format "%Y-%m-%d %H:%M:%S" are accepted

- apply clock api normalization to seemingly out of range time_values, as per https://www.tcl.tk/man/tcl/TclCmd/clock.html#M25

- return the empty string every time input is invalid or a conversion cannot be determined

- return a value, as ISO date, only when conversion is successful

- prefer the clock api to perform the conversion, but fall back to the ref-timezones datamodel when the timezone is not supported by Tcl