• last updated 29 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
use form_name in url

Remove unneded xql

Use more API when retrieving user info and portrait, streamline queries, put all sql inline

Reduce divergency between oracle and postgres codebase

    • -0
    • +31
    /openacs-4/packages/acs-templating/tcl/widget-procs.xql
Use API when retrieving user info

Remove unnecessary xql

Reduce divergencies between oracle and postgres codebase

Don't pass fine tcl variables through the query, avoid unnecessary quoting (bulk-mail api would pass variable to the stored procedure using ':' notation)

    • -9
    • +4
    /openacs-4/packages/dotlrn/www/spam.tcl
    • -7
    • +2
    /openacs-4/packages/dotlrn/www/spam.xql
Reduce divergencies between oracle and postgres codebase

Use more API when retrieving user info

Replace leftover Naviserver-only cache idioms with retro compatible ones

    • -5
    • +5
    /openacs-4/packages/chat/tcl/chat-procs.tcl
Put this last query also in the code as the others, so no xql is required

Use more API, reduce divergency between postgres and oracle code

Use more API

Use more API

Prefer API over handcrafted queries

Create chat room cache in a way to provide compatibility with AOLserver

make timeout and cache size configurable.

    • -1
    • +20
    /openacs-4/packages/chat/tcl/chat-init.tcl
    • -7
    • +1
    /openacs-4/packages/chat/tcl/chat-procs.tcl
make require_test_folder more configurable

use address from driver_info

add address to driver_info

    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
Remove unneded dict creation

    • -2
    • +2
    /openacs-4/packages/dotlrn/www/spam.tcl
modernize tcl

modernize tcl

Reduce code duplication, exploit API when retrieving user info

    • -73
    • +0
    /openacs-4/packages/dotlrn/www/spam-oracle.xql
    • -2
    • +6
    /openacs-4/packages/dotlrn/www/spam.tcl
    • -8
    • +63
    /openacs-4/packages/dotlrn/www/spam.xql
Remove redundant queries: user name is already retrieved above from cached user api

Reuse person API instead of querying by hand

Modernize idiom

Restore previous behavior: when a person is not found by email, just return empty string instead of an error

Reduce code duplication when retrieving person info

TODO centralize caching