OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 19
Total Committers: 146
Last Commit: 13:32
Commits this week: 19
Total Lines of Code (LoC): 7,561,347
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 56 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 26 Oct 2022
4:20 pm

gustafn

Reform of permissions UI in acs-subsite:

- use simplified tabular view "perm-include" per default, but

allow user to switch to old list-based view

- show number of inherited permissions by default instead of full list

(list can be long). Admin can switch to full list.

- improved configurability of permissions/one.tcl

* ability to pass privileges to be displayed

* provided flag to show inherited_permissions

* provided flag to show detailed permissions (list view)

- improved configurability of permissions/perm-include.tcl

* provided flag "detailed_permissions_p" to provide access

to the old style interface, where all types of privileges

can be provided to all types of parties

- improved functionality of www/permissions/perm-user-add-include

* added search field for filtering users

- modernized idioms

- improved spelling

- extended internationalization

- bumped version of acs-subsite to 5.10.1d9

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/acs-subsite.info
    • -4
    • +10
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.de_DE.ISO-8859-1.xml
    • -7
    • +13
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.en_US.ISO-8859-1.xml
    • -2
    • +2
    /openacs-4/packages/acs-subsite/tcl/application-group-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/admin/object-types/alphabetical-index.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/admin/site-map/index.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/members/user-new.tcl
    • -0
    • +19
    /openacs-4/packages/acs-subsite/www/permissions/one-oracle.xql
    • -0
    • +18
    /openacs-4/packages/acs-subsite/www/permissions/one-postgresql.xql
    • -29
    • +46
    /openacs-4/packages/acs-subsite/www/permissions/one.adp
    • -23
    • +42
    /openacs-4/packages/acs-subsite/www/permissions/one.tcl
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/permissions/perm-include.adp
    • -21
    • +67
    /openacs-4/packages/acs-subsite/www/permissions/perm-include.tcl
    • -11
    • +15
    /openacs-4/packages/acs-subsite/www/permissions/perm-modify.tcl
    • -0
    • +1
    /openacs-4/packages/acs-subsite/www/permissions/perm-user-add-include-oracle.xql
  16. … 5 more files in changeset.
4:18 pm

gustafn

UI improvements

- fixed link for reloading on apm/version-view page

- added generic icon name "check" (common icon name for checkmark)

- bumped version of acs-templating to 5.10.1d21

- bumped version of acs-admin to 5.10.1d3

Options
    • -3
    • +3
    /openacs-4/packages/acs-admin/acs-admin.info
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/version-reload.tcl
    • -3
    • +3
    /openacs-4/packages/acs-admin/www/apm/version-view.adp
    • -1
    • +2
    /openacs-4/packages/acs-admin/www/apm/version-view.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/acs-templating.info
    • -0
    • +3
    /openacs-4/packages/acs-templating/tcl/style-procs.tcl
4:09 pm

gustafn

- improved layout: removed text-decoration for anchors rendered as buttons.

Options
    • -2
    • +2
    /openacs-4/packages/openacs-bootstrap5-theme/resources/lists/table.adp
Tuesday 25 Oct 2022
2:18 pm

gustafn

fix list pagination for Bootstrap 5

Options
    • -20
    • +20
    /openacs-4/packages/openacs-bootstrap5-theme/resources/lists/table-2third.adp
    • -20
    • +20
    /openacs-4/packages/openacs-bootstrap5-theme/resources/lists/table.adp
1:10 pm

trenner

add information how many pages are currently selected in dnd mode

Options
    • -5
    • +5
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -0
    • +16
    /openacs-4/packages/xowiki/www/resources/selection-area.js
10:54 am

antoniop

Fix documentation

Options
    • -1
    • +3
    /openacs-4/packages/xolp/tcl/xolp-competency-procs.tcl
10:49 am

antoniop

Check that all competences exist inside of the get_set_id api, so that it can be embedded in the same query, make it possible that the returned set is empty, so that the require logic makes sense

Options
    • -32
    • +44
    /openacs-4/packages/xolp/tcl/xolp-competency-procs.tcl
10:20 am

antoniop

Take retrieving the set_id out of the transaction, comment de-facto dead code and add remark

Options
    • -16
    • +22
    /openacs-4/packages/xolp/tcl/xolp-competency-procs.tcl
9:01 am

antoniop

Prefer dict idioms

Options
    • -4
    • +2
    /openacs-4/packages/xolp/tcl/xolp-evaluation-procs.tcl
8:49 am

antoniop

Avoid extra transaction on single statement

Options
    • -10
    • +8
    /openacs-4/packages/xolp/tcl/xolp-activity-procs.tcl
8:46 am

antoniop

Inline SQL to fetch the current item and check for existance

Options
    • -4
    • +10
    /openacs-4/packages/xolp/tcl/xolp-activity-procs.tcl
8:37 am

antoniop

Go to the datamodel directly to reduce number of queries

Options
    • -6
    • +8
    /openacs-4/packages/xolp/tcl/xolp-activity-procs.tcl
7:51 am

antoniop

No need to check for existance in a separate query, prefer portable idioms

Options
    • -4
    • +5
    /openacs-4/packages/xolp/tcl/xolp-activity-procs.tcl
7:45 am

antoniop

Use a slightly faster idiom to check for existance

Options
    • -1
    • +3
    /openacs-4/packages/xolp/tcl/xolp-activity-procs.tcl
7:34 am

antoniop

Prefer doc as a tcl literal

Options
    • -2
    • +2
    /openacs-4/packages/xolp/tcl/xolp-indicator-procs.tcl
7:28 am

antoniop

Prefer plain NaviServer api to quote database lists

Options
    • -8
    • +4
    /openacs-4/packages/xolp/tcl/xolp-competency-procs.tcl
    • -4
    • +2
    /openacs-4/packages/xolp/tcl/xolp-indicator-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xolp/tcl/xolp-user-procs.tcl
Monday 24 Oct 2022
9:18 pm

gustafn

added a saftey-belt to handle empty labels

Options
    • -5
    • +18
    /openacs-4/packages/acs-subsite/www/permissions/perm-include.tcl
8:59 pm

gustafn

adp:icon: quote content of the "title" attribute

Options
    • -1
    • +2
    /openacs-4/packages/acs-templating/tcl/style-procs.tcl
7:35 pm

gustafn

break overlong lines

Options
    • -4
    • +7
    /openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
1:21 pm

gustafn

prefer adp:icon over old-style .gif images

Options
    • -4
    • +2
    /openacs-4/packages/categories/www/cadmin/category-links-view.tcl
    • -4
    • +2
    /openacs-4/packages/categories/www/cadmin/synonyms-view.tcl
    • -4
    • +2
    /openacs-4/packages/categories/www/cadmin/tree-view.tcl
    • -1
    • +1
    /openacs-4/packages/chat/lib/transcripts.tcl
    • -1
    • +1
    /openacs-4/packages/evaluation/lib/tasks-chunk.tcl
    • -2
    • +2
    /openacs-4/packages/evaluation/www/admin/evaluations/student-list.tcl
    • -3
    • +3
    /openacs-4/packages/evaluation/www/admin/grades/distribution-edit.tcl
    • -3
    • +3
    /openacs-4/packages/evaluation/www/admin/grades/grades.tcl
    • -1
    • +1
    /openacs-4/packages/evaluation-portlet/lib/tasks-chunk.tcl
    • -6
    • +2
    /openacs-4/packages/xotcl-core/lib/revisions.tcl
    • -4
    • +2
    /openacs-4/packages/acs-core-docs/www/tutorial-pages.adp
    • -3
    • +1
    /openacs-4/packages/acs-core-docs/www/files/tutorial/note-list.tcl
    • -1
    • +1
    /openacs-4/packages/assessment/www/asm-admin/one-section.adp
    • -1
    • +1
    /openacs-4/packages/assessment/www/asm-admin/questions.adp
1:04 pm

gustafn

prefer adp:icon over old-style .gif images

Options
    • -1
    • +1
    /openacs-4/packages/dotlrn-homework/www/file.adp
    • -2
    • +2
    /openacs-4/packages/dotlrn-homework/www/folder-chunk.adp
12:57 pm

gustafn

prefer adp:icon over old-style .gif images, whitespace changes

Options
    • -3
    • +3
    /openacs-4/packages/dotlrn/www/members-chunk-table.tcl
    • -21
    • +21
    /openacs-4/packages/dotlrn/www/admin/dotlrn-admins.tcl
12:20 pm

gustafn

prefer adp:icon over old-style .png images

Options
    • -7
    • +7
    /openacs-4/packages/new-portal/www/place-element.adp
    • -2
    • +2
    /openacs-4/packages/new-portal/www/layouts/title-buttons.adp
12:07 pm

gustafn

prefer adp:icon over old-style .png images

Options
    • -2
    • +3
    /openacs-4/packages/new-portal/new-portal.info
    • -6
    • +6
    /openacs-4/packages/new-portal/www/template-place-element.adp
    • -42
    • +35
    /openacs-4/packages/new-portal/www/template-place-element.tcl
11:42 am

gustafn

file arrow-left.png was initially added on branch oacs-5-10.

Options
    • binary
    /openacs-4/packages/acs-subsite/www/resources/arrow-left.png
11:42 am

gustafn

file link.gif was initially added on branch oacs-5-10.

Options
    • binary
    /openacs-4/packages/acs-subsite/www/shared/images/link.gif
11:42 am

gustafn

file arrow-right.png was initially added on branch oacs-5-10.

Options
    • binary
    /openacs-4/packages/acs-subsite/www/resources/arrow-right.png
11:42 am

gustafn

improved adp:icon support

- added images for arrow left and arrow right

- added arrow-left and arrow-right to the list of all supported icon sets

Options
    • -3
    • +3
    /openacs-4/packages/acs-subsite/acs-subsite.info
    • binary
    /openacs-4/packages/acs-subsite/www/resources/arrow-left.png
    • binary
    /openacs-4/packages/acs-subsite/www/resources/arrow-right.png
    • binary
    /openacs-4/packages/acs-subsite/www/shared/images/link.gif
    • -2
    • +2
    /openacs-4/packages/acs-templating/acs-templating.info
    • -4
    • +4
    /openacs-4/packages/acs-templating/tcl/style-procs.tcl
11:02 am

gustafn

update regenerated files

Options
    • -1
    • +1
    /openacs-4/packages/xowiki/resources/templates/oacs-view.adp
    • -1
    • +1
    /openacs-4/packages/xowiki/resources/templates/oacs-view2.adp
    • -1
    • +1
    /openacs-4/packages/xowiki/resources/templates/oacs-view3-bootstrap3.adp
    • -1
    • +1
    /openacs-4/packages/xowiki/resources/templates/oacs-view3.adp
    • -1
    • +1
    /openacs-4/packages/xowiki/resources/templates/view-book-no-ajax.adp
    • -1
    • +1
    /openacs-4/packages/xowiki/resources/templates/view-book.adp
    • -1
    • +1
    /openacs-4/packages/xowiki/resources/templates/view-default.adp
    • -1
    • +1
    /openacs-4/packages/xowiki/resources/templates/view-links.adp
    • -1
    • +1
    /openacs-4/packages/xowiki/resources/templates/view-plain-master.adp
    • -1
    • +1
    /openacs-4/packages/xowiki/resources/templates/view-plain.adp
11:00 am

gustafn

use the highcharts package if available

Options
    • -4
    • +16
    /openacs-4/packages/xotcl-request-monitor/www/index.tcl
    • -3
    • +13
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl