OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 5
Total Committers: 146
Last Commit: 20 Dec
Commits this week: 5
Total Lines of Code (LoC): 7,561,347
Net change in LoC this week: 335

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 03 Mar 2022
8:37 pm

gustafn

Delete CKEditor 3 (which was replaced by CKEditor 4 in 2012)

CKEditor 4 is continued to be supported.

Options
    • -188
    • +1
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -1433
    • +0
    /openacs-4/packages/xowiki/www/resources/ckeditor/CHANGES.html
    • -92
    • +0
    /openacs-4/packages/xowiki/www/resources/ckeditor/INSTALL.html
    • -1327
    • +0
    /openacs-4/packages/xowiki/www/resources/ckeditor/LICENSE.html
    • -955
    • +0
    /openacs-4/packages/xowiki/www/resources/ckeditor/ckeditor.asp
    • -149
    • +0
    /openacs-4/packages/xowiki/www/resources/ckeditor/ckeditor.js
    • -211
    • +0
    /openacs-4/packages/xowiki/www/resources/ckeditor/ckeditor.pack
    • -29
    • +0
    /openacs-4/packages/xowiki/www/resources/ckeditor/ckeditor.php
    • -8
    • +0
    /openacs-4/packages/xowiki/www/resources/ckeditor/ckeditor_basic.js
    • -20
    • +0
    /openacs-4/packages/xowiki/www/resources/ckeditor/ckeditor_basic_source.js
    • -566
    • +0
    /openacs-4/packages/xowiki/www/resources/ckeditor/ckeditor_php4.php
    • -556
    • +0
    /openacs-4/packages/xowiki/www/resources/ckeditor/ckeditor_php5.php
    • -35
    • +0
    /openacs-4/packages/xowiki/www/resources/ckeditor/ckeditor_source.js
    • -11
    • +0
    /openacs-4/packages/xowiki/www/resources/ckeditor/config.js
    • -25
    • +0
    /openacs-4/packages/xowiki/www/resources/ckeditor/contents.css
  16. … 591 more files in changeset.
8:06 pm

gustafn

reduce verbosity

Options
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/generic-procs.tcl
8:00 pm

gustafn

comment recent smelly change

+CVS: ----------------------------------------------------------------------

Options
    • -1
    • +10
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
7:40 pm

gustafn

Support specification of allowed tags/attributes/protocols via global package parameters.

This change makes it possible to define for a package values for

AllowedTags, AllowedAttributes, or AllowedProtocols. If (some of)

these exist, use these for configuring "ad_html_security_check". If +

not, fall back to the default (site wide) definition.

This change is fully backward compatible and effects on sites defining

such global parameters. This change was induced by the need of large

sites, where it is not feasible to set these parameters on the package

instance level, since this site has 830000 packages instances.

Bump version number to 5.10.1d19

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -4
    • +25
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
7:22 pm

gustafn

improve error message

Options
    • -4
    • +6
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
7:21 pm

gustafn

fix typo

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-utility-procs.tcl
4:17 pm

antoniop

Use a more stable logic to tell which image to use to store comments: if camera pictures are there, use those and otherwise use the desktop

Options
    • -8
    • +5
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
12:00 pm

antoniop

Filter consistently with the new definition of "reviewed"

Options
    • -4
    • +8
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
11:59 am

antoniop

Fix typo

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/www/review.tcl
11:43 am

antoniop

Fix the case of the last comment

Options
    • -5
    • +6
    /openacs-4/packages/proctoring-support/www/review.tcl
11:38 am

antoniop

Improve performance of delete operation

Options
    • -4
    • +4
    /openacs-4/packages/proctoring-support/www/review.tcl
10:35 am

antoniop

Usability improvement: disable the buttons to flag/unflag artifacts when these are already flagged/unflagged (applies also to bulk buttons)

Options
    • -2
    • +9
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
10:18 am

antoniop

Behavior reform:

now commenting an artifact won't be considered as "OK". To flag an artifact as "OK" or "for review", one has to explicitly click on the green and red buttons.

Options
    • -5
    • +0
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
    • -3
    • +9
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
    • -87
    • +0
    /openacs-4/packages/proctoring-support/www/review-all.tcl
    • -86
    • +112
    /openacs-4/packages/proctoring-support/www/review.tcl
10:12 am

antoniop

Apply filters also to new images coming from the websocket

Options
    • -0
    • +2
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
Wednesday 02 Mar 2022
8:33 pm

gustafn

allow fractional minutes (useful for short quizzes)

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
6:45 pm

antoniop

Make the border indicating the status of an artifact's review slightly bigger

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
6:43 pm

antoniop

Implement buttons to set all artifacts for a user as ok or not ok

Options
    • -2
    • +2
    /openacs-4/packages/proctoring-support/proctoring-support.info
    • -0
    • +4
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml
    • -0
    • +4
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml
    • -0
    • +4
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.it_IT.ISO-8859-1.xml
    • -1
    • +20
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
    • -2
    • +6
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
    • -0
    • +87
    /openacs-4/packages/proctoring-support/www/review-all.tcl
6:43 pm

antoniop

file review-all.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/proctoring-support/www/review-all.tcl
6:41 pm

gustafn

Improve robustness of upgrade script for legacy applications

In case, an installation has the legacy view (must be from very old installations)

in place, it is necessary to drop it before registered_users, otherwise

PostgreSQL will complain that it cannot drop view registered_users because

other objects depend on it.

Many thanks to Franz Penz to report this potential problem for old sites.

Options
    • -1
    • +7
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0-5.10.1d1.sql
6:01 pm

gustafn

Make ad_html_security_check configurable

ad_html_security_check has now three optional attributes

to make it configurable for different situations

-allowed_tags

-allowed_attributes

-allowed_protocols

If these attributes are not specified, the behavior is exactly like

before. This change makes it also easier to regression test this

function, since the behavior does not necessarily depend on a site's

parameter settings.

The function was also modernized, new regression tests were added.

Options
    • -47
    • +78
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -20
    • +39
    /openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl
4:43 pm

antoniop

Use only ok and flagged as color schemes, so that results can be investigated also while review is in progress

Options
    • -3
    • +1
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
    • -11
    • +4
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
4:38 pm

antoniop

Handle the case where only one type of artifacts is collected

Options
    • -3
    • +4
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
3:46 pm

antoniop

Replace private with public api

Options
    • -1
    • +4
    /openacs-4/packages/proctoring-support/tcl/test/proctoring-test-procs.tcl
3:03 pm

antoniop

Actually not enforce options validation on disabled formfields

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
2:57 pm

antoniop

Don't enforce options validation on disabled fields, demonstrate that this won't allow to insert invalid values in the field

Options
    • -0
    • +5
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
2:18 pm

antoniop

Fix the test, which was not actually reproducing the issue

in order to do so, I had to fix the behavior of acs::test::xpath::get_form_values: we should in fact NOT extract the value of disabled formfield, as a real browser will not send them in the POST request.

Options
    • -1
    • +21
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -4
    • +16
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
11:46 am

antoniop

Expose behavior:

extend date formfield test to include also a date in a specific format from downstream, set to disabled. Set the day of the month as a number < 10. Show that in this case the validation will complain about an invalid value. This because the field is represented as " 1" rather than the expected "1"

Options
    • -4
    • +8
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
Tuesday 01 Mar 2022
10:18 am

gustafn

Reduce hard errors in the search indexer on invalid file content

This change uses util::file_content_check introduced with acs-tcl

5.10.1d9 to detect error situations before external programs are

called, which can lead to unpredictable error messages.

bumped version to 5.10.1d1

Options
    • -3
    • +3
    /openacs-4/packages/search/search.info
    • -1
    • +11
    /openacs-4/packages/search/tcl/search-convert-procs.tcl
    • -2
    • +2
    /openacs-4/packages/search/tcl/search-procs.tcl
Monday 28 Feb 2022
9:14 pm

gustafn

fix issue shown with acunetix testing (without login)

Options
    • -3
    • +3
    /openacs-4/packages/search/www/search.tcl
7:17 pm

gustafn

guarantee uniqueness of IDs when multiple aggregated forms are used in one page (e.g. exam protocol)

Options
    • -2
    • +14
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl