OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 5
Total Committers: 146
Last Commit: 20 Dec
Commits this week: 5
Total Lines of Code (LoC): 7,561,347
Net change in LoC this week: 335

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 02 Mar 2022
6:01 pm

gustafn

Make ad_html_security_check configurable

ad_html_security_check has now three optional attributes

to make it configurable for different situations

-allowed_tags

-allowed_attributes

-allowed_protocols

If these attributes are not specified, the behavior is exactly like

before. This change makes it also easier to regression test this

function, since the behavior does not necessarily depend on a site's

parameter settings.

The function was also modernized, new regression tests were added.

Options
    • -47
    • +78
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -20
    • +39
    /openacs-4/packages/acs-tcl/tcl/test/html-conversion-procs.tcl
4:43 pm

antoniop

Use only ok and flagged as color schemes, so that results can be investigated also while review is in progress

Options
    • -3
    • +1
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
    • -11
    • +4
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
4:38 pm

antoniop

Handle the case where only one type of artifacts is collected

Options
    • -3
    • +4
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
3:46 pm

antoniop

Replace private with public api

Options
    • -1
    • +4
    /openacs-4/packages/proctoring-support/tcl/test/proctoring-test-procs.tcl
3:03 pm

antoniop

Actually not enforce options validation on disabled formfields

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
2:57 pm

antoniop

Don't enforce options validation on disabled fields, demonstrate that this won't allow to insert invalid values in the field

Options
    • -0
    • +5
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
2:18 pm

antoniop

Fix the test, which was not actually reproducing the issue

in order to do so, I had to fix the behavior of acs::test::xpath::get_form_values: we should in fact NOT extract the value of disabled formfield, as a real browser will not send them in the POST request.

Options
    • -1
    • +21
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -4
    • +16
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
11:46 am

antoniop

Expose behavior:

extend date formfield test to include also a date in a specific format from downstream, set to disabled. Set the day of the month as a number < 10. Show that in this case the validation will complain about an invalid value. This because the field is represented as " 1" rather than the expected "1"

Options
    • -4
    • +8
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
Tuesday 01 Mar 2022
10:18 am

gustafn

Reduce hard errors in the search indexer on invalid file content

This change uses util::file_content_check introduced with acs-tcl

5.10.1d9 to detect error situations before external programs are

called, which can lead to unpredictable error messages.

bumped version to 5.10.1d1

Options
    • -3
    • +3
    /openacs-4/packages/search/search.info
    • -1
    • +11
    /openacs-4/packages/search/tcl/search-convert-procs.tcl
    • -2
    • +2
    /openacs-4/packages/search/tcl/search-procs.tcl
Monday 28 Feb 2022
9:14 pm

gustafn

fix issue shown with acunetix testing (without login)

Options
    • -3
    • +3
    /openacs-4/packages/search/www/search.tcl
7:17 pm

gustafn

guarantee uniqueness of IDs when multiple aggregated forms are used in one page (e.g. exam protocol)

Options
    • -2
    • +14
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
6:41 pm

antoniop

Constrain the language we return for the connection to the ones we support: could happen on system that have supposted a language in the past and still have users set it as their preferred language

Options
    • -4
    • +4
    /openacs-4/packages/acs-lang/tcl/locale-procs.tcl
2:55 pm

antoniop

Additional CSP exceptions for Xinha

Options
    • -4
    • +11
    /openacs-4/packages/richtext-xinha/tcl/richtext-procs.tcl
Saturday 26 Feb 2022
4:50 pm

gustafn

improve class diagram drawing logic

- Draw always the superclass of the object of

interest, which might in the case of multiple

inheritance not in the "things" variable.

- don't draw lines twice in cases of multiple inheritance

Options
    • -6
    • +20
    /openacs-4/packages/xotcl-core/tcl/doc-procs.tcl
3:44 pm

gustafn

include DB interface classes in API-doc

Options
    • -1
    • +2
    /openacs-4/packages/acs-api-browser/tcl/api-doc-init.tcl
3:37 pm

gustafn

pass "hide methods" to svg generation

Options
    • -10
    • +21
    /openacs-4/packages/xotcl-core/tcl/doc-procs.tcl
    • -5
    • +3
    /openacs-4/packages/xotcl-core/www/show-object.tcl
2:23 pm

gustafn

switch from xo::db::sql to acs::dc interface

Options
    • -3
    • +3
    /openacs-4/packages/richtext-ckeditor4/richtext-ckeditor4.info
    • -2
    • +2
    /openacs-4/packages/richtext-ckeditor4/tcl/ckfinder-procs.tcl
Friday 25 Feb 2022
3:01 pm

gernst

Make the initial population of the request-monitor counters more robust

Options
    • -5
    • +9
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
2:09 pm

gustafn

simplify logic

Options
    • -4
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
2:04 pm

antoniop

Fix variable name

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
1:56 pm

gustafn

switch from xo::db::sql to acs::dc interface

Options
    • -2
    • +3
    /openacs-4/packages/chat/chat.info
    • -3
    • +2
    /openacs-4/packages/chat/tcl/chat-procs.tcl
    • -1
    • +1
    /openacs-4/packages/chat/tcl/xotcl-chat-procs.tcl
    • -2
    • +3
    /openacs-4/packages/dotlrn-xowiki/dotlrn-xowiki.info
    • -7
    • +7
    /openacs-4/packages/dotlrn-xowiki/tcl/xowiki-applet-procs.tcl
    • -2
    • +3
    /openacs-4/packages/xooauth/xooauth.info
    • -1
    • +1
    /openacs-4/packages/xooauth/tcl/package-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-request-monitor/xotcl-request-monitor.info
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/active-communities.tcl
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -2
    • +2
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
    • -1
    • +0
    /openacs-4/packages/xowf/tcl/test/xowf-test-procs.tcl
10:48 am

antoniop

Basic test of the proctoring upload endpoint

Options
    • -0
    • +92
    /openacs-4/packages/proctoring-support/tcl/test/proctoring-test-procs.tcl
Thursday 24 Feb 2022
10:41 am

antoniop

Switch to a select widget to keep a more predictable vertical size in case of many time presets

Options
    • -34
    • +21
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
Wednesday 23 Feb 2022
7:40 pm

gustafn

Prefer "::acs::dc call ..." over "::xo::db::sql::..."

Use the common new acs interface rather than the xotcl-core variant.

Goal should be on the medium time range to replace all of the

"::xo::db::sql::*" interface.

Options
    • -123
    • +136
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/06-package-procs.tcl
    • -15
    • +15
    /openacs-4/packages/xotcl-core/tcl/cr-procs.tcl
7:24 pm

gustafn

Align names used in utility db functions in Oracle and PostgreSQL

Over the years, the names used in the function for PostgreSQL and

Oracle drifted away, which is a problem when using call-by-name

convention for stored procedures. Furthermore, recent Oracle versions

do not allow attributes named "table" (for table_name). So the longer

version is now used uniformily. Fortunately, nsf allow abbreviation

for named parameters (like Tcl does), such one can use both

"-table_name" and "-table".

Bumped version number to 5.10.1d7.

Options
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -6
    • +6
    /openacs-4/packages/acs-kernel/sql/oracle/utilities-create.sql
    • -0
    • +312
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1d6-5.10.1d7.sql
    • -158
    • +157
    /openacs-4/packages/acs-kernel/sql/postgresql/utilities-create.sql
    • -0
    • +167
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d6-5.10.1d7.sql
7:24 pm

gustafn

file upgrade-5.10.1d6-5.10.1d7.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1d6-5.10.1d7.sql
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d6-5.10.1d7.sql
5:30 pm

antoniop

Notify new revisions on a proctoring artifact on the object's websocket, in a way that the users list, already designed to refresh in case on messages, will display new information when the revision is proceeding

Options
    • -4
    • +14
    /openacs-4/packages/proctoring-support/www/review.tcl
5:01 pm

antoniop

Fix typos

Options
    • -2
    • +2
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
4:15 pm

antoniop

Generate the fullscreen preview element in javascript and make it a child of the body, so that it can expand to the full page also when the include itself would be rendered in a smaller container

Options
    • -3
    • +3
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
4:07 pm

antoniop

Implement a pre-selection filter for timeframes, which can be extended using downstream specific logics

Options
    • -2
    • +2
    /openacs-4/packages/proctoring-support/proctoring-support.info
    • -0
    • +7
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml
    • -0
    • +2
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml
    • -0
    • +2
    /openacs-4/packages/proctoring-support/catalog/proctoring-support.it_IT.ISO-8859-1.xml
    • -1
    • +37
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
    • -0
    • +25
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
    • -0
    • +21
    /openacs-4/packages/proctoring-support/tcl/proctoring-callback-procs.tcl