OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 5
Total Committers: 146
Last Commit: 20 Dec
Commits this week: 5
Total Lines of Code (LoC): 7,561,347
Net change in LoC this week: 335

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 22 Jan
3:52 pm

antoniop

Use a better idiom to revert changes on the object, that e.g. will handle the same arrays and variables

Options
    • -4
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
3:11 pm

antoniop

Use an idiom that does not assume the form field to be a direct child of the form, which may not be true depending on the theme

Options
    • -1
    • +4
    /openacs-4/packages/acs-subsite/www/resources/core.js
2:49 pm

antoniop

Inline usages of acs_rte* js utilities in unmaintained packages and remove it from core.js

acs_rte* is most likely broken anyway, as nobody seems to define updateRTEs function...

Options
    • -14
    • +0
    /openacs-4/packages/acs-subsite/www/resources/core.js
2:49 pm

antoniop

Inline usages of acs_rte* js utilities in unmaintained packages and remove it from core.js

acs_rte* is most likely broken anyway, as nobody seems to define updateRTEs function...

Options
    • -1
    • +15
    /openacs-4/packages/dbm/www/lib/master.tcl
    • -0
    • +14
    /openacs-4/packages/imsld/lib/imsld-master.tcl
2:30 pm

antoniop

Factor richtext-or-file javascript outside of the core.js

This may or not be a step on the road to deprecating this widget, which still sports inline event handlers and is used only by unmaintained packages.

Options
    • -47
    • +0
    /openacs-4/packages/acs-subsite/www/resources/core.js
    • -1
    • +3
    /openacs-4/packages/acs-templating/tcl/richtext-or-file-procs.tcl
    • -0
    • +46
    /openacs-4/packages/acs-templating/www/resources/richtext-or-file.js
2:30 pm

antoniop

file richtext-or-file.js was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-templating/www/resources/richtext-or-file.js
Sunday 21 Jan
6:07 pm

gustafn

added support to install theme from install.xml

Options
    • -1
    • +21
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
Saturday 20 Jan
6:04 pm

gustafn

added bootstrap-icons to module list

Options
    • -0
    • +1
    /CVSROOT/modules
5:58 pm

gustafn

removed duplicated line

Options
    • -1
    • +0
    /CVSROOT/modules
5:57 pm

gustafn

updated and sorted module aliases

Options
    • -18
    • +26
    /CVSROOT/modules
Friday 19 Jan
11:11 am

antoniop

Replace explicit observer approach for lazy loading with modern HTML features

- images: use the loading attribute to request lazy loading (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#loading)

- audio: use the preload attribute to indicate that only metadata are needed at load time and not the entire media (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/audio#preload)

Options
    • -58
    • +9
    /openacs-4/packages/proctoring-support/lib/proctoring-display.adp
Tuesday 16 Jan
6:35 pm

antoniop

Ensure we are still connected before we try to render the error to the user

For instance, the error may have beeen triggered by unexpected lack of connection, e.g. when we try to return content after a redirect has already been issued.

Options
    • -4
    • +12
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
4:57 pm

antoniop

Avoid ambiguity depending on whether the submission is rendered on its

own to the user or to the teacher in feedback mode e.g. as part of the

exam protocol

Options
    • -5
    • +3
    /openacs-4/packages/xowf/lib/inclass-exam-answer.wf
Monday 15 Jan
3:25 pm

antoniop

Update automated test: we should not expect the title to be the same when the state becomes "done", as we strip the information not relevant for an ongoing exam

Options
    • -0
    • +1
    /openacs-4/packages/xowf/tcl/test/test-item-procs.tcl
12:42 pm

antoniop

Extend test: edit a different component of repeated compound 3 to also test that old and new values are stored as expected

Options
    • -0
    • +6
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
Wednesday 10 Jan
11:28 am

antoniop

Do not display information relevant only for an ongoing exam when this has been submitted

Options
    • -0
    • +7
    /openacs-4/packages/xowf/lib/inclass-exam-answer.wf
Tuesday 09 Jan
5:19 pm

antoniop

Also exclude unchecked checkboxes, the same as radio buttons, from the dictb entries returned from reading the form

Fixes xowiki.create_form_with_form_instance automated test

Options
    • -3
    • +4
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
5:17 pm

antoniop

Extend and fix xowiki.create_form_with_form_instance automated test with respect to checkbox behavior

- simple checkboxes (normal and repeated): as we do not specify a value for those, the default should be expected, not the last option

- checkboxes in repeated compound fields: upon triavial re-editing, the values should stay the same

This change exposes a bug in acs::test::xpath::get_form_values

Options
    • -8
    • +56
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
2:06 pm

antoniop

Handle differences in data-model between oracle and postgres, where oracle uses an additional filename column in the cr_revisions table when a revision points to a file

Many thanks to Josue Cardona for reporting the regression

Options
    • -3
    • +10
    /openacs-4/packages/acs-content-repository/tcl/revision-procs.tcl
Wednesday 20 Dec 2023
2:13 pm

antoniop

Port of downstream modification:

do not restrict the format the user can supply. Sanitize the filename later and complain only if this is made exclusively of invalid characters.

Options
    • -2
    • +12
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
12:04 pm

antoniop

get_form_data reform:

when validation fails, revert all changes performed on the object while filling up the form fields.

Rationale: when validation fails, we do not persist the data. The same we should not let unvalidated data sneak into the object, as this may be e.g. displayed on the page or be otherwise used by the system.

Options
    • -1
    • +15
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
Sunday 17 Dec 2023
8:28 pm

gustafn

Added support for automatic disconnect when a dynamic cluster node is shut down

When the dynamic cluster configuration has scale for certain

occasions, it makes sense to provide down scaling support when these

occasions are over, which does not rely on the configured cluster

disconnect timeout (ClusterAutodeleteInterval). The new code will send

automatically a disconnect request when a dynamic cluster node is

terminating gracefully.

Depending on the configuration, a new version of NaviServer will be

necessary to reliably execute disconnect requests. Appropriate changes

are in the NaviServer release/4.99 and main branches.

- Bumped version numbers:

* acs-tcl to 5.10.1b4

* acs-admin to 5.10.1b4

Options
    • -3
    • +3
    /openacs-4/packages/acs-admin/acs-admin.info
    • -5
    • +5
    /openacs-4/packages/acs-admin/www/cluster.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -9
    • +19
    /openacs-4/packages/acs-tcl/tcl/cluster-init.tcl
    • -41
    • +75
    /openacs-4/packages/acs-tcl/tcl/cluster-procs.tcl
Thursday 14 Dec 2023
10:57 am

antoniop

Do not retrieve extra_css from query_parameters, as this is vulnerable to injections

Many thanks to Markus Moser

Options
    • -2
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
Thursday 07 Dec 2023
2:42 pm

antoniop

Provide a specific message key for when messages are not available

Many thanks to Sebastian Scheder

Options
    • -2
    • +2
    /openacs-4/packages/chat/chat.info
    • -0
    • +1
    /openacs-4/packages/chat/catalog/chat.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/chat/catalog/chat.en_US.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/chat/catalog/chat.it_IT.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/chat/lib/current-messages.adp
Tuesday 05 Dec 2023
6:14 pm

gustafn

Adding auto-deletion of dynamic cluster nodes and small refactoring

- New kernel parameter "ClusterAutodeleteInterval" to specify, when a

dynamic cluster node is not regarded as temporarily unavailable but

as definitely gone. The default value for this parameter is 2m (2

minutes).

- small refactoring to reduce duplicated logic

- Bumped version numbers:

* acs-kernel to 5.10.1b4

* acs-tcl to 5.10.1b3

* acs-admin to 5.10.1b3

Options
    • -4
    • +4
    /openacs-4/packages/acs-admin/acs-admin.info
    • -13
    • +2
    /openacs-4/packages/acs-admin/www/cluster.tcl
    • -2
    • +3
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -0
    • +10
    /openacs-4/packages/acs-tcl/tcl/cluster-init.tcl
    • -10
    • +65
    /openacs-4/packages/acs-tcl/tcl/cluster-procs.tcl
Monday 04 Dec 2023
4:32 pm

gustafn

Small update for cluster support

- Improved visualization of cluster nodes that we lost contact to

- New kernel parameters to reduce hard-coded values and to make purpose more explicit

* new parameter ClusterHeartbeatInterval (default 20s),

was hardcoded before to the new default value

* renamed PreferredLocationRegexp -> ClusterPreferredLocationRegexp

* renamed EnableLoggingP -> ClusterEnableLoggingP

- Bumped version numbers:

* acs-kernel to 5.10.1b3

* acs-tcl to 5.10.1b2

* acs-admin to 5.10.1b2

acs-kernel acs-admin acs-tcl/

Options
    • -3
    • +3
    /openacs-4/packages/acs-admin/acs-admin.info
    • -2
    • +27
    /openacs-4/packages/acs-admin/www/cluster.tcl
    • -4
    • +5
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -0
    • +24
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1b2-5.10.1b3.sql
    • -0
    • +24
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1b2-5.10.1b3.sql
    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -4
    • +9
    /openacs-4/packages/acs-tcl/tcl/cluster-init.tcl
    • -2
    • +9
    /openacs-4/packages/acs-tcl/tcl/cluster-procs.tcl
4:32 pm

gustafn

file upgrade-5.10.1b2-5.10.1b3.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1b2-5.10.1b3.sql
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1b2-5.10.1b3.sql
3:19 pm

antoniop

template::widget::merge_tag_attributes has to be public already, as it is used by template::widget::select_locales

Options
    • -3
    • +3
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
Saturday 02 Dec 2023
12:10 pm

gustafn

Avoid duplicate entries in acs_sc_msg_type_elements

-- The three columns msg_type_id, element_name, and

-- element_msg_type_id identify the paramter uniquely, and must be

-- therefore not null.

Bump version number to 5.10.1b2

Options
    • -2
    • +2
    /openacs-4/packages/acs-service-contract/acs-service-contract.info
    • -4
    • +8
    /openacs-4/packages/acs-service-contract/sql/oracle/acs-sc-msg-types-create.sql
    • -0
    • +19
    /openacs-4/packages/acs-service-contract/sql/oracle/upgrade/upgrade-5.10.1b1-5.10.1b2.sql
    • -7
    • +7
    /openacs-4/packages/acs-service-contract/sql/postgresql/acs-sc-msg-types-create.sql
    • -0
    • +13
    /openacs-4/packages/acs-service-contract/sql/postgresql/upgrade/upgrade-5.10.1b1-5.10.1b2.sql
12:10 pm

gustafn

file upgrade-5.10.1b1-5.10.1b2.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-service-contract/sql/oracle/upgrade/upgrade-5.10.1b1-5.10.1b2.sql
    • -0
    • +0
    /openacs-4/packages/acs-service-contract/sql/postgresql/upgrade/upgrade-5.10.1b1-5.10.1b2.sql